Re: [oe] [meta-oe][PATCH] hwdata: allow to build native and nativesdk

[Markus Volk <f_l_k@t-online.de>]

[-- Attachment #1: Type: text/plain, Size: 1841 bytes --]

Got it. You suggest fixing hwdata .pc file first.
I didn't know about the pc_sysrootdir variable, thanks for pointing it 
out.

With this gehangen wlroots is built when 'native: true' is removed.
Would this be good enough to send upstream ,or should i create a patch 
for the hwdata recipe?

diff --git a/hwdata.pc.in b/hwdata.pc.in
index 8dd73b6..c5791d3 100644
--- a/hwdata.pc.in
+++ b/hwdata.pc.in
@@ -1,6 +1,6 @@
 prefix=@prefix@
 datadir=@datadir@
-pkgdatadir=@pkgdatadir@
+pkgdatadir=${pc_sysrootdir}@pkgdatadir@

 Name: @NAME@


Am Mi, 9. Nov 2022 um 16:43:40 +0000 schrieb Ross Burton 
<Ross.Burton@arm.com>:
> 
> 
>>  On 9 Nov 2022, at 16:01, Markus Volk via lists.openembedded.org 
>> <f_l_k=t-online.de@lists.openembedded.org 
>> <mailto:f_l_k=t-online.de@lists.openembedded.org>> wrote:
>> 
>>  At least they have a point for correctness by calling it 
>> build-dependency instead of runtime-dependency.
>> 
>>  I take your point that this difference shouldn't matter because 
>> hwdata is allarch, but simply removing 'native: true'
>>  does not fix the problem. hwdata will then be found, but the 
>> correct value will not be read here:
>>  hwdata_dir = hwdata.get_variable(pkgconfig: 'pkgdatadir')
>> 
>> 
>>  | Run-time dependency hwdata found: YES 0.364
>>  |
>>  | ../git/backend/drm/meson.build:4:1: ERROR: File 
>> /usr/share/hwdata/pnp.ids does not exist.
> 
> The problem here is that you're using a target path on the host, 
> pkgconfig just treats variables are literal strings and doesn’t do 
> any sysroot processing on them.
> 
> wayland-protocols does the right thing and puts the sysroot in the 
> pkgdatadir:
> 
> <https://gitlab.freedesktop.org/wayland/wayland-protocols/-/blob/main/wayland-protocols.pc.in>
> 
> wlroots should do this too.
> 
> Ross


[-- Attachment #2: Type: text/html, Size: 2288 bytes --]