From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53D21C43333 for ; Thu, 14 Jan 2021 01:53:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 23236206C0 for ; Thu, 14 Jan 2021 01:53:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728217AbhANBxW (ORCPT ); Wed, 13 Jan 2021 20:53:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47526 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729705AbhANABN (ORCPT ); Wed, 13 Jan 2021 19:01:13 -0500 Received: from ZenIV.linux.org.uk (zeniv.linux.org.uk [IPv6:2002:c35c:fd02::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E285DC061575 for ; Wed, 13 Jan 2021 15:49:43 -0800 (PST) Received: from jlbec by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzptR-00A5nn-Uf; Wed, 13 Jan 2021 23:49:38 +0000 Date: Wed, 13 Jan 2021 15:49:33 -0800 From: Joel Becker To: Bartosz Golaszewski Cc: Christoph Hellwig , Linux Kernel Mailing List , Kent Gibson , Linus Walleij , Andy Shevchenko , Bartosz Golaszewski Subject: Re: [RESEND PATCH v3 0/4] configfs: implement committable items and add sample code Message-ID: Mail-Followup-To: Bartosz Golaszewski , Christoph Hellwig , Linux Kernel Mailing List , Kent Gibson , Linus Walleij , Andy Shevchenko , Bartosz Golaszewski References: <20201229102235.29550-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Burt-Line: Trees are cool. X-Red-Smith: Ninety feet between bases is perhaps as close as man has ever come to perfection. Sender: Joel Becker Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 11, 2021 at 09:32:14AM +0100, Bartosz Golaszewski wrote: > On Tue, Dec 29, 2020 at 11:22 AM Bartosz Golaszewski wrote: > > > > From: Bartosz Golaszewski > > > > Committable items in configfs are well defined and documented but unfortunately > > so far never implemented. > > > > The use-case we have over at the GPIO subsystem is using configfs in > > conjunction with sysfs to replace our current gpio-mockup testing module > > with one that will be much more flexible and will allow complete coverage > > of the GPIO uAPI. > > > > The current gpio-mockup module is controlled using module parameters which > > forces the user to reload it everytime they need to change the chip > > configuration or layout and makes it difficult to extend its functionality. > > > > Testing module based on configfs would allow fine-grained control over dummy > > GPIO chips but since GPIO devices must be configured before they are > > instantiated, we need committable items. > > > > This implements them and adds code examples to configfs_sample module. The > > first two patches are just cosmetic. > > > > v1 -> v2: > > - fix a 'set but not used' build warning reported by kernel test robot > > > > v2 -> v3: > > - use (1UL << bit) instead of BIT() in patch 2/4 > > - extend configfs_dump_one() to make it print the new flags > > - clear the CONFIGFS_USET_DIR bit on the live group dirent > > > > Rebased on top of v5.11-rc1. > > > > Bartosz Golaszewski (4): > > configfs: increase the item name length > > configfs: use (1UL << bit) for internal flags > > configfs: implement committable items > > samples: configfs: add a committable group > > > > Documentation/filesystems/configfs.rst | 6 +- > > fs/configfs/configfs_internal.h | 22 +-- > > fs/configfs/dir.c | 240 ++++++++++++++++++++++++- > > fs/configfs/file.c | 8 + > > include/linux/configfs.h | 3 +- > > samples/configfs/configfs_sample.c | 150 ++++++++++++++++ > > 6 files changed, 409 insertions(+), 20 deletions(-) > > > > -- > > 2.29.1 > > > > Joel, Christoph, > > This series in its current form has been on the list for many weeks. > Are there any objections from your side against merging it for v5.12? Hey Bartosz, I don't have much time for code reviews these days (you can see my lack of mailing list stats), so I only saw your series today. I accidentally reviewed the first version, but my comments there still stand. Overall, I'm very happy to see this implemented. Thanks, Joel -- "Get right to the heart of matters. It's the heart that matters more." http://www.jlbec.org/ jlbec@evilplan.org