All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi@etezian.org>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 01/10] drm/i915: Mark up protected uses of 'i915_request_completed'
Date: Thu, 14 Jan 2021 05:01:15 +0200	[thread overview]
Message-ID: <X/+z+wPUkADDKCAd@jack.zhora.eu> (raw)
In-Reply-To: <20210113124600.656-1-chris@chris-wilson.co.uk>

Hi Chris,

> diff --git a/drivers/gpu/drm/i915/i915_request.c b/drivers/gpu/drm/i915/i915_request.c
> index 0b1a46a0d866..784c05ac5cca 100644
> --- a/drivers/gpu/drm/i915/i915_request.c
> +++ b/drivers/gpu/drm/i915/i915_request.c
> @@ -276,7 +276,7 @@ static void remove_from_engine(struct i915_request *rq)
>  
>  bool i915_request_retire(struct i915_request *rq)
>  {
> -	if (!i915_request_completed(rq))
> +	if (!__i915_request_is_complete(rq))


>  		return false;
>  
>  	RQ_TRACE(rq, "\n");
> @@ -342,8 +342,7 @@ void i915_request_retire_upto(struct i915_request *rq)
>  	struct i915_request *tmp;
>  
>  	RQ_TRACE(rq, "\n");
> -
> -	GEM_BUG_ON(!i915_request_completed(rq));
> +	GEM_BUG_ON(!__i915_request_is_complete(rq));

I might be a bit shallow, but where is the lock here?

Andi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2021-01-14  3:19 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-13 12:45 [Intel-gfx] [PATCH 01/10] drm/i915: Mark up protected uses of 'i915_request_completed' Chris Wilson
2021-01-13 12:45 ` [Intel-gfx] [PATCH 02/10] drm/i915: Drop i915_request.lock serialisation around await_start Chris Wilson
2021-01-14  3:01   ` Andi Shyti
2021-01-13 12:45 ` [Intel-gfx] [PATCH 03/10] drm/i915/gem: Reduce ctx->engine_mutex for reading the clone source Chris Wilson
2021-01-14  3:01   ` Andi Shyti
2021-01-13 12:45 ` [Intel-gfx] [PATCH 04/10] drm/i915/gem: Reduce ctx->engines_mutex for get_engines() Chris Wilson
2021-01-14  3:01   ` Andi Shyti
2021-01-13 12:45 ` [Intel-gfx] [PATCH 05/10] drm/i915: Reduce test_and_set_bit to set_bit in i915_request_submit() Chris Wilson
2021-01-14  3:02   ` Andi Shyti
2021-01-13 12:45 ` [Intel-gfx] [PATCH 06/10] drm/i915/gt: Drop atomic for engine->fw_active tracking Chris Wilson
2021-01-14  3:02   ` Andi Shyti
2021-01-13 12:45 ` [Intel-gfx] [PATCH 07/10] drm/i915/gt: Extract busy-stats for ring-scheduler Chris Wilson
2021-01-14  3:02   ` Andi Shyti
2021-01-14 11:58     ` Chris Wilson
2021-01-13 12:45 ` [Intel-gfx] [PATCH 08/10] drm/i915/gt: Convert stats.active to plain unsigned int Chris Wilson
2021-01-14  3:02   ` Andi Shyti
2021-01-13 12:45 ` [Intel-gfx] [PATCH 09/10] drm/i915/gt: Reduce engine runtime stats from seqlock to a latch Chris Wilson
2021-01-14  3:02   ` Andi Shyti
2021-01-13 12:46 ` [Intel-gfx] [PATCH 10/10] drm/i915/gt: Reduce GT " Chris Wilson
2021-01-14  3:03   ` Andi Shyti
2021-01-13 13:18 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/10] drm/i915: Mark up protected uses of 'i915_request_completed' Patchwork
2021-01-13 13:20 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-01-13 13:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-01-13 18:38 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-01-14  3:01 ` Andi Shyti [this message]
2021-01-14 12:03   ` [Intel-gfx] [PATCH 01/10] " Chris Wilson
2021-01-14 13:44     ` Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X/+z+wPUkADDKCAd@jack.zhora.eu \
    --to=andi@etezian.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.