From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A025C433E0 for ; Sat, 2 Jan 2021 12:17:25 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 81EED22285 for ; Sat, 2 Jan 2021 12:17:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 81EED22285 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0878C169B; Sat, 2 Jan 2021 13:16:31 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0878C169B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1609589841; bh=aSYfEUuhucnFqYAkxyVk5sJtpy/cEecSFmMksPdh3mo=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=CRGggx2MJ2x6YGCgxuGlzyvaiCVI8OOJqxO1WiBbCLTtT/MJqyZNevhqbEv/hHeZT wc29XCL9CZFywbYLuOeKu5IaST0ti5khe2baKG1T9M5J1ECBsc+AoRIGHn2Fh1bDDd wSNbbi2t/JTEllNSjkjTVUnO1fjW6gS2+lgde2q4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 8A8A9F8020C; Sat, 2 Jan 2021 13:16:30 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 29F04F8022B; Sat, 2 Jan 2021 13:16:27 +0100 (CET) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 75454F800B7 for ; Sat, 2 Jan 2021 13:16:19 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 75454F800B7 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="V7LEbQrJ" Received: by mail.kernel.org (Postfix) with ESMTPSA id B413F22241; Sat, 2 Jan 2021 12:16:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609589776; bh=aSYfEUuhucnFqYAkxyVk5sJtpy/cEecSFmMksPdh3mo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V7LEbQrJJV3ZpHOnXTA1knYYvfeevKkz6iB55RokiHrerp+8X9kPmBsMATULPJhAP L+xwMv6hFEZVZ3GiixMO612VYMmqfrDofVqTuPTgUa7PJVkbl75bIdKvEUo9OBNHqq zzLiTlEiSZNhB2XEPoGbpMVY7KiFSnk902VMuKRM= Date: Sat, 2 Jan 2021 13:16:12 +0100 From: Greg KH To: Christian Labisch Subject: Re: Haswell audio no longer working with new Catpt driver Message-ID: References: <8b005c64fe129fc2a283da90b2949b1fcb42e8c2.camel@gmail.com> <1ad341b1b0e0eefb83d157ac24d162eaad53ab32.camel@gmail.com> <0111f282-f044-47ed-f93e-5a19de61bdce@metafoo.de> <088cd3b6ba6589266e316d6adcb76861edd18775.camel@gmail.com> <1f5c37af35419358a8d7f22544490088675b2c3f.camel@gmail.com> <3dcc3129-aee5-0eea-0307-4eba7f03c0d6@metafoo.de> <83651c8002ae10e358693adfde65e85b3c95953d.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <83651c8002ae10e358693adfde65e85b3c95953d.camel@gmail.com> Cc: Takashi Iwai , "alsa-devel@alsa-project.org" , Lars-Peter Clausen , Takashi Iwai , amadeuszx.slawinski@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Sat, Jan 02, 2021 at 12:50:44PM +0100, Christian Labisch wrote: > On Fri, 2021-01-01 at 18:24 +0100, Takashi Iwai wrote: > > On Fri, 01 Jan 2021 14:40:39 +0100, > > Christian Labisch wrote: > > > > > > $ cat /sys/module/snd_hda_intel/parameters/power_save > > > 0 > > > > Hm, then the best would be to run git bisect for spotting out the > > breaking commit.  There has been no change in VIA codec driver at all > > between v5.9 and v5.10, so the rest possibility is either in HD-audio > > codec helper code or controller code (or both) -- if it's about the > > changes in the sound driver. > > > > Or you can try the oneliner below as a test shot; it might keep the > > widget node power D0, which is currently the only possible appearance > > of the difference between working and non-working cases. > > > > BTW, please avoid top-posting.  It's confusing. > > > > > > thanks, > > > > Takashi > > > > -- 8< -- > > --- a/sound/pci/hda/patch_via.c > > +++ b/sound/pci/hda/patch_via.c > > @@ -115,7 +115,7 @@ static struct via_spec *via_new_spec(struct hda_codec *codec) > >         spec->gen.keep_eapd_on = 1; > >         spec->gen.pcm_playback_hook = via_playback_pcm_hook; > >         spec->gen.add_stereo_mix_input = HDA_HINT_STEREO_MIX_AUTO; > > -       codec->power_save_node = 1; > > +       // codec->power_save_node = 1; > >         spec->gen.power_down_unused = 1; > >         codec->patch_ops = via_patch_ops; > >         return spec; > > Hi Takashi, > > Thank you ! I think we have tried what we could to work around this issue. > There is obviously something wrong with the kernel which has to get fixed. Yes, and that is what we are trying to figure out here. Does the above change work? > Hi Greg and Lars, > > From my understanding there are fundamental changes regarding the audio drivers. > The sound should (and has to) work out-of-the-box without any user interactions. Of course, but we need to figure out the change that caused the problem here. If someone who can reproduce this can run 'git bisect' that is the fastest way to make this happen. > As you can see in the post below, other users are facing exactly the same issue. > It would be great if this could be solved as soon as possible, maybe in 5.10.5 ? > > https://forum.manjaro.org/t/issue-after-kernel-5-10-update-speakers-not-working-on-laptop/45496 5.10.5 will be out next week, and that's not how stable kernels work. The fix needs to be in Linus's tree first before we can take it in a stable kernel release. We need to figure out the fix first before it can go anywhere... thanks, greg k-h