From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98ECDC433DB for ; Sat, 2 Jan 2021 18:25:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 60139207E2 for ; Sat, 2 Jan 2021 18:25:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726627AbhABSZF (ORCPT ); Sat, 2 Jan 2021 13:25:05 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:46404 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726619AbhABSZE (ORCPT ); Sat, 2 Jan 2021 13:25:04 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kvlZL-00Fdur-HB; Sat, 02 Jan 2021 19:24:03 +0100 Date: Sat, 2 Jan 2021 19:24:03 +0100 From: Andrew Lunn To: Adam Lackorzynski Cc: maz@kernel.org, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, linusw@kernel.org, kaloz@openwrt.org, khalasa@piap.pl, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, linux-gpio@vger.kernel.org, bgolaszewski@baylibre.com Subject: Re: [PATCH 2/6] irqchip/armada-370-xp: Fix return check in IPI alloc Message-ID: References: <20210102175859.335447-1-adam@l4re.org> <20210102175859.335447-2-adam@l4re.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210102175859.335447-2-adam@l4re.org> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Sat, Jan 02, 2021 at 06:58:55PM +0100, Adam Lackorzynski wrote: > __irq_domain_alloc_irqs returns a negative error > code upon failure, not only 0. Also use irq_domain_alloc_irqs > to require less default arguments. > > Signed-off-by: Adam Lackorzynski Fixes: f02147dd02eb ("irqchip/armada-370-xp: Configure IPIs as standard interrupts") Reviewed-by: Andrew Lunn Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36385C433DB for ; Sat, 2 Jan 2021 18:25:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DCB21207CD for ; Sat, 2 Jan 2021 18:25:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DCB21207CD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0sf8i2mxRDCMCJS0cGNVrMjkfqZP8DY1akfFT9qfyks=; b=fBjso1NmUIRXOkfQP9F0ctXx8 LaiPK2qWh9jpu+WLonv9SILFMRx+tZP47U6ip/3Ca7cWo7+ka0wxZYYLBVUm9YPmydLSpMN8w7LNT MZReU8PoKBydYxE23sBjoczo4rgusxPoJJqLT+QsOEnQr/9PPNdstEaLwdaN2oAqx1cthg6Duwq/o 3Ra9xV0/xdMZ7r/Iz/vqgWjQpfnCR8wM/HUChoVVHXiCz3/skMNlcccpEbur0tOBk7TjQhdZiaqa/ aOKhAH+Orxnci3Rf37h0PtWN20UE8pQc5WQE6wTwkexzmCql9HIkizdCV7DLUSCb4sgJci6jYUOw9 P3+6iOeMw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kvlZT-00072z-Hf; Sat, 02 Jan 2021 18:24:11 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kvlZR-00072a-LL for linux-arm-kernel@lists.infradead.org; Sat, 02 Jan 2021 18:24:10 +0000 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kvlZL-00Fdur-HB; Sat, 02 Jan 2021 19:24:03 +0100 Date: Sat, 2 Jan 2021 19:24:03 +0100 From: Andrew Lunn To: Adam Lackorzynski Subject: Re: [PATCH 2/6] irqchip/armada-370-xp: Fix return check in IPI alloc Message-ID: References: <20210102175859.335447-1-adam@l4re.org> <20210102175859.335447-2-adam@l4re.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210102175859.335447-2-adam@l4re.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210102_132409_711423_EFEE5EB4 X-CRM114-Status: UNSURE ( 7.43 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: bgolaszewski@baylibre.com, maz@kernel.org, linusw@kernel.org, linux-gpio@vger.kernel.org, khalasa@piap.pl, tglx@linutronix.de, kaloz@openwrt.org, gregory.clement@bootlin.com, linux-arm-kernel@lists.infradead.org, sebastian.hesselbarth@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jan 02, 2021 at 06:58:55PM +0100, Adam Lackorzynski wrote: > __irq_domain_alloc_irqs returns a negative error > code upon failure, not only 0. Also use irq_domain_alloc_irqs > to require less default arguments. > > Signed-off-by: Adam Lackorzynski Fixes: f02147dd02eb ("irqchip/armada-370-xp: Configure IPIs as standard interrupts") Reviewed-by: Andrew Lunn Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel