From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH] containers/netns: update netns shell test to new API
Date: Mon, 4 Jan 2021 10:47:44 +0100 [thread overview]
Message-ID: <X/LkQDXDehooa9wu@pevik> (raw)
In-Reply-To: <20201211172047.26640-1-kory.maincent@bootlin.com>
Hi Kory,
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> .../kernel/containers/netns/netns_breakns.sh | 60 ++++-----
> .../kernel/containers/netns/netns_comm.sh | 95 ++++++--------
> .../kernel/containers/netns/netns_helper.sh | 69 +++++-----
> .../kernel/containers/netns/netns_sysfs.sh | 118 +++++++-----------
> 4 files changed, 140 insertions(+), 202 deletions(-)
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Generally looks good to me.
Before merge I'll drop bogus '# TEST CASE #N' and add few TINFO messages, e.g.:
tst_res TINFO "controlling device over netlink"
Thanks!
Kind regards,
Petr
next prev parent reply other threads:[~2021-01-04 9:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 17:20 [LTP] [PATCH] containers/netns: update netns shell test to new API Kory Maincent
2021-01-04 9:47 ` Petr Vorel [this message]
2021-01-04 11:24 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/LkQDXDehooa9wu@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.