From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42F90C433E0 for ; Mon, 4 Jan 2021 13:24:01 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ADA83207AE for ; Mon, 4 Jan 2021 13:24:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ADA83207AE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kroah.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4D8btj06zzzDqN0 for ; Tue, 5 Jan 2021 00:23:57 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kroah.com (client-ip=64.147.123.24; helo=wout1-smtp.messagingengine.com; envelope-from=greg@kroah.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=kroah.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kroah.com header.i=@kroah.com header.a=rsa-sha256 header.s=fm2 header.b=BstwvCO4; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.a=rsa-sha256 header.s=fm1 header.b=CXuNXhgg; dkim-atps=neutral X-Greylist: delayed 361 seconds by postgrey-1.36 at bilbo; Tue, 05 Jan 2021 00:00:59 AEDT Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4D8bNC3PsnzDqLP for ; Tue, 5 Jan 2021 00:00:58 +1100 (AEDT) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 63BCF15D8; Mon, 4 Jan 2021 07:54:51 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 04 Jan 2021 07:54:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=KhhpB57NCBwpsFegDp/KnPnpp7y 0kN/0LqejfDPizYU=; b=BstwvCO45AX5wufflWvrmbBT66O2gIu3of5PillHp+B olanTnFeqtBX3bvOPUCHGQvtvj/At1/6yUrKqSCK2gpucasA8FklB5ryawame91E Jh72PBICEfwhoZTtbT7HuHZL9lCXqhh3rXkwzxjL3EnJt/7oP9bttVLLTirsFtw/ 4gcwOtslgVHC4DPzkQg765oQR2lU3SRWMmFLPYJc0TeV2JMzLDXT93dq0GsYBtTJ wOhJfwvIwf1wmwGuLSyUpdS4z0G/zPvkRDOv0CoTprcvinyT7IJZ5hFmS0hr165Q qN3cNKBfX/EMB0Cfqwn/aM6n/yADHB5TXXZv+L5cPLw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=KhhpB5 7NCBwpsFegDp/KnPnpp7y0kN/0LqejfDPizYU=; b=CXuNXhggS1+G2FAMsx5FRf 4gHh15OrQKgdFn36edFhpWruQtxNiSioWgTifqBzrVPGtlip0xqkmCxPTvPG/WNn jpczDrIsaftrAygtsXDf13zDwulrn3QD5sSE4fz8h4wEAK6DNut4ZF0LaK843cdH K8Q33ls4PqcZ/+9weNBGZSzfnMU4qG3fe/glwRMGw5yJh2mG2fAi7yNCio2ikMVM pi4D8VxVukDA8N/oc8x6rYe0coCmvR587gZ5U9xSzCZfrU5v2wlxsAaqvODb2tBV j1O2CYD/Ao7kyqvJ2XdDEhxAMcCoj5KMbcjzaXMyPdcVM0l99K1dQZ2AG4Nxfo+Q == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdeffedggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefirhgvghcu mffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucggtffrrghtthgvrhhnpeeuleeltd ehkeeltefhleduuddvhfffuedvffduveegheekgeeiffevheegfeetgfenucffohhmrghi nhepkhgvrhhnvghlrdhorhhgnecukfhppeekfedrkeeirdejgedrieegnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorghh rdgtohhm X-ME-Proxy: Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) by mail.messagingengine.com (Postfix) with ESMTPA id 786DC24005B; Mon, 4 Jan 2021 07:54:49 -0500 (EST) Date: Mon, 4 Jan 2021 13:56:16 +0100 From: Greg KH To: Santosh Sivaraj Subject: Re: [PATCH v3 0/6] Memory corruption may occur due to incorrent tlb flush Message-ID: References: <20200312132740.225241-1-santosh@fossix.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200312132740.225241-1-santosh@fossix.org> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sasha Levin , linuxppc-dev , stable@vger.kernel.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Thu, Mar 12, 2020 at 06:57:34PM +0530, Santosh Sivaraj wrote: > The TLB flush optimisation (a46cc7a90f: powerpc/mm/radix: Improve TLB/PWC > flushes) may result in random memory corruption. Any concurrent page-table walk > could end up with a Use-after-Free. Even on UP this might give issues, since > mmu_gather is preemptible these days. An interrupt or preempted task accessing > user pages might stumble into the free page if the hardware caches page > directories. > > The series is a backport of the fix sent by Peter [1]. > > The first three patches are dependencies for the last patch (avoid potential > double flush). If the performance impact due to double flush is considered > trivial then the first three patches and last patch may be dropped. > > This is only for v4.19 stable. > > [1] https://patchwork.kernel.org/cover/11284843/ Sorry for the delay, now queued up, let's see what the test-builders say about it... thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EB8FC433E0 for ; Mon, 4 Jan 2021 12:55:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1653D207B1 for ; Mon, 4 Jan 2021 12:55:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726480AbhADMzh (ORCPT ); Mon, 4 Jan 2021 07:55:37 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:55753 "EHLO wout1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726396AbhADMzh (ORCPT ); Mon, 4 Jan 2021 07:55:37 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 63BCF15D8; Mon, 4 Jan 2021 07:54:51 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 04 Jan 2021 07:54:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=KhhpB57NCBwpsFegDp/KnPnpp7y 0kN/0LqejfDPizYU=; b=BstwvCO45AX5wufflWvrmbBT66O2gIu3of5PillHp+B olanTnFeqtBX3bvOPUCHGQvtvj/At1/6yUrKqSCK2gpucasA8FklB5ryawame91E Jh72PBICEfwhoZTtbT7HuHZL9lCXqhh3rXkwzxjL3EnJt/7oP9bttVLLTirsFtw/ 4gcwOtslgVHC4DPzkQg765oQR2lU3SRWMmFLPYJc0TeV2JMzLDXT93dq0GsYBtTJ wOhJfwvIwf1wmwGuLSyUpdS4z0G/zPvkRDOv0CoTprcvinyT7IJZ5hFmS0hr165Q qN3cNKBfX/EMB0Cfqwn/aM6n/yADHB5TXXZv+L5cPLw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=KhhpB5 7NCBwpsFegDp/KnPnpp7y0kN/0LqejfDPizYU=; b=CXuNXhggS1+G2FAMsx5FRf 4gHh15OrQKgdFn36edFhpWruQtxNiSioWgTifqBzrVPGtlip0xqkmCxPTvPG/WNn jpczDrIsaftrAygtsXDf13zDwulrn3QD5sSE4fz8h4wEAK6DNut4ZF0LaK843cdH K8Q33ls4PqcZ/+9weNBGZSzfnMU4qG3fe/glwRMGw5yJh2mG2fAi7yNCio2ikMVM pi4D8VxVukDA8N/oc8x6rYe0coCmvR587gZ5U9xSzCZfrU5v2wlxsAaqvODb2tBV j1O2CYD/Ao7kyqvJ2XdDEhxAMcCoj5KMbcjzaXMyPdcVM0l99K1dQZ2AG4Nxfo+Q == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrvdeffedggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefirhgvghcu mffjuceoghhrvghgsehkrhhorghhrdgtohhmqeenucggtffrrghtthgvrhhnpeeuleeltd ehkeeltefhleduuddvhfffuedvffduveegheekgeeiffevheegfeetgfenucffohhmrghi nhepkhgvrhhnvghlrdhorhhgnecukfhppeekfedrkeeirdejgedrieegnecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorghh rdgtohhm X-ME-Proxy: Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) by mail.messagingengine.com (Postfix) with ESMTPA id 786DC24005B; Mon, 4 Jan 2021 07:54:49 -0500 (EST) Date: Mon, 4 Jan 2021 13:56:16 +0100 From: Greg KH To: Santosh Sivaraj Cc: stable@vger.kernel.org, linuxppc-dev , Michael Ellerman , Sasha Levin Subject: Re: [PATCH v3 0/6] Memory corruption may occur due to incorrent tlb flush Message-ID: References: <20200312132740.225241-1-santosh@fossix.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200312132740.225241-1-santosh@fossix.org> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Thu, Mar 12, 2020 at 06:57:34PM +0530, Santosh Sivaraj wrote: > The TLB flush optimisation (a46cc7a90f: powerpc/mm/radix: Improve TLB/PWC > flushes) may result in random memory corruption. Any concurrent page-table walk > could end up with a Use-after-Free. Even on UP this might give issues, since > mmu_gather is preemptible these days. An interrupt or preempted task accessing > user pages might stumble into the free page if the hardware caches page > directories. > > The series is a backport of the fix sent by Peter [1]. > > The first three patches are dependencies for the last patch (avoid potential > double flush). If the performance impact due to double flush is considered > trivial then the first three patches and last patch may be dropped. > > This is only for v4.19 stable. > > [1] https://patchwork.kernel.org/cover/11284843/ Sorry for the delay, now queued up, let's see what the test-builders say about it... thanks, greg k-h