From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F31ECC433E0 for ; Mon, 4 Jan 2021 14:44:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BD749221E5 for ; Mon, 4 Jan 2021 14:44:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726512AbhADOo4 (ORCPT ); Mon, 4 Jan 2021 09:44:56 -0500 Received: from os.inf.tu-dresden.de ([141.76.48.99]:42446 "EHLO os.inf.tu-dresden.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725889AbhADOo4 (ORCPT ); Mon, 4 Jan 2021 09:44:56 -0500 Received: from erwin.inf.tu-dresden.de ([141.76.48.80] helo=os.inf.tu-dresden.de) by os.inf.tu-dresden.de with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.94) id 1kwR5X-0006T1-5s; Mon, 04 Jan 2021 15:44:03 +0100 Date: Mon, 4 Jan 2021 15:43:58 +0100 From: Adam Lackorzynski To: Bartosz Golaszewski Cc: Marc Zyngier , Thomas Gleixner , arm-soc , linusw@kernel.org, Imre Kaloz , Krzysztof Halasa , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , linux-gpio Subject: Re: [PATCH 5/6] gpiolib: Fix return check of __irq_domain_alloc_irqs Message-ID: References: <20210102175859.335447-1-adam@l4re.org> <20210102175859.335447-5-adam@l4re.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.2 (2020-11-20) Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi, On Mon Jan 04, 2021 at 14:57:31 +0100, Bartosz Golaszewski wrote: > On Sat, Jan 2, 2021 at 6:59 PM Adam Lackorzynski wrote: > > > > 0 is not a proper IRQ number and also indicates failure. > > > > Signed-off-by: Adam Lackorzynski > > --- > > drivers/gpio/gpiolib.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > > index b02cc2abd3b6..9667e1a62626 100644 > > --- a/drivers/gpio/gpiolib.c > > +++ b/drivers/gpio/gpiolib.c > > @@ -1003,7 +1003,7 @@ static void gpiochip_set_hierarchical_irqchip(struct gpio_chip *gc, > > &fwspec, > > false, > > NULL); > > - if (ret < 0) { > > + if (ret <= 0) { > > chip_err(gc, > > "can not allocate irq for GPIO line %d parent hwirq %d in hierarchy domain: %d\n", > > i, parent_hwirq, > > -- > > 2.30.0.rc2 > > > > Does this commit depend in any way on others in this series or can I > apply it directly for fixes? It is independent, you can directly apply it. Thanks, Adam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D838C433DB for ; Mon, 4 Jan 2021 14:45:59 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E61B0207BC for ; Mon, 4 Jan 2021 14:45:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E61B0207BC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=l4re.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=K47Kp9yL4JKJOZ5tznDLKG0B0np3YoNjzUOlSz8Q7Ak=; b=VO97BSx2b9NH5mZf7EEFnKyBS uAJS4ibuWfl72ihcTXOseDtfpqUlCmxt+lAYD5qu3adjj8mv71Mcz5eHukv5QJo79hbl9uYgXNhzj 7ZAvbTwpv1mCz7s6woJslWNltNe4WcYllbX91evFvRopwZoG6I2/URbS+lVzQwFIZ0PP7abMxao5/ NvaiaPXKshQ2HQVw9mX7wp4HTK1R0NIex1zNjJT46qDrsnxXkPAjLb/VWoaVD1yLBuGY/xQN+ZGSa mTlnrnQQVYOHC3dr7xEIygjfOdYmny3I+kpQn+Ef8LRa8CqIWv0fz7GGAqvdy62jNJ580rvT7SQyB N1aleSjEQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwR5g-0007oJ-Sd; Mon, 04 Jan 2021 14:44:12 +0000 Received: from os.inf.tu-dresden.de ([141.76.48.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwR5d-0007nS-Gl for linux-arm-kernel@lists.infradead.org; Mon, 04 Jan 2021 14:44:10 +0000 Received: from erwin.inf.tu-dresden.de ([141.76.48.80] helo=os.inf.tu-dresden.de) by os.inf.tu-dresden.de with esmtps (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.94) id 1kwR5X-0006T1-5s; Mon, 04 Jan 2021 15:44:03 +0100 Date: Mon, 4 Jan 2021 15:43:58 +0100 From: Adam Lackorzynski To: Bartosz Golaszewski Subject: Re: [PATCH 5/6] gpiolib: Fix return check of __irq_domain_alloc_irqs Message-ID: References: <20210102175859.335447-1-adam@l4re.org> <20210102175859.335447-5-adam@l4re.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/2.0.2 (2020-11-20) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210104_094409_578146_9CC52488 X-CRM114-Status: GOOD ( 17.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Marc Zyngier , linusw@kernel.org, linux-gpio , Krzysztof Halasa , Thomas Gleixner , Imre Kaloz , Gregory Clement , arm-soc , Sebastian Hesselbarth Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Mon Jan 04, 2021 at 14:57:31 +0100, Bartosz Golaszewski wrote: > On Sat, Jan 2, 2021 at 6:59 PM Adam Lackorzynski wrote: > > > > 0 is not a proper IRQ number and also indicates failure. > > > > Signed-off-by: Adam Lackorzynski > > --- > > drivers/gpio/gpiolib.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > > index b02cc2abd3b6..9667e1a62626 100644 > > --- a/drivers/gpio/gpiolib.c > > +++ b/drivers/gpio/gpiolib.c > > @@ -1003,7 +1003,7 @@ static void gpiochip_set_hierarchical_irqchip(struct gpio_chip *gc, > > &fwspec, > > false, > > NULL); > > - if (ret < 0) { > > + if (ret <= 0) { > > chip_err(gc, > > "can not allocate irq for GPIO line %d parent hwirq %d in hierarchy domain: %d\n", > > i, parent_hwirq, > > -- > > 2.30.0.rc2 > > > > Does this commit depend in any way on others in this series or can I > apply it directly for fixes? It is independent, you can directly apply it. Thanks, Adam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel