From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Souptick Joarder <jrdr.linux@gmail.com>
Cc: Lubomir Rintel <lkundrak@v3.sk>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: ariel-pwrbutton.c: Remove unused variable ariel_pwrbutton_id_table[]
Date: Mon, 4 Jan 2021 14:02:13 -0800 [thread overview]
Message-ID: <X/OQZcsD15Fl/XVw@google.com> (raw)
In-Reply-To: <CAFqt6zb2O3SFx6xDtwdSgHYH-zeGXwuf1=Hr5yYXnCDqAza9KQ@mail.gmail.com>
On Tue, Dec 29, 2020 at 01:15:10PM +0530, Souptick Joarder wrote:
> On Tue, Dec 22, 2020 at 1:34 AM Souptick Joarder <jrdr.linux@gmail.com> wrote:
> >
> > Kernel test robot throws below warning ->
> >
> > >> drivers/input/misc/ariel-pwrbutton.c:152:35: warning: unused variable
> > >> 'ariel_pwrbutton_id_table' [-Wunused-const-variable]
> > static const struct spi_device_id ariel_pwrbutton_id_table[] = {
> > ^
> > 1 warning generated.
> >
> > Remove unused variable ariel_pwrbutton_id_table[] if no plan to use
> > it further.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
>
> Any comment on this patch ?
Lubomir, would you prefer to remove the table or add it to the driver
structure as ariel_pwrbutton_driver->id_table?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2021-01-04 23:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 20:04 [PATCH] input: ariel-pwrbutton.c: Remove unused variable ariel_pwrbutton_id_table[] Souptick Joarder
2020-12-29 7:45 ` Souptick Joarder
2021-01-04 22:02 ` Dmitry Torokhov [this message]
2021-01-12 3:20 ` Lubomir Rintel
2021-01-12 3:43 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/OQZcsD15Fl/XVw@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.