From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B75D7C433E0 for ; Tue, 5 Jan 2021 18:12:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 85D6322D5A for ; Tue, 5 Jan 2021 18:12:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726306AbhAESMn (ORCPT ); Tue, 5 Jan 2021 13:12:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:56244 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726132AbhAESMm (ORCPT ); Tue, 5 Jan 2021 13:12:42 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1791722D06; Tue, 5 Jan 2021 18:12:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609870321; bh=/reYBV40Ygz4hCARqF75dpeeGG0UhQDuHeRU1Mh/CCA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Dz7ZYIQwZi2PGezSrfZYXMAyFlGgRS3XZShhWjyXT3ufXIdHDHMXjuLt80KX6GoPf GG9vLFuw58bgfcX32hBzQHrbWIbM7IXR3efJsGv2iQnRdRw/2HGqFmSWyIJMZ/uav6 zW8xJU3VSIzNihZH289zC2LwLXOyr6xIMVOafDGE= Date: Tue, 5 Jan 2021 19:13:25 +0100 From: Greg Kroah-Hartman To: Rob Herring Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Jens Axboe , Stephen Boyd , Thierry Reding , MyungJoo Ham , Chanwoo Choi , Linus Walleij , Bartosz Golaszewski , Jonathan Cameron , Dmitry Torokhov , Thomas Gleixner , Marc Zyngier , Mauro Carvalho Chehab , Chen-Yu Tsai , Ulf Hansson , "David S. Miller" , Jakub Kicinski , Sebastian Reichel , Ohad Ben-Cohen , Bjorn Andersson , linux-arm-kernel@lists.infradead.org, linux-ide@vger.kernel.org, linux-clk@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-gpio@vger.kernel.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-media@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-pm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-spi@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH] dt-bindings: Add missing array size constraints Message-ID: References: <20210104230253.2805217-1-robh@kernel.org> <20210105174008.GB1875909@robh.at.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210105174008.GB1875909@robh.at.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Tue, Jan 05, 2021 at 10:40:08AM -0700, Rob Herring wrote: > On Tue, Jan 05, 2021 at 02:04:14PM +0100, Greg Kroah-Hartman wrote: > > On Mon, Jan 04, 2021 at 04:02:53PM -0700, Rob Herring wrote: > > > DT properties which can have multiple entries need to specify what the > > > entries are and define how many entries there can be. In the case of > > > only a single entry, just 'maxItems: 1' is sufficient. > > > > > > Add the missing entry constraints. These were found with a modified > > > meta-schema. Unfortunately, there are a few cases where the size > > > constraints are not defined such as common bindings, so the meta-schema > > > can't be part of the normal checks. > > > > > > Cc: Jens Axboe > > > Cc: Stephen Boyd > > > Cc: Thierry Reding > > > Cc: MyungJoo Ham > > > Cc: Chanwoo Choi > > > Cc: Linus Walleij > > > Cc: Bartosz Golaszewski > > > Cc: Jonathan Cameron > > > Cc: Dmitry Torokhov > > > Cc: Thomas Gleixner > > > Cc: Marc Zyngier > > > Cc: Mauro Carvalho Chehab > > > Cc: Chen-Yu Tsai > > > Cc: Ulf Hansson > > > Cc: "David S. Miller" > > > Cc: Jakub Kicinski > > > Cc: Sebastian Reichel > > > Cc: Ohad Ben-Cohen > > > Cc: Bjorn Andersson > > > Cc: Greg Kroah-Hartman > > > Signed-off-by: Rob Herring > > > > > > > > > diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > > index 247ef00381ea..f76b25f7fc7a 100644 > > > --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > > +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > > @@ -83,6 +83,7 @@ properties: > > > Phandle of a companion. > > > > > > phys: > > > + maxItems: 1 > > > description: PHY specifier for the USB PHY > > > > > > phy-names: > > > diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > > > index 2178bcc401bc..8e2bd61f2075 100644 > > > --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml > > > +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > > > @@ -71,6 +71,7 @@ properties: > > > Overrides the detected port count > > > > > > phys: > > > + maxItems: 1 > > > description: PHY specifier for the USB PHY > > > > > > phy-names: > > > diff --git a/Documentation/devicetree/bindings/usb/ingenic,musb.yaml b/Documentation/devicetree/bindings/usb/ingenic,musb.yaml > > > index 678396eeeb78..f506225a4d57 100644 > > > --- a/Documentation/devicetree/bindings/usb/ingenic,musb.yaml > > > +++ b/Documentation/devicetree/bindings/usb/ingenic,musb.yaml > > > @@ -40,7 +40,7 @@ properties: > > > - const: mc > > > > > > phys: > > > - description: PHY specifier for the USB PHY > > > + maxItems: 1 > > > > > > usb-role-switch: > > > type: boolean > > > > Any reason you dropped the description for this entry, but not the other > > ones above? > > No, I should have dropped those too. I dropped cases of genericish > descriptions on common properties. There's nothing specific to this > binding here really. > > > > > > diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > > > index 388245b91a55..adce36e48bc9 100644 > > > --- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > > > +++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > > > @@ -15,13 +15,14 @@ properties: > > > - const: ti,j721e-usb > > > > > > reg: > > > - description: module registers > > > + maxItems: 1 > > > > > > power-domains: > > > description: > > > PM domain provider node and an args specifier containing > > > the USB device id value. See, > > > Documentation/devicetree/bindings/soc/ti/sci-pm-domain.txt > > > + maxItems: 1 > > > > > > clocks: > > > description: Clock phandles to usb2_refclk and lpm_clk > > > > Same here, why remove the description? > > Really, the question is why keep 'description' on power-domains. Perhaps > there's a little value in the reference to sci-pm-domain.txt, so I left > it. Ok, if you are fine with this, that's ok with me, just didn't look very consistent :) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C551C433E0 for ; Tue, 5 Jan 2021 18:12:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2812C22D57 for ; Tue, 5 Jan 2021 18:12:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2812C22D57 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UaEDuz+LNDaL/U8AGSoM1ROey3L35MAqrGiXiMSTp0s=; b=Nl7xnL/HsdinhiWfYTwHMyzXQ 30A8PSS7+T0QCn/QCTBz/HQIhF6PGbC4UKEYhqfM2nOlKc6p0l+fUWuguqFGOsMEHnLmacTvMZddL vapu44N8U+GNlwKVYvSBVQZVA0W/j7XqKgFL5m4Thiw2VQKsKo0aEj1tdoKl5UoDJl5feEq0Wn2MK 4tpfHi27JXcj4O+rxV6cn24YY6eLx1oxBqe1SmItraxXlowaGmCmQydN3WIj0r/c+b9IkQDvu1Vqo hXnEFip0VNwM+gPqbrlr9X1+FjCCsda53lcNHw4cC2BFKUGm3pvy9RXPOXzKwf8jICpUDwDHAA7Pq jrP21PYPg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwqoT-00043y-GZ; Tue, 05 Jan 2021 18:12:09 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwqoN-0003zK-7i; Tue, 05 Jan 2021 18:12:04 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1791722D06; Tue, 5 Jan 2021 18:12:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609870321; bh=/reYBV40Ygz4hCARqF75dpeeGG0UhQDuHeRU1Mh/CCA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Dz7ZYIQwZi2PGezSrfZYXMAyFlGgRS3XZShhWjyXT3ufXIdHDHMXjuLt80KX6GoPf GG9vLFuw58bgfcX32hBzQHrbWIbM7IXR3efJsGv2iQnRdRw/2HGqFmSWyIJMZ/uav6 zW8xJU3VSIzNihZH289zC2LwLXOyr6xIMVOafDGE= Date: Tue, 5 Jan 2021 19:13:25 +0100 From: Greg Kroah-Hartman To: Rob Herring Subject: Re: [PATCH] dt-bindings: Add missing array size constraints Message-ID: References: <20210104230253.2805217-1-robh@kernel.org> <20210105174008.GB1875909@robh.at.kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210105174008.GB1875909@robh.at.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210105_131203_433911_C2DF21C2 X-CRM114-Status: GOOD ( 29.47 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , linux-usb@vger.kernel.org, linux-iio@vger.kernel.org, Linus Walleij , linux-remoteproc@vger.kernel.org, alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, Bjorn Andersson , linux-ide@vger.kernel.org, Thierry Reding , linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org, Chanwoo Choi , Marc Zyngier , Bartosz Golaszewski , Chen-Yu Tsai , MyungJoo Ham , linux-serial@vger.kernel.org, linux-input@vger.kernel.org, Jakub Kicinski , linux-media@vger.kernel.org, Ohad Ben-Cohen , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-gpio@vger.kernel.org, Thomas Gleixner , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, Jens Axboe , Stephen Boyd , netdev@vger.kernel.org, Dmitry Torokhov , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Sebastian Reichel , "David S. Miller" , Jonathan Cameron Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Tue, Jan 05, 2021 at 10:40:08AM -0700, Rob Herring wrote: > On Tue, Jan 05, 2021 at 02:04:14PM +0100, Greg Kroah-Hartman wrote: > > On Mon, Jan 04, 2021 at 04:02:53PM -0700, Rob Herring wrote: > > > DT properties which can have multiple entries need to specify what the > > > entries are and define how many entries there can be. In the case of > > > only a single entry, just 'maxItems: 1' is sufficient. > > > > > > Add the missing entry constraints. These were found with a modified > > > meta-schema. Unfortunately, there are a few cases where the size > > > constraints are not defined such as common bindings, so the meta-schema > > > can't be part of the normal checks. > > > > > > Cc: Jens Axboe > > > Cc: Stephen Boyd > > > Cc: Thierry Reding > > > Cc: MyungJoo Ham > > > Cc: Chanwoo Choi > > > Cc: Linus Walleij > > > Cc: Bartosz Golaszewski > > > Cc: Jonathan Cameron > > > Cc: Dmitry Torokhov > > > Cc: Thomas Gleixner > > > Cc: Marc Zyngier > > > Cc: Mauro Carvalho Chehab > > > Cc: Chen-Yu Tsai > > > Cc: Ulf Hansson > > > Cc: "David S. Miller" > > > Cc: Jakub Kicinski > > > Cc: Sebastian Reichel > > > Cc: Ohad Ben-Cohen > > > Cc: Bjorn Andersson > > > Cc: Greg Kroah-Hartman > > > Signed-off-by: Rob Herring > > > > > > > > > diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > > index 247ef00381ea..f76b25f7fc7a 100644 > > > --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > > +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > > @@ -83,6 +83,7 @@ properties: > > > Phandle of a companion. > > > > > > phys: > > > + maxItems: 1 > > > description: PHY specifier for the USB PHY > > > > > > phy-names: > > > diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > > > index 2178bcc401bc..8e2bd61f2075 100644 > > > --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml > > > +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > > > @@ -71,6 +71,7 @@ properties: > > > Overrides the detected port count > > > > > > phys: > > > + maxItems: 1 > > > description: PHY specifier for the USB PHY > > > > > > phy-names: > > > diff --git a/Documentation/devicetree/bindings/usb/ingenic,musb.yaml b/Documentation/devicetree/bindings/usb/ingenic,musb.yaml > > > index 678396eeeb78..f506225a4d57 100644 > > > --- a/Documentation/devicetree/bindings/usb/ingenic,musb.yaml > > > +++ b/Documentation/devicetree/bindings/usb/ingenic,musb.yaml > > > @@ -40,7 +40,7 @@ properties: > > > - const: mc > > > > > > phys: > > > - description: PHY specifier for the USB PHY > > > + maxItems: 1 > > > > > > usb-role-switch: > > > type: boolean > > > > Any reason you dropped the description for this entry, but not the other > > ones above? > > No, I should have dropped those too. I dropped cases of genericish > descriptions on common properties. There's nothing specific to this > binding here really. > > > > > > diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > > > index 388245b91a55..adce36e48bc9 100644 > > > --- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > > > +++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > > > @@ -15,13 +15,14 @@ properties: > > > - const: ti,j721e-usb > > > > > > reg: > > > - description: module registers > > > + maxItems: 1 > > > > > > power-domains: > > > description: > > > PM domain provider node and an args specifier containing > > > the USB device id value. See, > > > Documentation/devicetree/bindings/soc/ti/sci-pm-domain.txt > > > + maxItems: 1 > > > > > > clocks: > > > description: Clock phandles to usb2_refclk and lpm_clk > > > > Same here, why remove the description? > > Really, the question is why keep 'description' on power-domains. Perhaps > there's a little value in the reference to sci-pm-domain.txt, so I left > it. Ok, if you are fine with this, that's ok with me, just didn't look very consistent :) _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55130C433E0 for ; Tue, 5 Jan 2021 18:13:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0FC2D22D06 for ; Tue, 5 Jan 2021 18:13:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FC2D22D06 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Pnj6WuJ5ZX6DGK6a3Uo9jD4u3XdtnDHHavn0V/y447k=; b=ROWgTZ6KMHQ621l7gALz/rYqm Zw4eVCPXYiVER7BK/y5Zp2F/0puVycuER6h8ntln7ppGso83lYSvsVRPLB+1lZbhe4Fc8PPSXDdZG 7a1iirEokNyuWeLZAO2wjhzgzhzrxGN7J6RAa0ZtlPgu3y40qGVzfKnXe6yFg/xhnbm/TL6JTwDbm YkVJ7IZh5XiM/xXNXZdg/cFcIJgATHadfVTChtCB8W0OL0DRw5ghvPdx+Ha/kgEQA4PyR/D/0d7gW kDej1tXc92RS7HlSEu8O/R+QklgivfhqqJrbgEyXFNAWS7PDA68hYoRP4AGEhJpYRFA1AjyHH4PMg fEB/NzxcQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwqoQ-00041T-Gz; Tue, 05 Jan 2021 18:12:06 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kwqoN-0003zK-7i; Tue, 05 Jan 2021 18:12:04 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1791722D06; Tue, 5 Jan 2021 18:12:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609870321; bh=/reYBV40Ygz4hCARqF75dpeeGG0UhQDuHeRU1Mh/CCA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Dz7ZYIQwZi2PGezSrfZYXMAyFlGgRS3XZShhWjyXT3ufXIdHDHMXjuLt80KX6GoPf GG9vLFuw58bgfcX32hBzQHrbWIbM7IXR3efJsGv2iQnRdRw/2HGqFmSWyIJMZ/uav6 zW8xJU3VSIzNihZH289zC2LwLXOyr6xIMVOafDGE= Date: Tue, 5 Jan 2021 19:13:25 +0100 From: Greg Kroah-Hartman To: Rob Herring Subject: Re: [PATCH] dt-bindings: Add missing array size constraints Message-ID: References: <20210104230253.2805217-1-robh@kernel.org> <20210105174008.GB1875909@robh.at.kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210105174008.GB1875909@robh.at.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210105_131203_433911_C2DF21C2 X-CRM114-Status: GOOD ( 29.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , linux-usb@vger.kernel.org, linux-iio@vger.kernel.org, Linus Walleij , linux-remoteproc@vger.kernel.org, alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, Bjorn Andersson , linux-ide@vger.kernel.org, Thierry Reding , linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org, Chanwoo Choi , Marc Zyngier , Bartosz Golaszewski , Chen-Yu Tsai , MyungJoo Ham , linux-serial@vger.kernel.org, linux-input@vger.kernel.org, Jakub Kicinski , linux-media@vger.kernel.org, Ohad Ben-Cohen , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-gpio@vger.kernel.org, Thomas Gleixner , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, Jens Axboe , Stephen Boyd , netdev@vger.kernel.org, Dmitry Torokhov , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Sebastian Reichel , "David S. Miller" , Jonathan Cameron Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 05, 2021 at 10:40:08AM -0700, Rob Herring wrote: > On Tue, Jan 05, 2021 at 02:04:14PM +0100, Greg Kroah-Hartman wrote: > > On Mon, Jan 04, 2021 at 04:02:53PM -0700, Rob Herring wrote: > > > DT properties which can have multiple entries need to specify what the > > > entries are and define how many entries there can be. In the case of > > > only a single entry, just 'maxItems: 1' is sufficient. > > > > > > Add the missing entry constraints. These were found with a modified > > > meta-schema. Unfortunately, there are a few cases where the size > > > constraints are not defined such as common bindings, so the meta-schema > > > can't be part of the normal checks. > > > > > > Cc: Jens Axboe > > > Cc: Stephen Boyd > > > Cc: Thierry Reding > > > Cc: MyungJoo Ham > > > Cc: Chanwoo Choi > > > Cc: Linus Walleij > > > Cc: Bartosz Golaszewski > > > Cc: Jonathan Cameron > > > Cc: Dmitry Torokhov > > > Cc: Thomas Gleixner > > > Cc: Marc Zyngier > > > Cc: Mauro Carvalho Chehab > > > Cc: Chen-Yu Tsai > > > Cc: Ulf Hansson > > > Cc: "David S. Miller" > > > Cc: Jakub Kicinski > > > Cc: Sebastian Reichel > > > Cc: Ohad Ben-Cohen > > > Cc: Bjorn Andersson > > > Cc: Greg Kroah-Hartman > > > Signed-off-by: Rob Herring > > > > > > > > > diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > > index 247ef00381ea..f76b25f7fc7a 100644 > > > --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > > +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > > @@ -83,6 +83,7 @@ properties: > > > Phandle of a companion. > > > > > > phys: > > > + maxItems: 1 > > > description: PHY specifier for the USB PHY > > > > > > phy-names: > > > diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > > > index 2178bcc401bc..8e2bd61f2075 100644 > > > --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml > > > +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > > > @@ -71,6 +71,7 @@ properties: > > > Overrides the detected port count > > > > > > phys: > > > + maxItems: 1 > > > description: PHY specifier for the USB PHY > > > > > > phy-names: > > > diff --git a/Documentation/devicetree/bindings/usb/ingenic,musb.yaml b/Documentation/devicetree/bindings/usb/ingenic,musb.yaml > > > index 678396eeeb78..f506225a4d57 100644 > > > --- a/Documentation/devicetree/bindings/usb/ingenic,musb.yaml > > > +++ b/Documentation/devicetree/bindings/usb/ingenic,musb.yaml > > > @@ -40,7 +40,7 @@ properties: > > > - const: mc > > > > > > phys: > > > - description: PHY specifier for the USB PHY > > > + maxItems: 1 > > > > > > usb-role-switch: > > > type: boolean > > > > Any reason you dropped the description for this entry, but not the other > > ones above? > > No, I should have dropped those too. I dropped cases of genericish > descriptions on common properties. There's nothing specific to this > binding here really. > > > > > > diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > > > index 388245b91a55..adce36e48bc9 100644 > > > --- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > > > +++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > > > @@ -15,13 +15,14 @@ properties: > > > - const: ti,j721e-usb > > > > > > reg: > > > - description: module registers > > > + maxItems: 1 > > > > > > power-domains: > > > description: > > > PM domain provider node and an args specifier containing > > > the USB device id value. See, > > > Documentation/devicetree/bindings/soc/ti/sci-pm-domain.txt > > > + maxItems: 1 > > > > > > clocks: > > > description: Clock phandles to usb2_refclk and lpm_clk > > > > Same here, why remove the description? > > Really, the question is why keep 'description' on power-domains. Perhaps > there's a little value in the reference to sci-pm-domain.txt, so I left > it. Ok, if you are fine with this, that's ok with me, just didn't look very consistent :) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD58FC433DB for ; Tue, 5 Jan 2021 18:12:04 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7526D22D50 for ; Tue, 5 Jan 2021 18:12:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7526D22D50 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C25128982F; Tue, 5 Jan 2021 18:12:03 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id B343A8982F for ; Tue, 5 Jan 2021 18:12:01 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 1791722D06; Tue, 5 Jan 2021 18:12:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1609870321; bh=/reYBV40Ygz4hCARqF75dpeeGG0UhQDuHeRU1Mh/CCA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Dz7ZYIQwZi2PGezSrfZYXMAyFlGgRS3XZShhWjyXT3ufXIdHDHMXjuLt80KX6GoPf GG9vLFuw58bgfcX32hBzQHrbWIbM7IXR3efJsGv2iQnRdRw/2HGqFmSWyIJMZ/uav6 zW8xJU3VSIzNihZH289zC2LwLXOyr6xIMVOafDGE= Date: Tue, 5 Jan 2021 19:13:25 +0100 From: Greg Kroah-Hartman To: Rob Herring Subject: Re: [PATCH] dt-bindings: Add missing array size constraints Message-ID: References: <20210104230253.2805217-1-robh@kernel.org> <20210105174008.GB1875909@robh.at.kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210105174008.GB1875909@robh.at.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , linux-usb@vger.kernel.org, linux-iio@vger.kernel.org, linux-remoteproc@vger.kernel.org, alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org, Bjorn Andersson , linux-ide@vger.kernel.org, Thierry Reding , linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org, Chanwoo Choi , Marc Zyngier , Bartosz Golaszewski , Chen-Yu Tsai , MyungJoo Ham , linux-serial@vger.kernel.org, linux-input@vger.kernel.org, Jakub Kicinski , linux-media@vger.kernel.org, Ohad Ben-Cohen , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, linux-gpio@vger.kernel.org, Thomas Gleixner , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, Jens Axboe , Stephen Boyd , netdev@vger.kernel.org, Dmitry Torokhov , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Sebastian Reichel , "David S. Miller" , Jonathan Cameron Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jan 05, 2021 at 10:40:08AM -0700, Rob Herring wrote: > On Tue, Jan 05, 2021 at 02:04:14PM +0100, Greg Kroah-Hartman wrote: > > On Mon, Jan 04, 2021 at 04:02:53PM -0700, Rob Herring wrote: > > > DT properties which can have multiple entries need to specify what the > > > entries are and define how many entries there can be. In the case of > > > only a single entry, just 'maxItems: 1' is sufficient. > > > > > > Add the missing entry constraints. These were found with a modified > > > meta-schema. Unfortunately, there are a few cases where the size > > > constraints are not defined such as common bindings, so the meta-schema > > > can't be part of the normal checks. > > > > > > Cc: Jens Axboe > > > Cc: Stephen Boyd > > > Cc: Thierry Reding > > > Cc: MyungJoo Ham > > > Cc: Chanwoo Choi > > > Cc: Linus Walleij > > > Cc: Bartosz Golaszewski > > > Cc: Jonathan Cameron > > > Cc: Dmitry Torokhov > > > Cc: Thomas Gleixner > > > Cc: Marc Zyngier > > > Cc: Mauro Carvalho Chehab > > > Cc: Chen-Yu Tsai > > > Cc: Ulf Hansson > > > Cc: "David S. Miller" > > > Cc: Jakub Kicinski > > > Cc: Sebastian Reichel > > > Cc: Ohad Ben-Cohen > > > Cc: Bjorn Andersson > > > Cc: Greg Kroah-Hartman > > > Signed-off-by: Rob Herring > > > > > > > > > diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > > index 247ef00381ea..f76b25f7fc7a 100644 > > > --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > > +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > > > @@ -83,6 +83,7 @@ properties: > > > Phandle of a companion. > > > > > > phys: > > > + maxItems: 1 > > > description: PHY specifier for the USB PHY > > > > > > phy-names: > > > diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > > > index 2178bcc401bc..8e2bd61f2075 100644 > > > --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml > > > +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml > > > @@ -71,6 +71,7 @@ properties: > > > Overrides the detected port count > > > > > > phys: > > > + maxItems: 1 > > > description: PHY specifier for the USB PHY > > > > > > phy-names: > > > diff --git a/Documentation/devicetree/bindings/usb/ingenic,musb.yaml b/Documentation/devicetree/bindings/usb/ingenic,musb.yaml > > > index 678396eeeb78..f506225a4d57 100644 > > > --- a/Documentation/devicetree/bindings/usb/ingenic,musb.yaml > > > +++ b/Documentation/devicetree/bindings/usb/ingenic,musb.yaml > > > @@ -40,7 +40,7 @@ properties: > > > - const: mc > > > > > > phys: > > > - description: PHY specifier for the USB PHY > > > + maxItems: 1 > > > > > > usb-role-switch: > > > type: boolean > > > > Any reason you dropped the description for this entry, but not the other > > ones above? > > No, I should have dropped those too. I dropped cases of genericish > descriptions on common properties. There's nothing specific to this > binding here really. > > > > > > diff --git a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > > > index 388245b91a55..adce36e48bc9 100644 > > > --- a/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > > > +++ b/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml > > > @@ -15,13 +15,14 @@ properties: > > > - const: ti,j721e-usb > > > > > > reg: > > > - description: module registers > > > + maxItems: 1 > > > > > > power-domains: > > > description: > > > PM domain provider node and an args specifier containing > > > the USB device id value. See, > > > Documentation/devicetree/bindings/soc/ti/sci-pm-domain.txt > > > + maxItems: 1 > > > > > > clocks: > > > description: Clock phandles to usb2_refclk and lpm_clk > > > > Same here, why remove the description? > > Really, the question is why keep 'description' on power-domains. Perhaps > there's a little value in the reference to sci-pm-domain.txt, so I left > it. Ok, if you are fine with this, that's ok with me, just didn't look very consistent :) _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel