From: Simon Ruderich <simon@ruderich.org>
To: Denton Liu <liu.denton@gmail.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"Martin Ågren" <martin.agren@gmail.com>,
"SZEDER Gábor" <szeder.dev@gmail.com>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH v3 2/2] refs: allow @{n} to work with n-sized reflog
Date: Sun, 10 Jan 2021 21:31:18 +0100 [thread overview]
Message-ID: <X/tkFuESnia/n35e@ruderich.org> (raw)
In-Reply-To: <c88c997eab2b3405cce20f719bf07d5bba7aa18e.1610015769.git.liu.denton@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 705 bytes --]
On Thu, Jan 07, 2021 at 02:36:59AM -0800, Denton Liu wrote:
> diff --git a/refs.c b/refs.c
> index bfdd04aefd..e70dcd33f7 100644
> --- a/refs.c
> +++ b/refs.c
> @@ -900,40 +900,53 @@ static int read_ref_at_ent(struct object_id *ooid, struct object_id *noid,
> const char *message, void *cb_data)
> {
> struct read_ref_at_cb *cb = cb_data;
> + int reached_count;
>
> cb->tz = tz;
> cb->date = timestamp;
>
> - if (timestamp <= cb->at_time || cb->cnt == 0) {
> + /*
> + * It is not possible for cb->cnt == 0 on the first itertion because
s/itertion/iteration/
Regards
Simon
--
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-01-10 20:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-02 1:36 [PATCH] refs: allow @{n} to work with n-sized reflog Denton Liu
2021-01-02 22:30 ` Martin Ågren
2021-01-03 1:24 ` Denton Liu
2021-01-05 8:52 ` SZEDER Gábor
2021-01-06 5:55 ` Junio C Hamano
2021-01-06 8:25 ` Denton Liu
2021-01-06 21:02 ` Junio C Hamano
2021-01-06 9:01 ` [PATCH v2 0/2] " Denton Liu
2021-01-06 9:01 ` [PATCH v2 1/2] refs: factor out set_read_ref_cutoffs() Denton Liu
2021-01-06 9:01 ` [PATCH v2 2/2] refs: allow @{n} to work with n-sized reflog Denton Liu
2021-01-06 9:59 ` SZEDER Gábor
2021-01-07 10:36 ` [PATCH v3 0/2] " Denton Liu
2021-01-07 10:36 ` [PATCH v3 1/2] refs: factor out set_read_ref_cutoffs() Denton Liu
2021-01-07 10:36 ` [PATCH v3 2/2] refs: allow @{n} to work with n-sized reflog Denton Liu
2021-01-10 20:31 ` Simon Ruderich [this message]
2021-01-12 6:14 ` [PATCH v3] fixup! " Denton Liu
2021-01-12 6:18 ` Denton Liu
2021-01-12 6:27 ` Junio C Hamano
2021-01-10 14:44 ` [PATCH v3 0/2] " SZEDER Gábor
2021-01-10 20:24 ` Junio C Hamano
2021-01-07 10:43 ` [PATCH v3 3/2] fixup! " Denton Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/tkFuESnia/n35e@ruderich.org \
--to=simon@ruderich.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=liu.denton@gmail.com \
--cc=martin.agren@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.