All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/2] build.sh: Remove deprecated CROSS_COMPILE
Date: Mon, 11 Jan 2021 16:28:36 +0100	[thread overview]
Message-ID: <X/xupJgktrYI4LyG@pevik> (raw)
In-Reply-To: <20210111030704.5761-1-lizhijian@cn.fujitsu.com>

Hi Li,

> The CROSS_COMPILE was no longer used by ltp since 400ac9bbe20.

> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
> ---
>  build.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> diff --git a/build.sh b/build.sh
> index 452cc6f4c..602ca419e 100755
> --- a/build.sh
> +++ b/build.sh
> @@ -64,7 +64,7 @@ build_cross()
>  	fi

>  	echo "===== cross-compile ${host} ${1}-tree build into $PREFIX ====="
> -	build $1 $2 "--host=$host" CROSS_COMPILE="${host}-"
I looked what would require CROSS_COMPILE support. It's somehow duplicate to
autoconf --host parameter.

Although it wouldn't be difficult to add a support into configure.ac and
include/mk/config.mk.in via AC_ARG_VAR, it's use would require:

1) either migrate everything to pkg-config (but libnuma and libaio does not
support it) and use PKG_CONFIG_LIBDIR

2) fix host cpu detection in m4/ltp-host-cpu.m4 (parse CROSS_COMPILE).

=> IMHO it's not worth of doing it, thus good we removed it.

Kind regards,
Petr

> +	build $1 $2 "--host=$host"
>  }

>  build()

      parent reply	other threads:[~2021-01-11 15:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-11  3:07 [LTP] [PATCH 1/2] build.sh: Remove deprecated CROSS_COMPILE Li Zhijian
2021-01-11  3:07 ` [LTP] [PATCH 2/2] build.sh: support compiler with path prefix Li Zhijian
2021-01-11  3:45 ` [LTP] [PATCH 1/2] build.sh: Remove deprecated CROSS_COMPILE Xiao Yang
2021-01-11  8:45 ` Xiao Yang
2021-01-11 15:28 ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X/xupJgktrYI4LyG@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.