Re: [PATCH linux dev-5.8 v1 05/11] dt-binding: watchdog: Add DT restart priority and reset type

["Jonathan Neuschäfer" <j.neuschaefer@gmx.net>]

[-- Attachment #1: Type: text/plain, Size: 2911 bytes --]

Hello,

On Fri, Jan 01, 2021 at 02:23:22PM +0200, Tomer Maimon wrote:
> Add device tree resrart priority documentation and
                  resrart -> restart?

> three reset types documentation.
> 
> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> ---
>  .../bindings/watchdog/nuvoton,npcm-wdt.txt    | 32 +++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/watchdog/nuvoton,npcm-wdt.txt b/Documentation/devicetree/bindings/watchdog/nuvoton,npcm-wdt.txt
> index 6d593003c933..67ebf3386804 100644
> --- a/Documentation/devicetree/bindings/watchdog/nuvoton,npcm-wdt.txt
> +++ b/Documentation/devicetree/bindings/watchdog/nuvoton,npcm-wdt.txt
> @@ -17,7 +17,35 @@ Required clocking property, have to be one of:
>  
>  Optional properties:
>  - timeout-sec : Contains the watchdog timeout in seconds
> +- nuvoton,restart-priority - Contains the card restart priority.
> +- nuvoton,card-reset-type = "porst|corst|wd0|wd1|wd2|sw1|sw2|sw3|sw4"
> +  Contains the card reset type for checking and indicating 
> +  the last card reset status (WDIOF_CARDRESET)

What does "card" mean in this context?

> +  
> +  If 'nuvoton,card-reset-type' is not specified the default is porst
>  
> +  Reset types:
> +       - porst: Power reset
> +       - corst: Core reset
> +	   - wdX : Watchdog reset X (X represante 0-2)
> +	   - swX : Software reset X (X represante 1-4)

The indentation is inconsistent, here. The first two list items are
indented with spaces, the second two with tabs.

"represante" looks misspelled. Did you mean "represents"?

> +
> +- nuvoton,ext1-reset-type = "porst|corst|wd0|wd1|wd2|sw1|sw2|sw3|sw4"
> +  Contains the external 2 reset type for checking and indicating 
> +  the last external 2 reset status (WDIOF_EXTERN1)
              external 2 -> external 1

> +  
> +  If 'nuvoton,card-reset-type' is not specified the default is wd0.
                 card  ->  ext1


> +  
> +  Reset types are the same as in nuvoton,card-reset-type property.
> +
> +- nuvoton,ext2-reset-type = "porst|corst|wd0|wd1|wd2|sw1|sw2|sw3|sw4"
> +  Contains the external 2 reset type for checking and indicating 
> +  the last external 2 reset status (WDIOF_EXTERN2)
> +
> +  If 'nuvoton,card-reset-type' is not specified the default is sw1.
                 card  ->  ext2

> +  
> +  Reset types are the same as in nuvoton,card-reset-type property.
> +	   
>  Example:
>  
>  timer@f000801c {
> @@ -25,4 +53,8 @@ timer@f000801c {
>      interrupts = <GIC_SPI 47 IRQ_TYPE_LEVEL_HIGH>;
>      reg = <0xf000801c 0x4>;
>      clocks = <&clk NPCM7XX_CLK_TIMER>;
> +	nuvoton,restart-priority = <155>;
> +	nuvoton,card-reset-type = "porst";
> +	nuvoton,ext1-reset-type = "wd1";
> +	nuvoton,ext2-reset-type = "sw2";

Inconsistent indentation



Best regards,
Jonathan Neuschäfer

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]