From: sdf@google.com
To: Song Liu <song@kernel.org>
Cc: Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [PATCH bpf-next 2/2] bpf: split cgroup_bpf_enabled per attach type
Date: Mon, 21 Dec 2020 17:57:11 -0800 [thread overview]
Message-ID: <X+FSd9IEvxqEXmIr@google.com> (raw)
In-Reply-To: <CAPhsuW63um6NL6QF4E=iYpCeCiavuqYahO1h39Eu=agQU8LL5g@mail.gmail.com>
On 12/21, Song Liu wrote:
> On Thu, Dec 17, 2020 at 9:26 AM Stanislav Fomichev <sdf@google.com> wrote:
> >
> > When we attach any cgroup hook, the rest (even if unused/unattached)
> start
> > to contribute small overhead. In particular, the one we want to avoid is
> > __cgroup_bpf_run_filter_skb which does two redirections to get to
> > the cgroup and pushes/pulls skb.
> >
> > Let's split cgroup_bpf_enabled to be per-attach to make sure
> > only used attach types trigger.
> >
> > I've dropped some existing high-level cgroup_bpf_enabled in some
> > places because BPF_PROG_CGROUP_XXX_RUN macros usually have another
> > cgroup_bpf_enabled check.
> >
> > I also had to copy-paste BPF_CGROUP_RUN_SA_PROG_LOCK for
> > GETPEERNAME/GETSOCKNAME because type for cgroup_bpf_enabled[type]
> > has to be constant and known at compile time.
> >
> > Signed-off-by: Stanislav Fomichev <sdf@google.com>
> [...]
> > @@ -252,8 +252,10 @@ int bpf_percpu_cgroup_storage_update(struct
> bpf_map *map, void *key,
> > #define BPF_CGROUP_RUN_PROG_INET6_BIND_LOCK(sk,
> uaddr) \
> > BPF_CGROUP_RUN_SA_PROG_LOCK(sk, uaddr, BPF_CGROUP_INET6_BIND,
> NULL)
> >
> > -#define BPF_CGROUP_PRE_CONNECT_ENABLED(sk) (cgroup_bpf_enabled && \
> > - sk->sk_prot->pre_connect)
> > +#define
> BPF_CGROUP_PRE_CONNECT_ENABLED(sk) \
> > + ((cgroup_bpf_enabled(BPF_CGROUP_INET4_CONNECT) |
> | \
> > + cgroup_bpf_enabled(BPF_CGROUP_INET6_CONNECT))
> && \
> > + sk->sk_prot->pre_connect)
> Patchworks highlighted the following (from checkpatch.pl I guess):
> CHECK: Macro argument 'sk' may be better as '(sk)' to avoid precedence
> issues
> #99: FILE: include/linux/bpf-cgroup.h:255:
> +#define BPF_CGROUP_PRE_CONNECT_ENABLED(sk) \
> + ((cgroup_bpf_enabled(BPF_CGROUP_INET4_CONNECT) || \
> + cgroup_bpf_enabled(BPF_CGROUP_INET6_CONNECT)) && \
> + sk->sk_prot->pre_connect)
> Other than, looks good to me.
Good point, will fix in a respin.
> Acked-by: Song Liu <songliubraving@fb.com>
prev parent reply other threads:[~2020-12-22 1:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 17:23 [PATCH bpf-next 0/2] bpf: misc performance improvements for cgroup hooks Stanislav Fomichev
2020-12-17 17:23 ` [PATCH bpf-next 1/2] bpf: try to avoid kzalloc in cgroup/{s,g}etsockopt Stanislav Fomichev
2020-12-21 22:22 ` Song Liu
2020-12-22 2:09 ` sdf
2020-12-31 6:47 ` Martin KaFai Lau
2020-12-31 20:14 ` sdf
2021-01-04 21:01 ` Martin KaFai Lau
2020-12-21 22:25 ` Song Liu
2020-12-22 2:11 ` sdf
2020-12-22 19:11 ` Martin KaFai Lau
2020-12-23 3:09 ` sdf
2020-12-31 6:50 ` Martin KaFai Lau
2020-12-31 20:18 ` sdf
2020-12-17 17:23 ` [PATCH bpf-next 2/2] bpf: split cgroup_bpf_enabled per attach type Stanislav Fomichev
2020-12-21 22:40 ` Song Liu
2020-12-22 1:57 ` sdf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X+FSd9IEvxqEXmIr@google.com \
--to=sdf@google.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.