From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Salvatore Bonaccorso <carnil@debian.org>
Cc: stable@vger.kernel.org, Sasha Levin <sashal@kernel.org>,
Leo Yan <leo.yan@linaro.org>
Subject: Re: [PATCH 4.19.y only 0/2] Fix perf build failures
Date: Sun, 27 Dec 2020 12:42:53 +0100 [thread overview]
Message-ID: <X+hzPfhC4RCNCsU2@kroah.com> (raw)
In-Reply-To: <20201227092745.447945-1-carnil@debian.org>
On Sun, Dec 27, 2020 at 10:27:43AM +0100, Salvatore Bonaccorso wrote:
> Hi Greg, Sasha and all,
>
> This is a resubmit of the patches already done in
> https://lore.kernel.org/stable/20201125201215.26455-1-carnil@debian.org/
> and
> https://lore.kernel.org/stable/20201125201215.26455-2-carnil@debian.org/
>
> The issue can be explained as this. In
>
> https://lore.kernel.org/stable/20201014135627.GA3698844@kroah.com/
>
> on request 168200b6d6ea ("perf cs-etm: Move definition of 'traceid_list' global
> variable from header file") was queued back to 4.19.y to fix build failures for
> perf with more recent GCCs.
>
> But for 4.19.y this was wrong because it missed to pick as well a dependency
> needed, and in turn it caused build failures with older GCC (8.3.0 as used in
> Debian stable in that case).
>
> The commit was reverted in a later in 4.19.159.
>
> It as though requested to try to allow as well compilation with more recent
> GCCs (while obviously not breaking older GCC builds) and found that the cause
> was just the missing dependency to pick up, namely pick 95c6fe970a01 ("perf
> cs-etm: Change tuple from traceID-CPU# to traceID-metadata") before
> 168200b6d6ea ("perf cs-etm: Move definition of 'traceid_list' global variable
> from header file").
Thanks for these, both now queued up.
greg k-h
prev parent reply other threads:[~2020-12-27 11:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-27 9:27 [PATCH 4.19.y only 0/2] Fix perf build failures Salvatore Bonaccorso
2020-12-27 9:27 ` [PATCH 1/2] perf cs-etm: Change tuple from traceID-CPU# to traceID-metadata Salvatore Bonaccorso
2020-12-27 9:27 ` Salvatore Bonaccorso
2020-12-27 9:27 ` [PATCH 2/2] perf cs-etm: Move definition of 'traceid_list' global variable from header file Salvatore Bonaccorso
2020-12-27 9:27 ` Salvatore Bonaccorso
2020-12-27 11:42 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X+hzPfhC4RCNCsU2@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=carnil@debian.org \
--cc=leo.yan@linaro.org \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.