From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 0C3CDC433E0
	for <stable@archiver.kernel.org>; Sun, 27 Dec 2020 11:42:26 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id C120922512
	for <stable@archiver.kernel.org>; Sun, 27 Dec 2020 11:42:25 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726148AbgL0LmK (ORCPT <rfc822;stable@archiver.kernel.org>);
        Sun, 27 Dec 2020 06:42:10 -0500
Received: from mail.kernel.org ([198.145.29.99]:43288 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726139AbgL0LmJ (ORCPT <rfc822;stable@vger.kernel.org>);
        Sun, 27 Dec 2020 06:42:09 -0500
Received: by mail.kernel.org (Postfix) with ESMTPSA id DA7192250F;
        Sun, 27 Dec 2020 11:41:28 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
        s=korg; t=1609069289;
        bh=IG0AJFLNl2ql8ev+cer6CWAdCIZ4Psx8OjzIt2HKuiY=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=GMjYwQSfDwI3mbftgN1L2s2beBF04cuKfHky17Wfwlz0XGKiJj7UvWv2lp97wjdNA
         irCJQMWbuGHW2fJrwAXI5IYSSnzDzvFMsbffe+qFZPRMESyB0W42IvqWMvaHQxaxWf
         wb445s7TWPDiUMBx8m2yn8fD8wKLu7S6QIeDTqK8=
Date:   Sun, 27 Dec 2020 12:42:53 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Salvatore Bonaccorso <carnil@debian.org>
Cc:     stable@vger.kernel.org, Sasha Levin <sashal@kernel.org>,
        Leo Yan <leo.yan@linaro.org>
Subject: Re: [PATCH 4.19.y only 0/2] Fix perf build failures
Message-ID: <X+hzPfhC4RCNCsU2@kroah.com>
References: <20201227092745.447945-1-carnil@debian.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201227092745.447945-1-carnil@debian.org>
Precedence: bulk
List-ID: <stable.vger.kernel.org>
X-Mailing-List: stable@vger.kernel.org

On Sun, Dec 27, 2020 at 10:27:43AM +0100, Salvatore Bonaccorso wrote:
> Hi Greg, Sasha and all,
> 
> This is a resubmit of the patches already done in 
> https://lore.kernel.org/stable/20201125201215.26455-1-carnil@debian.org/
> and
> https://lore.kernel.org/stable/20201125201215.26455-2-carnil@debian.org/
> 
> The issue can be explained as this. In
> 
> https://lore.kernel.org/stable/20201014135627.GA3698844@kroah.com/
> 
> on request 168200b6d6ea ("perf cs-etm: Move definition of 'traceid_list' global
> variable from header file") was queued back to 4.19.y to fix build failures for
> perf with more recent GCCs.
> 
> But for 4.19.y this was wrong because it missed to pick as well a dependency
> needed, and in turn it caused build failures with older GCC (8.3.0 as used in
> Debian stable in that case).
> 
> The commit was reverted in a later in 4.19.159.
> 
> It as though requested to try to allow as well compilation with more recent
> GCCs (while obviously not breaking older GCC builds) and found that the cause
> was just the missing dependency to pick up, namely pick 95c6fe970a01 ("perf
> cs-etm: Change tuple from traceID-CPU# to traceID-metadata") before
> 168200b6d6ea ("perf cs-etm: Move definition of 'traceid_list' global variable
> from header file").

Thanks for these, both now queued up.

greg k-h