Re: [PATCH] fetch2/wget: include paramters in URL

["Patrick Williams" <patrick@stwcx.xyz>]

[-- Attachment #1: Type: text/plain, Size: 1506 bytes --]

On Tue, Dec 29, 2020 at 09:13:16AM -0600, Patrick Williams wrote:
> The wget fetcher currently silently drops all parameters and has
> been that way since it was originally introduced in fetch via 080eb8764.
> This prevents use in SOURCE_MIRROR_URL and SRC_URI which require
> additional parameters.
> 
> Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
> ---
>  lib/bb/fetch2/wget.py | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/bb/fetch2/wget.py b/lib/bb/fetch2/wget.py
> index e6d9f528..d41d7408 100644
> --- a/lib/bb/fetch2/wget.py
> +++ b/lib/bb/fetch2/wget.py
> @@ -99,7 +99,13 @@ class Wget(FetchMethod):
>          if ud.user and ud.pswd:
>              fetchcmd += " --user=%s --password=%s --auth-no-challenge" % (ud.user, ud.pswd)
>  
> -        uri = ud.url.split(";")[0]
> +        # Join the URL components together.
> +        urls = ud.url.split(";")
> +        if len(urls) == 1:
> +            uri = urls[0]
> +        else:
> +            uri = urls[0] + "?" + "&".join(urls[1:])
> +
>          if os.path.exists(ud.localpath):
>              # file exists, but we didnt complete it.. trying again..
>              fetchcmd += d.expand(" -c -P ${DL_DIR} '%s'" % uri)
> -- 
> 2.26.2
> 

This causes some problems that I need to work out more.  In my downloads
directory I ended up with files like:

    'libxml2-2.9.10.tar.gz?name=libtar'
    'libxml2-2.9.10.tar.gz?name=libtar.1'

-- 
Patrick Williams

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 849 bytes --]