From: Greg KH <gregkh@linuxfoundation.org>
To: yaoaili126@163.com
Cc: yaoaili@kingsoft.com, stable@vger.kernel.org
Subject: Re: [PATCH] ACPI, APEI, Fix error return value in apei_map_generic_address()
Date: Tue, 10 Nov 2020 10:19:22 +0100 [thread overview]
Message-ID: <X6pbGq24Gta7Go0t@kroah.com> (raw)
In-Reply-To: <20201110082942.456745-1-yaoaili126@163.com>
On Tue, Nov 10, 2020 at 12:29:42AM -0800, yaoaili126@163.com wrote:
> From: Aili Yao <yaoaili@kingsoft.com>
>
> >From commit 6915564dc5a8 ("ACPI: OSL: Change the type of
> acpi_os_map_generic_address() return value"),
> acpi_os_map_generic_address() will return logical address or NULL for
> error, but for ACPI_ADR_SPACE_SYSTEM_IO case, it should be also return 0,
> as it's a normal case, but now it will return -ENXIO. so check it out for
> such case to avoid einj module initialization fail.
>
> Fixes: 6915564dc5a8 ("ACPI: OSL: Change the type of
> acpi_os_map_generic_address() return value")
> Cc: <stable@vger.kernel.org>
> Reviewed-by: James Morse <james.morse@arm.com>
> Tested-by: Tony Luck <tony.luck@intel.com>
> Signed-off-by: Aili Yao <yaoaili@kingsoft.com>
> ---
> drivers/acpi/apei/apei-base.c | 4 ++++
> 1 file changed, 4 insertions(+)
I'm confused as to what you are asking us to do with this patch? Have
you read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly?
thanks,
greg k-h
next prev parent reply other threads:[~2020-11-10 9:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 8:29 [PATCH] ACPI, APEI, Fix error return value in apei_map_generic_address() yaoaili126
2020-11-10 9:19 ` Greg KH [this message]
2020-11-10 9:42 ` yaoaili [么爱利]
2020-11-10 9:49 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2020-11-10 8:33 yaoaili126
2020-11-16 18:30 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X6pbGq24Gta7Go0t@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=stable@vger.kernel.org \
--cc=yaoaili126@163.com \
--cc=yaoaili@kingsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.