From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1keEYZ-0001GC-Kp for mharc-grub-devel@gnu.org; Sun, 15 Nov 2020 04:42:47 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38788) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keEYY-0001G4-3j for grub-devel@gnu.org; Sun, 15 Nov 2020 04:42:46 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:60325) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1keEYW-0001b0-GJ for grub-devel@gnu.org; Sun, 15 Nov 2020 04:42:45 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 11F2F5C0093; Sun, 15 Nov 2020 04:42:44 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 15 Nov 2020 04:42:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=laSVYtDb4uzPmQyHl/b26HUIB25 nYhxsfABH437hw5I=; b=EF+kH4CrxJb0JHdaewfa1W0XJ81QibLLO7Mo/Sg0xW+ HHiI1+vAaKUIdPGepbm6LVIHTw66JEDMWNZaFKHrNMnAONyfFLQZuA9vjznxy66M 32OxrHHMAuOIfYRN8tdkzN7M1fOYxLsv5mqH0/x+KAku6bcY3sYgMi0tHRRQRihB +LVrRdWbPHh8PjEj/atv1lc+Fe9I44sn06JEx434gjDqyLpKGKBiXuhxWpkldIVy MPy3PeQHSbTJcZ0lHgiuJECwHmM9iH9mi+IbWdkfT+wwlqKx0pB+mdAh/2rFv/1J op+eBF1YLziyH3+wvW50eAU87qN0RXpWv3KsEZzuoow== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=laSVYt Db4uzPmQyHl/b26HUIB25nYhxsfABH437hw5I=; b=XrWySyQKLYmuo4ZLv5e9Ev F3t3F3ffOI454yq1yoKmW55FU9x+AUR6DaNJyTJq/GRpkJHoCE7IICI6eOKMZIkI O2gwkHcO3u2fFvIPhRn0Uo5rFv6UAlgNgi+93N4dmWWpbWWGwNhXmHfDCg6c5PCY ekCcRGwyVuvxA2ueP6I/bJOw1q0K3s/oEbblCmFQukMKMsjxTD6tT2dvIWc3xI6/ PpXHClJyeULZwCZaVHxHMANsnObuNVSbhNcxJRSTVBxd4ZvwY2AaYd0MHcvuwnZR YjwNuFwb1VHxEBkwE1LO2bkpHzITfwzWXiEfFKxG4Qo713Gf0vT0Nlt34vsXcT+A == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddvledgtdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefrrghtrhhi tghkucfuthgvihhnhhgrrhguthcuoehpshesphhkshdrihhmqeenucggtffrrghtthgvrh hnpeehgefhtdefueffheekgfffudelffejtdfhvdejkedthfehvdelgfetgfdvtedthfen ucfkphepjeekrdehgedrvddurddvtdeinecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepphhssehpkhhsrdhimh X-ME-Proxy: Received: from vm-mail.pks.im (dynamic-078-054-021-206.78.54.pool.telefonica.de [78.54.21.206]) by mail.messagingengine.com (Postfix) with ESMTPA id DFBE23280063; Sun, 15 Nov 2020 04:42:42 -0500 (EST) Received: from localhost (ncase [10.192.0.11]) by vm-mail.pks.im (OpenSMTPD) with ESMTPSA id 702c5862 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 15 Nov 2020 09:42:41 +0000 (UTC) Date: Sun, 15 Nov 2020 10:42:39 +0100 From: Patrick Steinhardt To: Glenn Washburn Cc: grub-devel@gnu.org, Daniel Kiper Subject: Re: [PATCH v4 04/15] types: Define GRUB_CHAR_BIT based on compiler macro instead of using literal. Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="D2l9TWy6HXXkBHlh" Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=66.111.4.27; envelope-from=ps@pks.im; helo=out3-smtp.messagingengine.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/15 04:37:28 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Nov 2020 09:42:46 -0000 --D2l9TWy6HXXkBHlh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Nov 06, 2020 at 10:44:24PM -0600, Glenn Washburn wrote: > Signed-off-by: Glenn Washburn > --- > include/grub/types.h | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) >=20 > diff --git a/include/grub/types.h b/include/grub/types.h > index 035a4b528..495c86bb1 100644 > --- a/include/grub/types.h > +++ b/include/grub/types.h > @@ -72,6 +72,14 @@ > # endif > #endif > =20 > +#ifndef __CHAR_BIT__ > +#error __CHAR_BIT__ is not defined > +#elif __CHAR_BIT__ !=3D 8 > +#error __CHAR_BIT__ is not equal 8 > +#else > +#define GRUB_CHAR_BIT __CHAR_BIT__ > +#endif > + Nested defines typically use spaces: #ifndef __CHAR_BIT__ # error __CHAR_BIT__ is not defined #elif __CHAR_BIT__ !=3D 8 # error __CHAR_BIT__ is not equal 8 #else # define GRUB_CHAR_BIT __CHAR_BIT__ #endif Patrick > /* Define various wide integers. */ > typedef signed char grub_int8_t; > typedef short grub_int16_t; > @@ -317,6 +325,4 @@ static inline void grub_set_unaligned64 (void *ptr, g= rub_uint64_t val) > dd->d =3D val; > } > =20 > -#define GRUB_CHAR_BIT 8 > - > #endif /* ! GRUB_TYPES_HEADER */ > --=20 > 2.27.0 >=20 --D2l9TWy6HXXkBHlh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF9hrgiFbCdvenl/rVbJhu7ckPpQFAl+w+A4ACgkQVbJhu7ck PpTN4w//cQFL0g8w6yAz0+Q5tnZT+9KzSNgzROJtw+dbr88qQDGRz9JPYehyswO/ m1qup4cnu7whktvaEj09gTuusKNN/a03P7eo2dpZPCR5R/9Wtz+rYsykAEd5becF IpMJGptzkFUoIY0Q9gmIfk1LBZ4SIh5TYAX1cQ/fIhFiAxO1z0Jkju7IV/DtO+I5 3VMBQHHInh29GuQyAK2Md5ca37D+pHiTMgNdSF/GgypiVZTaMxxDE7ZIn1EbB3Iz fYEYmPLYuHYrL3I0+vxk2ab1cj7rU+xbJoonsdYY06B0oX14lVbg9pZ/68jGRo7/ Ua1AqYmCN8m2jwRAdhTiehHvqlIH8HoAdx1sMmF7TaxKSyCirif/wdfDBMoYkFBy Wdvm0kjz8QbIQO8vKunXgy/ZnEmggOt6Q157Z3n/64m3wMMRYbv/ueBGDvpYIT3n xLk3GAcKOy7KZW9+nmyowUB+S5WkR8GjYfQPVJ0lxnL3cvP6id63p6J+A1wMf1RT mGjHogyzvqWofsHCEBRFA/DILsj4+oPgq6n86Go6PwSRZb8wtLRPCNrtcskk+DCt +geG4SwIiDaDTSrpTpXx7kMYBAm6heFHUGdPKqXz6vCfqh0nREATiKmWWxWxjcBA LCBKu1mUe8pKpj0pYiLjM1gT/L9NFH1LiD9APF5uEySJlKctCw4= =jfl3 -----END PGP SIGNATURE----- --D2l9TWy6HXXkBHlh--