From: Moritz Fischer <mdf@kernel.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Moritz Fischer <mdf@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: Signed-off-by missing for commit in the fpga tree
Date: Sun, 15 Nov 2020 16:24:45 -0800 [thread overview]
Message-ID: <X7HGzW8kvimYCUO9@epycbox.lan> (raw)
In-Reply-To: <20201116095240.52d70d6e@canb.auug.org.au>
On Mon, Nov 16, 2020 at 09:52:40AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> Commits
>
> aaf8fe39c952 ("Revert "fpga: dfl: fix the definitions of type & feature_id for dfl devices"")
> 9922e71f43ac ("Revert "fpga: dfl: move dfl_device_id to mod_devicetable.h"")
> 3ae706b58b0b ("Revert "fpga: dfl: add dfl bus support to MODULE_DEVICE_TABLE()"")
> dd57ca7ddec5 ("Revert "fpga: dfl: move dfl bus related APIs to include/linux/dfl.h"")
>
> are missing a Signed-off-by from their author and committer.
>
> Reverts are commits, too. It is also very useful for the commit message
> of a revert to contain some reason(s) for the revert as this may help
> future developers.
>
> --
> Cheers,
> Stephen Rothwell
Sorry, thanks for catching that, for posterity the reason was
that Greg had some further comments and didn't take the pull-request
as-is, so I wanted to have the next-tree reflect that.
I'll be more careful next time,
- Moritz
next prev parent reply other threads:[~2020-11-16 0:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-15 22:52 linux-next: Signed-off-by missing for commit in the fpga tree Stephen Rothwell
2020-11-16 0:24 ` Moritz Fischer [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-05-10 4:56 Stephen Rothwell
2022-05-10 6:41 ` Moritz Fischer
2023-07-16 22:02 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X7HGzW8kvimYCUO9@epycbox.lan \
--to=mdf@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.