From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F29CDC2D0A3 for ; Mon, 16 Nov 2020 18:33:59 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B90F2080A for ; Mon, 16 Nov 2020 18:33:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="A11HhK2h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B90F2080A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4CZd512pNVzDqPf for ; Tue, 17 Nov 2020 05:33:57 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linuxfoundation.org (client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=gregkh@linuxfoundation.org; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=default header.b=A11HhK2h; dkim-atps=neutral Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4CZd2B09c4zDqLj for ; Tue, 17 Nov 2020 05:31:29 +1100 (AEDT) Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5AA252231B; Mon, 16 Nov 2020 18:31:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605551486; bh=DSyphZecZaJDLhl3SAn5wJ+988r1JkD9wiG/+WmgEVQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=A11HhK2hy9ihhEf9vdXQO6XPoFVOKk2oaXr1Z/u+bSRYwPToivMO2QxL73e1Jokcr VmweE9rz9yfJX/sUrlUgdiYfZNFES71fmk1HpXQZVOOn2MaZPgtdfcy664RhHwusav 6hR5v2SMOc7g4sg7h7uyPlAa2HBv73qiv1G7y4Y8= Date: Mon, 16 Nov 2020 19:32:16 +0100 From: Greg KH To: Gao Xiang Subject: Re: [PATCH 4.19.y] erofs: derive atime instead of leaving it empty Message-ID: References: <160554164363107@kroah.com> <20201116164737.4184-1-hsiangkao@aol.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201116164737.4184-1-hsiangkao@aol.com> X-BeenThere: linux-erofs@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development of Linux EROFS file system List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nl6720 , linux-erofs@lists.ozlabs.org, stable@vger.kernel.org Errors-To: linux-erofs-bounces+linux-erofs=archiver.kernel.org@lists.ozlabs.org Sender: "Linux-erofs" On Tue, Nov 17, 2020 at 12:47:37AM +0800, Gao Xiang wrote: > From: Gao Xiang > > commit d3938ee23e97bfcac2e0eb6b356875da73d700df upstream. > > EROFS has _only one_ ondisk timestamp (ctime is currently > documented and recorded, we might also record mtime instead > with a new compat feature if needed) for each extended inode > since EROFS isn't mainly for archival purposes so no need to > keep all timestamps on disk especially for Android scenarios > due to security concerns. Also, romfs/cramfs don't have their > own on-disk timestamp, and squashfs only records mtime instead. > > Let's also derive access time from ondisk timestamp rather than > leaving it empty, and if mtime/atime for each file are really > needed for specific scenarios as well, we can also use xattrs > to record them then. > > Link: https://lore.kernel.org/r/20201031195102.21221-1-hsiangkao@aol.com > [ Gao Xiang: It'd be better to backport for user-friendly concern. ] > Fixes: 431339ba9042 ("staging: erofs: add inode operations") > Cc: stable # 4.19+ > Reported-by: nl6720 > Reviewed-by: Chao Yu > [ Gao Xiang: Manually backport to 4.19.y due to trivial conflicts. ] > Signed-off-by: Gao Xiang > --- > drivers/staging/erofs/inode.c | 21 +++++++++++---------- > 1 file changed, 11 insertions(+), 10 deletions(-) Now queued up, thanks for the backport! greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3650C64E69 for ; Mon, 16 Nov 2020 18:32:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F86F20780 for ; Mon, 16 Nov 2020 18:32:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="A11HhK2h" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732435AbgKPSbk (ORCPT ); Mon, 16 Nov 2020 13:31:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:41826 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388671AbgKPSb1 (ORCPT ); Mon, 16 Nov 2020 13:31:27 -0500 Received: from localhost (83-86-74-64.cable.dynamic.v4.ziggo.nl [83.86.74.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5AA252231B; Mon, 16 Nov 2020 18:31:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605551486; bh=DSyphZecZaJDLhl3SAn5wJ+988r1JkD9wiG/+WmgEVQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=A11HhK2hy9ihhEf9vdXQO6XPoFVOKk2oaXr1Z/u+bSRYwPToivMO2QxL73e1Jokcr VmweE9rz9yfJX/sUrlUgdiYfZNFES71fmk1HpXQZVOOn2MaZPgtdfcy664RhHwusav 6hR5v2SMOc7g4sg7h7uyPlAa2HBv73qiv1G7y4Y8= Date: Mon, 16 Nov 2020 19:32:16 +0100 From: Greg KH To: Gao Xiang Cc: stable@vger.kernel.org, linux-erofs@lists.ozlabs.org, Gao Xiang , nl6720 , Chao Yu Subject: Re: [PATCH 4.19.y] erofs: derive atime instead of leaving it empty Message-ID: References: <160554164363107@kroah.com> <20201116164737.4184-1-hsiangkao@aol.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201116164737.4184-1-hsiangkao@aol.com> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Tue, Nov 17, 2020 at 12:47:37AM +0800, Gao Xiang wrote: > From: Gao Xiang > > commit d3938ee23e97bfcac2e0eb6b356875da73d700df upstream. > > EROFS has _only one_ ondisk timestamp (ctime is currently > documented and recorded, we might also record mtime instead > with a new compat feature if needed) for each extended inode > since EROFS isn't mainly for archival purposes so no need to > keep all timestamps on disk especially for Android scenarios > due to security concerns. Also, romfs/cramfs don't have their > own on-disk timestamp, and squashfs only records mtime instead. > > Let's also derive access time from ondisk timestamp rather than > leaving it empty, and if mtime/atime for each file are really > needed for specific scenarios as well, we can also use xattrs > to record them then. > > Link: https://lore.kernel.org/r/20201031195102.21221-1-hsiangkao@aol.com > [ Gao Xiang: It'd be better to backport for user-friendly concern. ] > Fixes: 431339ba9042 ("staging: erofs: add inode operations") > Cc: stable # 4.19+ > Reported-by: nl6720 > Reviewed-by: Chao Yu > [ Gao Xiang: Manually backport to 4.19.y due to trivial conflicts. ] > Signed-off-by: Gao Xiang > --- > drivers/staging/erofs/inode.c | 21 +++++++++++---------- > 1 file changed, 11 insertions(+), 10 deletions(-) Now queued up, thanks for the backport! greg k-h