From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E21DC63777 for ; Mon, 30 Nov 2020 15:31:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0535B2076B for ; Mon, 30 Nov 2020 15:31:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725955AbgK3PbT (ORCPT ); Mon, 30 Nov 2020 10:31:19 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:34887 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725870AbgK3PbS (ORCPT ); Mon, 30 Nov 2020 10:31:18 -0500 Received: by mail-wr1-f68.google.com with SMTP id r3so16766684wrt.2 for ; Mon, 30 Nov 2020 07:30:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=aYHHxJmw979e+wSJRiDQN73bZ6bHCfBL6+c7qQzjNRM=; b=XMW1RX90Xa4IkFRzU9z83ff0EKnOA+7Ib/E8gsCQtHc74JLFBh0mlCXLrUGxKeKgTQ shMpJ4eOtXVDzlTi7RIBQnGxVX8q1Hg548x8xPjSxIQ+Dp7fuachS+cORT4oAZv9lpxB oEeNX8Cz42lX9V5x8SJctdAn2XsbSPLCJ5brdx5+xYahtWnPy8EHAmkJHClrE90yDO2h nFyjzFBCnd4Qq6GhzP3Ke7/nRBZnRswddxYet6hbGE8iMtcTkRRMKD/El5Ei+RBI7Pzm XFjKurMK6esbpD8Ab2HIUyXhYiLh0bwIEGDVJWXldCVf5KjJRZeM8+l+RIZbRqtIv2JD Ubjg== X-Gm-Message-State: AOAM531JgRESXDQJm5YGYJDMn7Nx4wj22/iLAe1D/oFphJVl8roYS0hc cVqwzfdm+Zy/vWkl0u0ONmo= X-Google-Smtp-Source: ABdhPJxDgu0JUhfBnd1JT0sM9EnLMunvMJmxP1ptyZLeuiHRBoyRMeT9fOud0TpT6HDh8Aw84e0fEg== X-Received: by 2002:adf:9d49:: with SMTP id o9mr29398963wre.413.1606750230899; Mon, 30 Nov 2020 07:30:30 -0800 (PST) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id k11sm27836582wrv.88.2020.11.30.07.30.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Nov 2020 07:30:30 -0800 (PST) Date: Mon, 30 Nov 2020 16:30:28 +0100 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Lorenzo Pieralisi Cc: Bjorn Helgaas , Rob Herring , Jonathan Cameron , Jonathan Chocron , Shawn Lin , Heiko Stuebner , Zhou Wang , Will Deacon , Robert Richter , Michal Simek , Toan Le , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Thomas Petazzoni , Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , Jonathan Derrick , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-rockchip@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com Subject: Re: [PATCH v6 1/5] PCI: Unify ECAM constants in native PCI Express drivers Message-ID: References: <20201129230743.3006978-1-kw@linux.com> <20201129230743.3006978-2-kw@linux.com> <20201130110858.GB16758@e121166-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201130110858.GB16758@e121166-lin.cambridge.arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi Lorenzo! On 20-11-30 11:08:58, Lorenzo Pieralisi wrote: [...] > > Refactor pci_ecam_map_bus() function to use newly added constants so > > that limits to the bus, device function and offset (now limited to 4K as > > per the specification) are in place to prevent the defective or > > malicious caller from supplying incorrect configuration offset and thus > > targeting the wrong device when accessing extended configuration space. > > This refactor also allows for the ".bus_shit" initialisers to be dropped > ^^^^ > > Nice typo, I'd fix it while applying it though if you don't mind ;-), > no need to resend it. Oh doh! Apologies. :) > Jokes aside, nice piece of work, thanks for that. > > > when the user is not using a custom value as a default value will be > > used as per the PCI Express Specification. > > > > Suggested-by: Bjorn Helgaas > > Signed-off-by: Krzysztof Wilczyński > > I think Bjorn's reviewed-by still stands so I will apply it. [...] Thank you! Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 548ADC63777 for ; Mon, 30 Nov 2020 15:30:45 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C20B62076B for ; Mon, 30 Nov 2020 15:30:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FzQoZovN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C20B62076B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=rnyuqXAzYkjmEnWYP+nEobmMmpZuiCvtiRdQTg5Izjo=; b=FzQoZovNysagFECDxOEdSyIct wydu04oz4D1EdEJgIVJdUKvvPxeSnKNucTEApc1foma2MrdfcUtnxPUm0njGIM85KMWfRO37n2xRq aRbf0y2jwvb8nelz9OJMbVQeQm+LAi3ojGl3h5xiJ62wyl3C7HHbDa/3N7nb0sQV9qnZtYxLdQnhE Zw5rQMNS57HHGFBYg/0vuVmu4kut+fLetcn4DDnTvxleYwRawtxynx0w0GIfQrKwmrMB71g621ORo J8bH4HEjvfjWGS39bkcqpJX4F7xtWHniLR7E10T0u7Cjipid/7BxCPZyUa4Wl7OAdGFRBKvVqY6sd RYTQciTVQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjl8R-0007mP-NH; Mon, 30 Nov 2020 15:30:39 +0000 Received: from mail-wr1-f65.google.com ([209.85.221.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjl8K-0007kf-JB; Mon, 30 Nov 2020 15:30:33 +0000 Received: by mail-wr1-f65.google.com with SMTP id o1so2795020wrx.7; Mon, 30 Nov 2020 07:30:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=aYHHxJmw979e+wSJRiDQN73bZ6bHCfBL6+c7qQzjNRM=; b=hv3f8YNzimp8sgaoP7yYobsRVGV4S57nefM6+X46dWL/lp3dKY2Nh9eFRuqyAjR/U/ QCCfpvJUlUnoq+QfxBsbCZiX2ShCBqnmOYU2+5jcjfUn83JUxk33dnVxRX5CiXo0r4Fz rG6g5R0bLrkAcKPr9BJZcgEyFKYtrJRev0jolpf2iZL/C+vOURppqwXfaei1xhrXGymA IbXJOvmiferqqC+tW0OFfIGN0A+/9ovDiOq4rJcAsKrTaxwaa39TzlnsmQmgQR7iOUah LBF8aGyuewIYjBsvflVJLD/nhSyuH7PsgY77J7RYz230fKQdRMnr73JGuLoGSC9T3Wh9 d8Cg== X-Gm-Message-State: AOAM533x7hgm7c2K/LQb0JcpWrSO+sn/lw4rImhTmMWsSZzYIUM6PZ4F Vjek6ck9mNsV6NtzqN6phXE= X-Google-Smtp-Source: ABdhPJxDgu0JUhfBnd1JT0sM9EnLMunvMJmxP1ptyZLeuiHRBoyRMeT9fOud0TpT6HDh8Aw84e0fEg== X-Received: by 2002:adf:9d49:: with SMTP id o9mr29398963wre.413.1606750230899; Mon, 30 Nov 2020 07:30:30 -0800 (PST) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id k11sm27836582wrv.88.2020.11.30.07.30.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Nov 2020 07:30:30 -0800 (PST) Date: Mon, 30 Nov 2020 16:30:28 +0100 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Lorenzo Pieralisi Subject: Re: [PATCH v6 1/5] PCI: Unify ECAM constants in native PCI Express drivers Message-ID: References: <20201129230743.3006978-1-kw@linux.com> <20201129230743.3006978-2-kw@linux.com> <20201130110858.GB16758@e121166-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201130110858.GB16758@e121166-lin.cambridge.arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201130_103032_677623_A64739C9 X-CRM114-Status: GOOD ( 16.15 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , Benjamin Herrenschmidt , Shawn Lin , Paul Mackerras , Thomas Petazzoni , Jonathan Chocron , Toan Le , Will Deacon , Rob Herring , Florian Fainelli , Michael Ellerman , Michal Simek , linux-rockchip@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, Jonathan Derrick , linux-pci@vger.kernel.org, Ray Jui , linux-rpi-kernel@lists.infradead.org, Jonathan Cameron , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org, Scott Branden , Zhou Wang , Robert Richter , linuxppc-dev@lists.ozlabs.org, Nicolas Saenz Julienne Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org SGkgTG9yZW56byEKCk9uIDIwLTExLTMwIDExOjA4OjU4LCBMb3JlbnpvIFBpZXJhbGlzaSB3cm90 ZToKWy4uLl0KPiA+IFJlZmFjdG9yIHBjaV9lY2FtX21hcF9idXMoKSBmdW5jdGlvbiB0byB1c2Ug bmV3bHkgYWRkZWQgY29uc3RhbnRzIHNvCj4gPiB0aGF0IGxpbWl0cyB0byB0aGUgYnVzLCBkZXZp Y2UgZnVuY3Rpb24gYW5kIG9mZnNldCAobm93IGxpbWl0ZWQgdG8gNEsgYXMKPiA+IHBlciB0aGUg c3BlY2lmaWNhdGlvbikgYXJlIGluIHBsYWNlIHRvIHByZXZlbnQgdGhlIGRlZmVjdGl2ZSBvcgo+ ID4gbWFsaWNpb3VzIGNhbGxlciBmcm9tIHN1cHBseWluZyBpbmNvcnJlY3QgY29uZmlndXJhdGlv biBvZmZzZXQgYW5kIHRodXMKPiA+IHRhcmdldGluZyB0aGUgd3JvbmcgZGV2aWNlIHdoZW4gYWNj ZXNzaW5nIGV4dGVuZGVkIGNvbmZpZ3VyYXRpb24gc3BhY2UuCj4gPiBUaGlzIHJlZmFjdG9yIGFs c28gYWxsb3dzIGZvciB0aGUgIi5idXNfc2hpdCIgaW5pdGlhbGlzZXJzIHRvIGJlIGRyb3BwZWQK PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBeXl5eCj4gCj4gTmlj ZSB0eXBvLCBJJ2QgZml4IGl0IHdoaWxlIGFwcGx5aW5nIGl0IHRob3VnaCBpZiB5b3UgZG9uJ3Qg bWluZCA7LSksCj4gbm8gbmVlZCB0byByZXNlbmQgaXQuCgpPaCBkb2ghICBBcG9sb2dpZXMuIDop Cgo+IEpva2VzIGFzaWRlLCBuaWNlIHBpZWNlIG9mIHdvcmssIHRoYW5rcyBmb3IgdGhhdC4KPiAK PiA+IHdoZW4gdGhlIHVzZXIgaXMgbm90IHVzaW5nIGEgY3VzdG9tIHZhbHVlIGFzIGEgZGVmYXVs dCB2YWx1ZSB3aWxsIGJlCj4gPiB1c2VkIGFzIHBlciB0aGUgUENJIEV4cHJlc3MgU3BlY2lmaWNh dGlvbi4KPiA+IAo+ID4gU3VnZ2VzdGVkLWJ5OiBCam9ybiBIZWxnYWFzIDxiaGVsZ2Fhc0Bnb29n bGUuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogS3J6eXN6dG9mIFdpbGN6ecWEc2tpIDxrd0BsaW51 eC5jb20+Cj4gCj4gSSB0aGluayBCam9ybidzIHJldmlld2VkLWJ5IHN0aWxsIHN0YW5kcyBzbyBJ IHdpbGwgYXBwbHkgaXQuClsuLi5dCgpUaGFuayB5b3UhCgpLcnp5c3p0b2YKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxp bmcgbGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 758DDC63777 for ; Mon, 30 Nov 2020 15:34:21 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C43782076C for ; Mon, 30 Nov 2020 15:34:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C43782076C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4Cl8RG3zmrzDqCx for ; Tue, 1 Dec 2020 02:34:18 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.221.67; helo=mail-wr1-f67.google.com; envelope-from=kswilczynski@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.com Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Cl8M02nW7zDqXd for ; Tue, 1 Dec 2020 02:30:36 +1100 (AEDT) Received: by mail-wr1-f67.google.com with SMTP id 23so16756479wrc.8 for ; Mon, 30 Nov 2020 07:30:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=aYHHxJmw979e+wSJRiDQN73bZ6bHCfBL6+c7qQzjNRM=; b=bY938Ga6/Mgn4AaAd30NVlpPwi9AOG6sYArDVGcq+LNtq/JWCor54AUDyHvRUg72HL ofQISnJunUykrk3yKYsh7qP4PHYVNWYID4tQCo5zhs0ZPF4jWgg5eTOEytz2GBfCZauA S4yianTiXzKiHuG9nWXx8BND+EVpc+cWxMm/i8VKlshdN8Aetg8vILDzNw+UGVeiVe0O SFuk/BwwQQVKSbza5PikMfeVmb9gKg7mGnK4Yxvq5XFCOD6dt9fz9aThw0EQIUP0G07d wgubJjP7EDcNXqntpZb26wdqUJnvZ5VKbz6gwcZuYD6u1M+m+2R2LvjE3h/1nRrl3Gl6 cn+w== X-Gm-Message-State: AOAM5314hAMkn1ijc+vECgSPrMaJGxITRjOxT1J6WdOrrlOSelm0KK9c QKaqxIkC57VUp+Ob5Dcsik0= X-Google-Smtp-Source: ABdhPJxDgu0JUhfBnd1JT0sM9EnLMunvMJmxP1ptyZLeuiHRBoyRMeT9fOud0TpT6HDh8Aw84e0fEg== X-Received: by 2002:adf:9d49:: with SMTP id o9mr29398963wre.413.1606750230899; Mon, 30 Nov 2020 07:30:30 -0800 (PST) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id k11sm27836582wrv.88.2020.11.30.07.30.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Nov 2020 07:30:30 -0800 (PST) Date: Mon, 30 Nov 2020 16:30:28 +0100 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Lorenzo Pieralisi Subject: Re: [PATCH v6 1/5] PCI: Unify ECAM constants in native PCI Express drivers Message-ID: References: <20201129230743.3006978-1-kw@linux.com> <20201129230743.3006978-2-kw@linux.com> <20201130110858.GB16758@e121166-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201130110858.GB16758@e121166-lin.cambridge.arm.com> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , Shawn Lin , Paul Mackerras , Thomas Petazzoni , Jonathan Chocron , Toan Le , Will Deacon , Rob Herring , Florian Fainelli , Michal Simek , linux-rockchip@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, Jonathan Derrick , linux-pci@vger.kernel.org, Ray Jui , linux-rpi-kernel@lists.infradead.org, Jonathan Cameron , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org, Scott Branden , Zhou Wang , Robert Richter , linuxppc-dev@lists.ozlabs.org, Nicolas Saenz Julienne Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Lorenzo! On 20-11-30 11:08:58, Lorenzo Pieralisi wrote: [...] > > Refactor pci_ecam_map_bus() function to use newly added constants so > > that limits to the bus, device function and offset (now limited to 4K as > > per the specification) are in place to prevent the defective or > > malicious caller from supplying incorrect configuration offset and thus > > targeting the wrong device when accessing extended configuration space. > > This refactor also allows for the ".bus_shit" initialisers to be dropped > ^^^^ > > Nice typo, I'd fix it while applying it though if you don't mind ;-), > no need to resend it. Oh doh! Apologies. :) > Jokes aside, nice piece of work, thanks for that. > > > when the user is not using a custom value as a default value will be > > used as per the PCI Express Specification. > > > > Suggested-by: Bjorn Helgaas > > Signed-off-by: Krzysztof Wilczyński > > I think Bjorn's reviewed-by still stands so I will apply it. [...] Thank you! Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91A26C63777 for ; Mon, 30 Nov 2020 15:31:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 09D892076C for ; Mon, 30 Nov 2020 15:31:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bsXgNOvs" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 09D892076C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=E6abMf/GnCpPjiWSv3ujTfwWNVBwACJMGxMXuNsq+10=; b=bsXgNOvsGwOMn5/wc3NL46zRt YH2ZICIc91CM/pnUVBXlS0Hj+aaUo4+XiR+cjvAib7JYrvpcQ1ZVqFCq2vK5O3QRUsbpgG9eaMNLC g8V5usOMN0Jy8O42sSlQlx5lDkYPLvsnO06+fpcxVehohh18p7LdQnzI9qZ3BYOqe8DaYAsDQx1Sa r9IeNQYI6edh2yA+Aed0g4KdDJKEKwChLaPx6NjN0CuK/n3Z1SmGbeiqEo2uRWKXk7F/r7AZZ2Q72 FRX2IaGCpGt38+ovF9zza5oAhdeeyiXrTt4bdHeXw7TRWmFahdr17LMr/ctMem4eZe5Xd+s9jPoh0 v9r3Kcjsw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjl8O-0007lV-D9; Mon, 30 Nov 2020 15:30:36 +0000 Received: from mail-wr1-f65.google.com ([209.85.221.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjl8K-0007kf-JB; Mon, 30 Nov 2020 15:30:33 +0000 Received: by mail-wr1-f65.google.com with SMTP id o1so2795020wrx.7; Mon, 30 Nov 2020 07:30:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=aYHHxJmw979e+wSJRiDQN73bZ6bHCfBL6+c7qQzjNRM=; b=hv3f8YNzimp8sgaoP7yYobsRVGV4S57nefM6+X46dWL/lp3dKY2Nh9eFRuqyAjR/U/ QCCfpvJUlUnoq+QfxBsbCZiX2ShCBqnmOYU2+5jcjfUn83JUxk33dnVxRX5CiXo0r4Fz rG6g5R0bLrkAcKPr9BJZcgEyFKYtrJRev0jolpf2iZL/C+vOURppqwXfaei1xhrXGymA IbXJOvmiferqqC+tW0OFfIGN0A+/9ovDiOq4rJcAsKrTaxwaa39TzlnsmQmgQR7iOUah LBF8aGyuewIYjBsvflVJLD/nhSyuH7PsgY77J7RYz230fKQdRMnr73JGuLoGSC9T3Wh9 d8Cg== X-Gm-Message-State: AOAM533x7hgm7c2K/LQb0JcpWrSO+sn/lw4rImhTmMWsSZzYIUM6PZ4F Vjek6ck9mNsV6NtzqN6phXE= X-Google-Smtp-Source: ABdhPJxDgu0JUhfBnd1JT0sM9EnLMunvMJmxP1ptyZLeuiHRBoyRMeT9fOud0TpT6HDh8Aw84e0fEg== X-Received: by 2002:adf:9d49:: with SMTP id o9mr29398963wre.413.1606750230899; Mon, 30 Nov 2020 07:30:30 -0800 (PST) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id k11sm27836582wrv.88.2020.11.30.07.30.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Nov 2020 07:30:30 -0800 (PST) Date: Mon, 30 Nov 2020 16:30:28 +0100 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Lorenzo Pieralisi Subject: Re: [PATCH v6 1/5] PCI: Unify ECAM constants in native PCI Express drivers Message-ID: References: <20201129230743.3006978-1-kw@linux.com> <20201129230743.3006978-2-kw@linux.com> <20201130110858.GB16758@e121166-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201130110858.GB16758@e121166-lin.cambridge.arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201130_103032_677623_A64739C9 X-CRM114-Status: GOOD ( 16.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , Benjamin Herrenschmidt , Shawn Lin , Paul Mackerras , Thomas Petazzoni , Jonathan Chocron , Toan Le , Will Deacon , Rob Herring , Florian Fainelli , Michael Ellerman , Michal Simek , linux-rockchip@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, Jonathan Derrick , linux-pci@vger.kernel.org, Ray Jui , linux-rpi-kernel@lists.infradead.org, Jonathan Cameron , Bjorn Helgaas , linux-arm-kernel@lists.infradead.org, Scott Branden , Zhou Wang , Robert Richter , linuxppc-dev@lists.ozlabs.org, Nicolas Saenz Julienne Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgTG9yZW56byEKCk9uIDIwLTExLTMwIDExOjA4OjU4LCBMb3JlbnpvIFBpZXJhbGlzaSB3cm90 ZToKWy4uLl0KPiA+IFJlZmFjdG9yIHBjaV9lY2FtX21hcF9idXMoKSBmdW5jdGlvbiB0byB1c2Ug bmV3bHkgYWRkZWQgY29uc3RhbnRzIHNvCj4gPiB0aGF0IGxpbWl0cyB0byB0aGUgYnVzLCBkZXZp Y2UgZnVuY3Rpb24gYW5kIG9mZnNldCAobm93IGxpbWl0ZWQgdG8gNEsgYXMKPiA+IHBlciB0aGUg c3BlY2lmaWNhdGlvbikgYXJlIGluIHBsYWNlIHRvIHByZXZlbnQgdGhlIGRlZmVjdGl2ZSBvcgo+ ID4gbWFsaWNpb3VzIGNhbGxlciBmcm9tIHN1cHBseWluZyBpbmNvcnJlY3QgY29uZmlndXJhdGlv biBvZmZzZXQgYW5kIHRodXMKPiA+IHRhcmdldGluZyB0aGUgd3JvbmcgZGV2aWNlIHdoZW4gYWNj ZXNzaW5nIGV4dGVuZGVkIGNvbmZpZ3VyYXRpb24gc3BhY2UuCj4gPiBUaGlzIHJlZmFjdG9yIGFs c28gYWxsb3dzIGZvciB0aGUgIi5idXNfc2hpdCIgaW5pdGlhbGlzZXJzIHRvIGJlIGRyb3BwZWQK PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBeXl5eCj4gCj4gTmlj ZSB0eXBvLCBJJ2QgZml4IGl0IHdoaWxlIGFwcGx5aW5nIGl0IHRob3VnaCBpZiB5b3UgZG9uJ3Qg bWluZCA7LSksCj4gbm8gbmVlZCB0byByZXNlbmQgaXQuCgpPaCBkb2ghICBBcG9sb2dpZXMuIDop Cgo+IEpva2VzIGFzaWRlLCBuaWNlIHBpZWNlIG9mIHdvcmssIHRoYW5rcyBmb3IgdGhhdC4KPiAK PiA+IHdoZW4gdGhlIHVzZXIgaXMgbm90IHVzaW5nIGEgY3VzdG9tIHZhbHVlIGFzIGEgZGVmYXVs dCB2YWx1ZSB3aWxsIGJlCj4gPiB1c2VkIGFzIHBlciB0aGUgUENJIEV4cHJlc3MgU3BlY2lmaWNh dGlvbi4KPiA+IAo+ID4gU3VnZ2VzdGVkLWJ5OiBCam9ybiBIZWxnYWFzIDxiaGVsZ2Fhc0Bnb29n bGUuY29tPgo+ID4gU2lnbmVkLW9mZi1ieTogS3J6eXN6dG9mIFdpbGN6ecWEc2tpIDxrd0BsaW51 eC5jb20+Cj4gCj4gSSB0aGluayBCam9ybidzIHJldmlld2VkLWJ5IHN0aWxsIHN0YW5kcyBzbyBJ IHdpbGwgYXBwbHkgaXQuClsuLi5dCgpUaGFuayB5b3UhCgpLcnp5c3p0b2YKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFp bGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlz dHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK