From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1klu2Q-0004cw-GE for mharc-grub-devel@gnu.org; Sun, 06 Dec 2020 08:25:19 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49730) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klu2M-0004cC-Ey for grub-devel@gnu.org; Sun, 06 Dec 2020 08:25:16 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:57459) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1klu2J-0001ny-05 for grub-devel@gnu.org; Sun, 06 Dec 2020 08:25:13 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 955389DE; Sun, 6 Dec 2020 08:25:09 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sun, 06 Dec 2020 08:25:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=61DzkZ0tlfnEdNgNFL/5cWApH9M KSHz9F/F3A5gnHxw=; b=UUo5QN2KReveZg2dVX/9umgjz0+SS/WBKRU6CK6kAA2 OVam/IJcAywa++l0DKYd90++xet2IiAhVGHyPtWVL+C7h2PIe6rnmVBpCvCP0pMA qcjD9pyMtGHIPpAIYGRaDr1tkXrBOfg5nHmqqcaZp54EOORvDblLZRZ26XBIr7Zo FHAC/kNAQdquwqxcsnSc9uHh0GvS4nx66xUcbEQ1GK8vrZZPA4xRKGWGKq4maRSD 8s0T/8xhi/RpEFqPiK5odLRYcWNDPclZoQ+VEy5svxPselPpGlI4Nen/iHPZAbFO O/103M69O1b5BPfatoz46ONvCpgw01XprYrHrTKDS6g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=61DzkZ 0tlfnEdNgNFL/5cWApH9MKSHz9F/F3A5gnHxw=; b=IOKEMLcusUFIbPvj7iqHiP PbjSaE1nAdhRwO8FFiU23VP/IdcU8xTZepmyXPf1YmBgwGCmHX715oXHs1m8Fcfx m1g3w2hxzxh8JzBICK8Ah2fun0uzjw3BmOUSAVj8SOmpTIKfDURoihjZYMg5J16M ycHskj9wreZn5i4xUBWy5Q3w5A9MhVWc1Fwd2CKxglVXJW82ya0dOimsVscEe4Tw neb9RxWlof+5Av5MHYLN0bNIPtXrRE4r4FO9gyWzVOcAZPA8INaMI9pUJeju+PAC G4dkZvgFea+Pt1FrSj/Gd2Z6m1c97sggVy//hbbrVP3bQBkEcwTB28boatPizbOA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudejvddghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefrrghtrhhi tghkucfuthgvihhnhhgrrhguthcuoehpshesphhkshdrihhmqeenucggtffrrghtthgvrh hnpeehgefhtdefueffheekgfffudelffejtdfhvdejkedthfehvdelgfetgfdvtedthfen ucfkphepjeejrddukeefrddujedruddutdenucevlhhushhtvghrufhiiigvpedvnecurf grrhgrmhepmhgrihhlfhhrohhmpehpshesphhkshdrihhm X-ME-Proxy: Received: from vm-mail (x4db7116e.dyn.telefonica.de [77.183.17.110]) by mail.messagingengine.com (Postfix) with ESMTPA id 815C5108005B; Sun, 6 Dec 2020 08:25:08 -0500 (EST) Received: from localhost (ncase [10.192.0.11]) by vm-mail (OpenSMTPD) with ESMTPSA id 1da02e57 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 6 Dec 2020 13:25:06 +0000 (UTC) Date: Sun, 6 Dec 2020 14:25:06 +0100 From: Patrick Steinhardt To: Glenn Washburn Cc: grub-devel@gnu.org, Daniel Kiper , Daniel Kiper Subject: Re: [PATCH v7 03/17] luks2: Remove unused argument in grub_error Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/fSlE9vYk76jLZTO" Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=64.147.123.24; envelope-from=ps@pks.im; helo=wout1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Dec 2020 13:25:16 -0000 --/fSlE9vYk76jLZTO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 04, 2020 at 10:43:32AM -0600, Glenn Washburn wrote: > Reviewed-by: Daniel Kiper > Signed-off-by: Glenn Washburn Reviewed-by: Patrick Steinhardt > --- > grub-core/disk/luks2.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/grub-core/disk/luks2.c b/grub-core/disk/luks2.c > index d96764a02..bdb90e4b6 100644 > --- a/grub-core/disk/luks2.c > +++ b/grub-core/disk/luks2.c > @@ -200,7 +200,7 @@ luks2_parse_segment (grub_luks2_segment_t *out, const= grub_json_t *segment) > grub_json_getstring (&out->size, segment, "size") || > grub_json_getstring (&out->encryption, segment, "encryption") || > grub_json_getint64 (&out->sector_size, segment, "sector_size")) > - return grub_error (GRUB_ERR_BAD_ARGUMENT, "Missing segment parameter= s", type); > + return grub_error (GRUB_ERR_BAD_ARGUMENT, "Missing segment parameter= s"); > =20 > return GRUB_ERR_NONE; > } > @@ -228,7 +228,7 @@ luks2_parse_digest (grub_luks2_digest_t *out, const g= rub_json_t *digest) > =20 > if (grub_json_getsize (&size, &segments)) > return grub_error (GRUB_ERR_BAD_ARGUMENT, > - "Digest references no segments", type); > + "Digest references no segments"); > =20 > for (i =3D 0; i < size; i++) > { > @@ -240,7 +240,7 @@ luks2_parse_digest (grub_luks2_digest_t *out, const g= rub_json_t *digest) > =20 > if (grub_json_getsize (&size, &keyslots)) > return grub_error (GRUB_ERR_BAD_ARGUMENT, > - "Digest references no keyslots", type); > + "Digest references no keyslots"); > =20 > for (i =3D 0; i < size; i++) > { > --=20 > 2.27.0 >=20 --/fSlE9vYk76jLZTO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF9hrgiFbCdvenl/rVbJhu7ckPpQFAl/M27EACgkQVbJhu7ck PpRxgRAAqSLhqX7JJ7Kp1U9R+M9Tyhwaqh2U6rARsyuy1uGDEzOEl3iCjx8eQ78w RFpVL8+5U2zt9wy31g05hjQjP6SQPql/Rh1L3PKDTDAvNXkmuHUZQDYafn04DldW VjoU9/NWfDhQSVjAz1mEeEWanD1TpOZHxJVe17RA7k123BeXcaHUUYfZQdhkVfrl 1EYN1LgR476zS2xGib0aqvJXgucpG7TH9+YBRnyU57jFGmoVoTuezSaj9+J64Eqg uJeVkPiUFXPrCnYn65JbeCA8Cr63p9eUOiUp1lKxnalwy5QwIIeByFZjTiBVqVrR CplVbiIrzBTCiQ7OvDJje9lau9uSOq8w5WdGcrEE0XF839Fu6X8WV2QhFSc2x3e1 9FcsyThs3O90MaNyQVFq/k2W8h+z3hVkKAycpKL9bVnbtGHvDxipO2C1DK+jtnr4 mr0NrnSALzBKtyNureKgIsFrcXFqOZegSfqVAq+avu1YBlo7FlupnjKQIS2b75/I 5Ig85oac7bJgA32xqdFCRXsyijjeLAlifsQwPlmDxTTrGAtvO9CyzMMivqaBv3Y+ LEWLvGLYu2i1X43nCYeNzpXpDqBpqS/aFsdsz6SRFIlSug013x87Fa7kWABFoaxn jJFQnHSbdAdFhEJ7zmJVDSTV3eeNcQnGUhCcHcgDRmZSfW4npqI= =Mbf6 -----END PGP SIGNATURE----- --/fSlE9vYk76jLZTO--