From: Brian Norris <briannorris@chromium.org>
To: Evan Benn <evanbenn@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH 1/2] platform/chrome: cros_ec_proto: Use EC_HOST_EVENT_MASK not BIT
Date: Wed, 9 Dec 2020 14:37:09 -0800 [thread overview]
Message-ID: <X9FRlTDVXtj6uFQb@google.com> (raw)
In-Reply-To: <20201209220306.1.I6133572c0ab3c6b95426f804bac2d3833e24acb1@changeid>
On Wed, Dec 09, 2020 at 10:03:54PM +0000, Evan Benn wrote:
> The host_event_code enum is 1-based, use EC_HOST_EVENT_MASK not BIT to
> generate the intended mask. This patch changes the behaviour of the
> mask, a following patch will restore the intended behaviour:
> 'Add LID and BATTERY to default mask'
>
> Fixes: c214e564acb2ad9463293ab9c109bfdae91fbeaf
Normally the short hash + commit title are used here, so:
Fixes: c214e564acb2 ("platform/chrome: cros_ec_proto: ignore unnecessary wakeups on old ECs")
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-changes
With luck, maintainers can fix that up when applying, so you don't need
to resend.
Otherwise, both patches look good to me, thanks!
Reviewed-by: Brian Norris <briannorris@chromium.org>
next prev parent reply other threads:[~2020-12-09 22:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 22:03 [PATCH 1/2] platform/chrome: cros_ec_proto: Use EC_HOST_EVENT_MASK not BIT Evan Benn
2020-12-09 22:03 ` [PATCH 2/2] platform/chrome: cros_ec_proto: Add LID and BATTERY to default mask Evan Benn
2020-12-09 22:37 ` Brian Norris [this message]
2021-01-20 15:14 ` [PATCH 1/2] platform/chrome: cros_ec_proto: Use EC_HOST_EVENT_MASK not BIT Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X9FRlTDVXtj6uFQb@google.com \
--to=briannorris@chromium.org \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=evanbenn@chromium.org \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.