All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Alexandru Ardelean <alexandru.ardelean@analog.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, lars@metafoo.de, robh+dt@kernel.org
Subject: Re: [PATCH v3 1/4] Input: adp5589-keys - add default platform data
Date: Wed, 9 Dec 2020 23:20:21 -0800	[thread overview]
Message-ID: <X9HMNWziPToVHKnU@google.com> (raw)
In-Reply-To: <20201127111420.96500-1-alexandru.ardelean@analog.com>

Hi Alexandru, Lars-Peter,

On Fri, Nov 27, 2020 at 01:14:17PM +0200, Alexandru Ardelean wrote:
> From: Lars-Peter Clausen <lars@metafoo.de>
> 
> If no platform data is supplied use a dummy platform data that configures
> the device in GPIO only mode. This change adds a adp5589_kpad_pdata_get()
> helper that returns the default platform-data. This can be later extended
> to load configuration from device-trees or ACPI.

I was looking at this and I do not think it is a good idea, as later we
will need to add negation if someone does nor want use GPIO mode. We
should use the standard "gpio-controller" property from the beginning.

Thanks.

-- 
Dmitry

      parent reply	other threads:[~2020-12-10  7:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-27 11:14 [PATCH v3 1/4] Input: adp5589-keys - add default platform data Alexandru Ardelean
2020-11-27 11:14 ` [PATCH v3 2/4] Input: adp5589-keys - wrap device probing into chip info struct Alexandru Ardelean
2020-11-27 11:14 ` [PATCH v3 3/4] Input: adp5589-keys - add basic devicetree support Alexandru Ardelean
2020-11-27 11:14 ` [PATCH v3 4/4] dt-bindings: add ADP5585/ADP5589 entries to trivial-devices Alexandru Ardelean
2020-12-08 18:13   ` Rob Herring
2020-12-09  7:01 ` [PATCH v3 1/4] Input: adp5589-keys - add default platform data Ardelean, Alexandru
2020-12-10  7:20 ` Dmitry Torokhov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X9HMNWziPToVHKnU@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=alexandru.ardelean@analog.com \
    --cc=devicetree@vger.kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.