From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 417D2C4361B for ; Thu, 10 Dec 2020 16:23:36 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD83323158 for ; Thu, 10 Dec 2020 16:23:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD83323158 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1knOj8-0005F5-NT; Thu, 10 Dec 2020 16:23:34 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knOiv-0005Ee-IG for linux-f2fs-devel@lists.sourceforge.net; Thu, 10 Dec 2020 16:23:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cIpidYTKOwySGuqUJqM5+0uhel2eFuJsMmxQCgdYCYs=; b=cSc3Aa/6NRFMm0+TZABVU9LsHK ohALmmvP8pbN5PY2PpPxooi8f4r+sthuZc3zgbRDwXcjeCP8lUIJi5kv03mp6oGFDA+WPDyOzLQTm vPVVJCydjqF0yesQa+MHduFj4P0vpOBBjwo0G/+MS6A9POBlrEVz2umr45GuGyna+Vl0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=cIpidYTKOwySGuqUJqM5+0uhel2eFuJsMmxQCgdYCYs=; b=SBwiu2FsM36yLSjnrfU3xuNh6C TinwTOqPiH9TAgpraT6hFgTEQ3uVoU2EJZsNzboZ7SlFZIWDlc9XS7s05LMFp3T3U7jh58h1uh/pT vqlObj9RiSePvsSVcdlT/evUVVlGEw1BDda7xssnNg/PXzB9A1IGCoWcyBH2/Wu3Mfm8=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1knOir-006h8D-7d for linux-f2fs-devel@lists.sourceforge.net; Thu, 10 Dec 2020 16:23:21 +0000 Date: Thu, 10 Dec 2020 08:22:56 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607617378; bh=IT1JhMouVay4d31+Gw+I77QyHRv1BMMQHowugQ1EGS8=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=Uo0NiqgPB/g8PXQKQB1ZRC1Telxr2qFG92011hQ3lHonyXSLgYaxJq158mhIWfKFZ HicY16RuNTpihqbB3lhvS5B0lT793phbiG+v82xkBK1sIb8kLIzpluOrHO22KhaZP1 DMdphQ8Mw7oe9cn5SrVx0/YisG6MS7RKeVcA6cxHhknAWBvUgwYMcMYhr7oDZM0SgA Y0ktr1nILe/+Q2OEkkH/dGG14TWxGtPvQiVAUXuoW90aD4J+x1xMWpI/d8feiMhHrd Z2waf0JVIn1DUdrZv/Gp1EWiXCpAIigqyCyqM9EaGykgMQWUtnbwaZSFW6wO1QSxmw hOG5IHCWpQ4Wg== From: Jaegeuk Kim To: =?utf-8?B?5b6Q55Ge5paM?= Message-ID: References: <20201208081555.652932-1-robinh3123@gmail.com> <20201208081555.652932-3-robinh3123@gmail.com> <785e9f0a-c3d6-9cc5-f17a-a3cc58a43a0f@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1knOir-006h8D-7d Subject: Re: [f2fs-dev] [PATCH v3 2/3] f2fs-tools:sload.f2fs compression support X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gMTIvMTAsIOW+kOeRnuaWjCB3cm90ZToKPiBIaSwgSmFlZ2V1aywKPiAKPiBJIGNvbW1lbnQg aGVyZSB0aGUgcGF0Y2ggeW91ciBwcm92aWRlZCAoMyBwYXJ0cywgc2luY2UgdGhlIHBhdGNoIGNv bnRhaW5zIDMKPiBmaXhlcyk6Cj4gMS4gICsgICAgICAgZG4tPmRhdGFfYmxrYWRkciA9IGJsa2Fk ZHI7Cj4gICAgICAgICByZXQgPSByZXNlcnZlX25ld19ibG9jayhzYmksICZkbi0+ZGF0YV9ibGth ZGRyLCAmc3VtLCB0eXBlLCAwKTsKPiAKPiBXZSBjYW5ub3QgYXNzaWduIGRuLT5kYXRhX2Jsa2Fk ZHIgaGVyZS4gIFRoZSBvbGQgb25lIGlzIHRvIGJlIHVzZWQgaW4KPiByZXNlcnZlX25ld19ibG9j aygpIGZ1bmN0aW9uLiAgQWxzbywgcmVzZXJ2ZV9uZXdfYmxvY2soKSBmdW5jdGlvbiBhY3R1YWxs eQo+IHdpbGwgc2V0IGRuLT5kYXRhX2Jsa2FkZHIgdG8gYmxrYWRkciBpbiB0aGUgZW5kLgoKVGhp cyB0cmllcyB0byBhdm9pZCBkZWxldGluZyB0aGUgYmxvY2sgYWRkcmVzcyB1c2VkIGluIHRoZSBw cmV2aW91cyBvZmZzZXQuCk90aGVyd2lzZSwgd2UnbGwgc2VlIHdyb25nIGlfYmxvY2tzLgoKPiAK PiAyLiAgIEFkZGVkIGNvbmRpdGlvbiAibiA8ICgxIDw8IGMuc2xkY19jYy5sb2dfY2x1c3Rlcl9z aXplKSAqIEJMT0NLX1NaIgo+IAo+IFRoZSBzZW1hbnRpYyBtZWFuaW5nIG9mIHRoZSB3aG9sZSBp ZiBzdGF0ZW1lbnQgaXMgdG8gc2F5Ogo+ICAgIFdoZW4gdGhlIGNvbXByZXNzaW9uIGZhaWwgKHJl dCAgIT0gMCkgb3IgdGhlIG9yaWdpbmFsIHJlYWQgc2l6ZSBpcwo+IHNtYWxsZXIgdGhhbiB0aGUg Y29tcHJlc3NlZCBzaXplIHBsdXMgKHRoZSBtaW5pbXVtIGJsb2NrIHNhdmVkIChzcGVjaWZpZWQK PiBieSB0aGUgdXNlcikgeCBibG9jayBzaXplKSwgd2Ugd2lsbCBub3QgZG8gY29tcHJlc3Npb24g YnV0IGp1c3Qgd3JpdGUgdGhlCj4gZGF0YSBhcyBpcy4KClRoaXMgaXMgbWlzc2luZyB0aGUgbGFz dCBibG9jayBoYXZpbmcgPCA0S2IuCgo+IAo+IFRoZSByaWdodCBoYW5kIHNpZGUgKFJIUykgb2Yg eW91ciBhZGRlZCBjb25kaXRpb24gaXMgZXhhY3RseSB0aGUgcmVhZCBzaXplLAo+IGkuZS4gdGhl IGNsdXN0ZXIgc2l6ZS4gIFRoYXQgbWVhbnMgdGhlIGNvbmRpdGlvbiBpcyBhbHdheXMgZmFsc2Ug ZXhjZXB0IHRoZQo+IHJlYWQgb2YgdGhlIGxhc3QgcGFydCBvZiB0aGUgZmlsZSwgd2hlbiB0aGUg ZmlsZSBzaXplIGlzIG5vdCBleGFjdGx5IHRoZQo+IG11bHRpcGxlIG9mIHRoZSBjbHVzdGVyIHNp emUuICBUaGF0IG1lYW5zIHdlIHdpbGwgbmV2ZXIgdHJ5IHRvIGNvbXByZXNzIHRoZQo+IGxhc3Qg cGFydCBvZiB0aGUgZmlsZSAod2hlbiB0aGUgbGFzdCBwYXJ0IGlzIG5vdCBhIG11bHRpcGxlIG9m IHRoZSBjbHVzdGVyCj4gc2l6ZSkKPiAKPiBJTUhPLCB0aGUgb3JpZ2luYWwgaW1wbGVtZW50YXRp b24gc2hvdWxkIGJlIGNvcnJlY3QuCj4gCj4gMy4gIG5vZGVfYmxrLT5pLmlfYmxvY2tzICs9IGNw dV90b19sZTY0KGNibG9ja3MpOwo+IAo+IEkgYW0gbm90IHF1aXRlIHN1cmUgb2YgdGhlIGlfYmxv Y2tzIGNvdW50LiAgRGlkIHlvdSBtZWFuIHRoYXQgd2hlbiB0aGUgZmlsZQo+IGlzIG11dGFibGUs ICAgbWVhbmluZyB0aGF0IHRoZSBmaWxlIHJlc2VydmVzIHNvbWUgYmxvY2tzIGZvciBmdXR1cmUg d3JpdGUsCj4gd2Ugd2lsbCBhZGQgY291bnQgdG8gaV9ibG9ja3MgdG8gbWFyayB0aGUgYmxvY2sg YXMgYSB1c2VkIGJsb2NrIGJ5IHRoZQo+IGZpbGUsIHJpZ2h0PyAgSSB0aG91Z2h0IHdlIG9ubHkg bmVlZCB0byBpbmNyZW1lbnQgdGhlIGFsbG9jYXRlZCBjb3VudC4uLgoKU2hvdWxkIGFkZCBpdC4K Cj4gCj4gUmVnYXJkcywKPiBSb2JpbiBIc3Ug5b6Q55Ge5paMCj4gCj4gCj4gT24gVGh1LCBEZWMg MTAsIDIwMjAgYXQgNDo0MiBQTSBDaGFvIFl1IDx5dWNoYW8wQGh1YXdlaS5jb20+IHdyb3RlOgo+ IAo+ID4gT24gMjAyMC8xMi84IDE2OjE1LCBSb2JpbiBIc3Ugd3JvdGU6Cj4gPiA+IEZyb206IFJv YmluIEhzdSA8cm9iaW5oc3VAZ29vZ2xlLmNvbT4KPiA+ID4KPiA+ID4gQWRkIEYyRlMgY29tcHJl c3Npb24gc3VwcG9ydCBmb3Igc2xvYWQKPiA+ID4gKiBTdXBwb3J0IGZpbGUgZXh0ZW5zaW9uIGZp bHRlciwgZWl0aGVyIGRlZmF1bHQtYWNjZXB0IG9yIGRlZmF1bHQtZGVueQo+ID4gPiAgICBwb2xp Y3kKPiA+ID4gKiBTdXBwb3J0IGNob2ljZSBvZiBjb21wcmVzc2lvbiBhbGdvcml0aG0sIExaTyAo dmVyc2lvbiAyKSBvciBMWjQKPiA+ID4gICAgKGRlZmF1bHQpCj4gPiA+ICogU3VwcG9ydCBjdXN0 b20gbG9nIG9mIGNsdXN0ZXIgc2l6ZQo+ID4gPiAqIFN1cHBvcnQgbWluaW11bSBudW1iZXIgb2Yg Y29tcHJlc3NlZCBibG9ja3MgcGVyIGNsdXN0ZXIgKGRlZmF1bHQgMSkuCj4gPiA+ICAgIEEgY2x1 c3RlciB3aWxsIG5vdCBiZSBjb21wcmVzc2VkIGlmIHRoZSBudW1iZXIgY2FuIG5vdCBiZSBtZXQu Cj4gPiA+ICogc3V1cG9ydCAtciAocmVhZC1vbmx5KSBvcHRpb24KPiA+Cj4gPiBDb3VsZCB5b3Ug cGxlYXNlIHVwZGF0ZSBtYW51YWwgYXMgd2VsbD8KPiA+Cj4gPiA+ICsKPiA+ID4gKyAgICAgLyog c2xkYzogc2xvYWQgY29tcHJlc3Npb24gc3VwcG9ydCAqLwo+ID4KPiA+IFBlcnNvbmFsbHksIEkg ZG9uJ3QgbGlrZSB0aGUgbmFtaW5nIG1ldGhvZCBvZiBhZGRpbmcgInNsZGNfIiBwcmVmaXguLi4g OigKPiA+Cj4gPiA+ICsgICAgIGJvb2wgc2xkY19lbjsKPiA+ID4gKyAgICAgYm9vbCBzbGRjX3Vz ZV9hbGxvd19saXN0OyAgLyogZGVmYXVsdCBmYWxzZSB0byB1c2UgdGhlIGRlbnkgbGlzdCAqLwo+ ID4gPiArICAgICBzdHJ1Y3QgY29tcHJlc3NfY3R4IHNsZGNfY2M7Cj4gPiA+ICsgICAgIHU4IHNs ZGNfY2E7IC8qIGNvbXByZXNzIGFsZ29yaXRobTogMCA9IExaTywgMSA9IExaNCAqLwo+ID4gPiAr ICAgICBjb21wcmVzc19vcHMgKnNsZGNfY29tcHI7Cj4gPiA+ICsgICAgIGVudW0gZmlsdGVyX3Bv bGljeSBzbGRjX3BvbGljeTsKPiA+ID4gKyAgICAgLyogbWF4X2NwcGMgY2FuIHVzZWQgdG8gc3Bl Y2lmeSBtaW5pbXVtIGNvbXByZXNzaW9uIHJhdGUgKi8KPiA+ID4gKyAgICAgdW5zaWduZWQgaW50 IHNsZGNfbWluX2NicGM7IC8qIG1pbiBjb21wcmVzc2VkIHBhZ2VzIHBlciBjbHVzdGVyICovCj4g PiA+ICsgICAgIGJvb2wgc2xkY19nb3Rfb3B0Owo+ID4gPiArICAgICBib29sIHNsZGNfaW1tdXRh YmxlOwo+ID4gPiArICAgICBzdHJ1Y3QgZXh0X3RibF9vcCAqc2xkY19lZjsgLyogZXh0ZW5zaW9u IGZpbHRlciAqLwo+ID4KPiA+IFRoZSB2YXJpYWJsZXMgbmFtZSBsaWtlIHNsZGNfZW4sIHNsZGNf Y2EsIG1pbl9jYnBjLCBzbGRjX2VmIG1ha2VzCj4gPiBkZXZlbG9wZXJzCj4gPiBoYXJkIHRvIHVu ZGVyc3RhbmQgdy9vIGNvbW1lbnRzLCBhbmQgYWxzbyB0aGVyZSBpcyBubyBjb21tZW50cyBmb3Ig c2V2ZXJhbAo+ID4gdmFyaWFibGUgbGlrZSBzbGRjX2VuLCBzbGRjX2NjLi4uCj4gPgo+ID4gQ291 bGQgeW91IHBsZWFzZSBpbXByb3ZlIHRoZSBuYW1pbmcgbGlrZSBmMmZzLXRvb2xzIHN0eWxlPwo+ ID4KPiA+IFRoYW5rcywKPiA+CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KTGludXgtZjJmcy1kZXZlbCBtYWlsaW5nIGxpc3QKTGludXgtZjJmcy1kZXZl bEBsaXN0cy5zb3VyY2Vmb3JnZS5uZXQKaHR0cHM6Ly9saXN0cy5zb3VyY2Vmb3JnZS5uZXQvbGlz dHMvbGlzdGluZm8vbGludXgtZjJmcy1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADA3DC4361B for ; Thu, 10 Dec 2020 16:24:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5327D23158 for ; Thu, 10 Dec 2020 16:24:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392229AbgLJQXj (ORCPT ); Thu, 10 Dec 2020 11:23:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:48928 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388407AbgLJQXi (ORCPT ); Thu, 10 Dec 2020 11:23:38 -0500 Date: Thu, 10 Dec 2020 08:22:56 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607617378; bh=IT1JhMouVay4d31+Gw+I77QyHRv1BMMQHowugQ1EGS8=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=Uo0NiqgPB/g8PXQKQB1ZRC1Telxr2qFG92011hQ3lHonyXSLgYaxJq158mhIWfKFZ HicY16RuNTpihqbB3lhvS5B0lT793phbiG+v82xkBK1sIb8kLIzpluOrHO22KhaZP1 DMdphQ8Mw7oe9cn5SrVx0/YisG6MS7RKeVcA6cxHhknAWBvUgwYMcMYhr7oDZM0SgA Y0ktr1nILe/+Q2OEkkH/dGG14TWxGtPvQiVAUXuoW90aD4J+x1xMWpI/d8feiMhHrd Z2waf0JVIn1DUdrZv/Gp1EWiXCpAIigqyCyqM9EaGykgMQWUtnbwaZSFW6wO1QSxmw hOG5IHCWpQ4Wg== From: Jaegeuk Kim To: =?utf-8?B?5b6Q55Ge5paM?= Cc: Chao Yu , linux-f2fs-devel@lists.sourceforge.net, chao@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [f2fs-dev] [PATCH v3 2/3] f2fs-tools:sload.f2fs compression support Message-ID: References: <20201208081555.652932-1-robinh3123@gmail.com> <20201208081555.652932-3-robinh3123@gmail.com> <785e9f0a-c3d6-9cc5-f17a-a3cc58a43a0f@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/10, 徐瑞斌 wrote: > Hi, Jaegeuk, > > I comment here the patch your provided (3 parts, since the patch contains 3 > fixes): > 1. + dn->data_blkaddr = blkaddr; > ret = reserve_new_block(sbi, &dn->data_blkaddr, &sum, type, 0); > > We cannot assign dn->data_blkaddr here. The old one is to be used in > reserve_new_block() function. Also, reserve_new_block() function actually > will set dn->data_blkaddr to blkaddr in the end. This tries to avoid deleting the block address used in the previous offset. Otherwise, we'll see wrong i_blocks. > > 2. Added condition "n < (1 << c.sldc_cc.log_cluster_size) * BLOCK_SZ" > > The semantic meaning of the whole if statement is to say: > When the compression fail (ret != 0) or the original read size is > smaller than the compressed size plus (the minimum block saved (specified > by the user) x block size), we will not do compression but just write the > data as is. This is missing the last block having < 4Kb. > > The right hand side (RHS) of your added condition is exactly the read size, > i.e. the cluster size. That means the condition is always false except the > read of the last part of the file, when the file size is not exactly the > multiple of the cluster size. That means we will never try to compress the > last part of the file (when the last part is not a multiple of the cluster > size) > > IMHO, the original implementation should be correct. > > 3. node_blk->i.i_blocks += cpu_to_le64(cblocks); > > I am not quite sure of the i_blocks count. Did you mean that when the file > is mutable, meaning that the file reserves some blocks for future write, > we will add count to i_blocks to mark the block as a used block by the > file, right? I thought we only need to increment the allocated count... Should add it. > > Regards, > Robin Hsu 徐瑞斌 > > > On Thu, Dec 10, 2020 at 4:42 PM Chao Yu wrote: > > > On 2020/12/8 16:15, Robin Hsu wrote: > > > From: Robin Hsu > > > > > > Add F2FS compression support for sload > > > * Support file extension filter, either default-accept or default-deny > > > policy > > > * Support choice of compression algorithm, LZO (version 2) or LZ4 > > > (default) > > > * Support custom log of cluster size > > > * Support minimum number of compressed blocks per cluster (default 1). > > > A cluster will not be compressed if the number can not be met. > > > * suuport -r (read-only) option > > > > Could you please update manual as well? > > > > > + > > > + /* sldc: sload compression support */ > > > > Personally, I don't like the naming method of adding "sldc_" prefix... :( > > > > > + bool sldc_en; > > > + bool sldc_use_allow_list; /* default false to use the deny list */ > > > + struct compress_ctx sldc_cc; > > > + u8 sldc_ca; /* compress algorithm: 0 = LZO, 1 = LZ4 */ > > > + compress_ops *sldc_compr; > > > + enum filter_policy sldc_policy; > > > + /* max_cppc can used to specify minimum compression rate */ > > > + unsigned int sldc_min_cbpc; /* min compressed pages per cluster */ > > > + bool sldc_got_opt; > > > + bool sldc_immutable; > > > + struct ext_tbl_op *sldc_ef; /* extension filter */ > > > > The variables name like sldc_en, sldc_ca, min_cbpc, sldc_ef makes > > developers > > hard to understand w/o comments, and also there is no comments for several > > variable like sldc_en, sldc_cc... > > > > Could you please improve the naming like f2fs-tools style? > > > > Thanks, > >