From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F242C4361B for ; Thu, 10 Dec 2020 16:40:23 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C2C0B2388B; Thu, 10 Dec 2020 16:40:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C2C0B2388B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1knOzN-0002Nj-Fm; Thu, 10 Dec 2020 16:40:21 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knOvg-0001wk-Je for linux-f2fs-devel@lists.sourceforge.net; Thu, 10 Dec 2020 16:36:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9j9IGwUqdwc8vK2GCjcAzf4gEPZCZv2JGAoOq1jdgew=; b=XnJDj74Vlq7oj0UUd4DbMZAmWV iK/0Lw6G2LWQFEOcuVXKS9uDcCt0Vh7628hsho3Eb9Be3PnNT+YEfiiWAgU9cd0tgOoOtCOVXTi4w jO4gT1+vMBx6d45kqu23xFIUOpD5XdonlZqvD4TKYtuJRXuui3CNogeK8HoCrP4VHLrY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=9j9IGwUqdwc8vK2GCjcAzf4gEPZCZv2JGAoOq1jdgew=; b=gof3T5ToN0GMitNQGHs7yR3nu8 1y3S8fpF1rD3jc5p+qNxr5mK+F7HJA/TXCJvHKSYNYCbF68oQmgUeDTgNW553SMesuf8kcNLPXcHV AMbKZ/xCb03RQ7uLpHHFIOGZHOStt3dndS3XPZlf9vaLSQmEKff+P8pqKwDsxAJ4lxDk=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1knOvS-006hva-Qn for linux-f2fs-devel@lists.sourceforge.net; Thu, 10 Dec 2020 16:36:32 +0000 Date: Thu, 10 Dec 2020 08:36:11 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607618173; bh=fbQ4nuVsVzui/yLCe8bXeRIRjFWB90VPKZTYzTxSMsU=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=GzMO/8Sg2LxApIIozXGkp2kgxVaFJ1k8OEWW7WQ6vCJPb//80dlWjFqcTWjXH4dns ViCNL5ubiNQnJBtKE5Nsgh1+W2C2JhRMO+SgKG8pkk+6GzEHJzK6S/sfxTGurmeDG0 JSIDkOlpGvd/vNW9kC3YCi97QD/kDZkrkcHejfyLCbLVpNYX2kT9ootfZ3ieOEQ/9o bONisRZRZ12z20XKbP/wAFinLmN3nyEyOjwfgS9+jzeUOwjeHMwBSSawWflOOsJmwp V6WrYSeulHnXBzixunP4sLIDqLBKNVD0rwuaIIhrVJI7P9lUXMRmfQU8C3Ib5NrweJ Fgc/fHeQyrbRA== From: Jaegeuk Kim To: =?utf-8?B?5b6Q55Ge5paM?= Message-ID: References: <20201208081555.652932-1-robinh3123@gmail.com> <20201208081555.652932-3-robinh3123@gmail.com> <785e9f0a-c3d6-9cc5-f17a-a3cc58a43a0f@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1knOvS-006hva-Qn Subject: Re: [f2fs-dev] [PATCH v3 2/3] f2fs-tools:sload.f2fs compression support X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Q2hhbyBhbmQgUm9iaW4sCgpJIHJlZmFjdG9yZWQgdGhlIHBhdGNoIHRvIG1vZGlmeSB0aGUgbmFt ZXMgYW5kIHN0cnVjdHVyZXMuClBsZWFzZSB0YWtlIGEgbG9vayBhdCB0aGlzLgpodHRwczovL2dp dC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC9qYWVnZXVrL2YyZnMtdG9vbHMu Z2l0L2NvbW1pdC8/aD1kZXYmaWQ9NWNkOGU1ZmNjNzk2MTFjMDY5MmYxOGM3ZTdlMTNkNmI0NzQy ZDNjMAoKT24gMTIvMTAsIEphZWdldWsgS2ltIHdyb3RlOgo+IE9uIDEyLzEwLCDlvpDnkZ7mlowg d3JvdGU6Cj4gPiBIaSwgSmFlZ2V1aywKPiA+IAo+ID4gSSBjb21tZW50IGhlcmUgdGhlIHBhdGNo IHlvdXIgcHJvdmlkZWQgKDMgcGFydHMsIHNpbmNlIHRoZSBwYXRjaCBjb250YWlucyAzCj4gPiBm aXhlcyk6Cj4gPiAxLiAgKyAgICAgICBkbi0+ZGF0YV9ibGthZGRyID0gYmxrYWRkcjsKPiA+ICAg ICAgICAgcmV0ID0gcmVzZXJ2ZV9uZXdfYmxvY2soc2JpLCAmZG4tPmRhdGFfYmxrYWRkciwgJnN1 bSwgdHlwZSwgMCk7Cj4gPiAKPiA+IFdlIGNhbm5vdCBhc3NpZ24gZG4tPmRhdGFfYmxrYWRkciBo ZXJlLiAgVGhlIG9sZCBvbmUgaXMgdG8gYmUgdXNlZCBpbgo+ID4gcmVzZXJ2ZV9uZXdfYmxvY2so KSBmdW5jdGlvbi4gIEFsc28sIHJlc2VydmVfbmV3X2Jsb2NrKCkgZnVuY3Rpb24gYWN0dWFsbHkK PiA+IHdpbGwgc2V0IGRuLT5kYXRhX2Jsa2FkZHIgdG8gYmxrYWRkciBpbiB0aGUgZW5kLgo+IAo+ IFRoaXMgdHJpZXMgdG8gYXZvaWQgZGVsZXRpbmcgdGhlIGJsb2NrIGFkZHJlc3MgdXNlZCBpbiB0 aGUgcHJldmlvdXMgb2Zmc2V0Lgo+IE90aGVyd2lzZSwgd2UnbGwgc2VlIHdyb25nIGlfYmxvY2tz Lgo+IAo+ID4gCj4gPiAyLiAgIEFkZGVkIGNvbmRpdGlvbiAibiA8ICgxIDw8IGMuc2xkY19jYy5s b2dfY2x1c3Rlcl9zaXplKSAqIEJMT0NLX1NaIgo+ID4gCj4gPiBUaGUgc2VtYW50aWMgbWVhbmlu ZyBvZiB0aGUgd2hvbGUgaWYgc3RhdGVtZW50IGlzIHRvIHNheToKPiA+ICAgIFdoZW4gdGhlIGNv bXByZXNzaW9uIGZhaWwgKHJldCAgIT0gMCkgb3IgdGhlIG9yaWdpbmFsIHJlYWQgc2l6ZSBpcwo+ ID4gc21hbGxlciB0aGFuIHRoZSBjb21wcmVzc2VkIHNpemUgcGx1cyAodGhlIG1pbmltdW0gYmxv Y2sgc2F2ZWQgKHNwZWNpZmllZAo+ID4gYnkgdGhlIHVzZXIpIHggYmxvY2sgc2l6ZSksIHdlIHdp bGwgbm90IGRvIGNvbXByZXNzaW9uIGJ1dCBqdXN0IHdyaXRlIHRoZQo+ID4gZGF0YSBhcyBpcy4K PiAKPiBUaGlzIGlzIG1pc3NpbmcgdGhlIGxhc3QgYmxvY2sgaGF2aW5nIDwgNEtiLgo+IAo+ID4g Cj4gPiBUaGUgcmlnaHQgaGFuZCBzaWRlIChSSFMpIG9mIHlvdXIgYWRkZWQgY29uZGl0aW9uIGlz IGV4YWN0bHkgdGhlIHJlYWQgc2l6ZSwKPiA+IGkuZS4gdGhlIGNsdXN0ZXIgc2l6ZS4gIFRoYXQg bWVhbnMgdGhlIGNvbmRpdGlvbiBpcyBhbHdheXMgZmFsc2UgZXhjZXB0IHRoZQo+ID4gcmVhZCBv ZiB0aGUgbGFzdCBwYXJ0IG9mIHRoZSBmaWxlLCB3aGVuIHRoZSBmaWxlIHNpemUgaXMgbm90IGV4 YWN0bHkgdGhlCj4gPiBtdWx0aXBsZSBvZiB0aGUgY2x1c3RlciBzaXplLiAgVGhhdCBtZWFucyB3 ZSB3aWxsIG5ldmVyIHRyeSB0byBjb21wcmVzcyB0aGUKPiA+IGxhc3QgcGFydCBvZiB0aGUgZmls ZSAod2hlbiB0aGUgbGFzdCBwYXJ0IGlzIG5vdCBhIG11bHRpcGxlIG9mIHRoZSBjbHVzdGVyCj4g PiBzaXplKQo+ID4gCj4gPiBJTUhPLCB0aGUgb3JpZ2luYWwgaW1wbGVtZW50YXRpb24gc2hvdWxk IGJlIGNvcnJlY3QuCj4gPiAKPiA+IDMuICBub2RlX2Jsay0+aS5pX2Jsb2NrcyArPSBjcHVfdG9f bGU2NChjYmxvY2tzKTsKPiA+IAo+ID4gSSBhbSBub3QgcXVpdGUgc3VyZSBvZiB0aGUgaV9ibG9j a3MgY291bnQuICBEaWQgeW91IG1lYW4gdGhhdCB3aGVuIHRoZSBmaWxlCj4gPiBpcyBtdXRhYmxl LCAgIG1lYW5pbmcgdGhhdCB0aGUgZmlsZSByZXNlcnZlcyBzb21lIGJsb2NrcyBmb3IgZnV0dXJl IHdyaXRlLAo+ID4gd2Ugd2lsbCBhZGQgY291bnQgdG8gaV9ibG9ja3MgdG8gbWFyayB0aGUgYmxv Y2sgYXMgYSB1c2VkIGJsb2NrIGJ5IHRoZQo+ID4gZmlsZSwgcmlnaHQ/ICBJIHRob3VnaHQgd2Ug b25seSBuZWVkIHRvIGluY3JlbWVudCB0aGUgYWxsb2NhdGVkIGNvdW50Li4uCj4gCj4gU2hvdWxk IGFkZCBpdC4KPiAKPiA+IAo+ID4gUmVnYXJkcywKPiA+IFJvYmluIEhzdSDlvpDnkZ7mlowKPiA+ IAo+ID4gCj4gPiBPbiBUaHUsIERlYyAxMCwgMjAyMCBhdCA0OjQyIFBNIENoYW8gWXUgPHl1Y2hh bzBAaHVhd2VpLmNvbT4gd3JvdGU6Cj4gPiAKPiA+ID4gT24gMjAyMC8xMi84IDE2OjE1LCBSb2Jp biBIc3Ugd3JvdGU6Cj4gPiA+ID4gRnJvbTogUm9iaW4gSHN1IDxyb2JpbmhzdUBnb29nbGUuY29t Pgo+ID4gPiA+Cj4gPiA+ID4gQWRkIEYyRlMgY29tcHJlc3Npb24gc3VwcG9ydCBmb3Igc2xvYWQK PiA+ID4gPiAqIFN1cHBvcnQgZmlsZSBleHRlbnNpb24gZmlsdGVyLCBlaXRoZXIgZGVmYXVsdC1h Y2NlcHQgb3IgZGVmYXVsdC1kZW55Cj4gPiA+ID4gICAgcG9saWN5Cj4gPiA+ID4gKiBTdXBwb3J0 IGNob2ljZSBvZiBjb21wcmVzc2lvbiBhbGdvcml0aG0sIExaTyAodmVyc2lvbiAyKSBvciBMWjQK PiA+ID4gPiAgICAoZGVmYXVsdCkKPiA+ID4gPiAqIFN1cHBvcnQgY3VzdG9tIGxvZyBvZiBjbHVz dGVyIHNpemUKPiA+ID4gPiAqIFN1cHBvcnQgbWluaW11bSBudW1iZXIgb2YgY29tcHJlc3NlZCBi bG9ja3MgcGVyIGNsdXN0ZXIgKGRlZmF1bHQgMSkuCj4gPiA+ID4gICAgQSBjbHVzdGVyIHdpbGwg bm90IGJlIGNvbXByZXNzZWQgaWYgdGhlIG51bWJlciBjYW4gbm90IGJlIG1ldC4KPiA+ID4gPiAq IHN1dXBvcnQgLXIgKHJlYWQtb25seSkgb3B0aW9uCj4gPiA+Cj4gPiA+IENvdWxkIHlvdSBwbGVh c2UgdXBkYXRlIG1hbnVhbCBhcyB3ZWxsPwo+ID4gPgo+ID4gPiA+ICsKPiA+ID4gPiArICAgICAv KiBzbGRjOiBzbG9hZCBjb21wcmVzc2lvbiBzdXBwb3J0ICovCj4gPiA+Cj4gPiA+IFBlcnNvbmFs bHksIEkgZG9uJ3QgbGlrZSB0aGUgbmFtaW5nIG1ldGhvZCBvZiBhZGRpbmcgInNsZGNfIiBwcmVm aXguLi4gOigKPiA+ID4KPiA+ID4gPiArICAgICBib29sIHNsZGNfZW47Cj4gPiA+ID4gKyAgICAg Ym9vbCBzbGRjX3VzZV9hbGxvd19saXN0OyAgLyogZGVmYXVsdCBmYWxzZSB0byB1c2UgdGhlIGRl bnkgbGlzdCAqLwo+ID4gPiA+ICsgICAgIHN0cnVjdCBjb21wcmVzc19jdHggc2xkY19jYzsKPiA+ ID4gPiArICAgICB1OCBzbGRjX2NhOyAvKiBjb21wcmVzcyBhbGdvcml0aG06IDAgPSBMWk8sIDEg PSBMWjQgKi8KPiA+ID4gPiArICAgICBjb21wcmVzc19vcHMgKnNsZGNfY29tcHI7Cj4gPiA+ID4g KyAgICAgZW51bSBmaWx0ZXJfcG9saWN5IHNsZGNfcG9saWN5Owo+ID4gPiA+ICsgICAgIC8qIG1h eF9jcHBjIGNhbiB1c2VkIHRvIHNwZWNpZnkgbWluaW11bSBjb21wcmVzc2lvbiByYXRlICovCj4g PiA+ID4gKyAgICAgdW5zaWduZWQgaW50IHNsZGNfbWluX2NicGM7IC8qIG1pbiBjb21wcmVzc2Vk IHBhZ2VzIHBlciBjbHVzdGVyICovCj4gPiA+ID4gKyAgICAgYm9vbCBzbGRjX2dvdF9vcHQ7Cj4g PiA+ID4gKyAgICAgYm9vbCBzbGRjX2ltbXV0YWJsZTsKPiA+ID4gPiArICAgICBzdHJ1Y3QgZXh0 X3RibF9vcCAqc2xkY19lZjsgLyogZXh0ZW5zaW9uIGZpbHRlciAqLwo+ID4gPgo+ID4gPiBUaGUg dmFyaWFibGVzIG5hbWUgbGlrZSBzbGRjX2VuLCBzbGRjX2NhLCBtaW5fY2JwYywgc2xkY19lZiBt YWtlcwo+ID4gPiBkZXZlbG9wZXJzCj4gPiA+IGhhcmQgdG8gdW5kZXJzdGFuZCB3L28gY29tbWVu dHMsIGFuZCBhbHNvIHRoZXJlIGlzIG5vIGNvbW1lbnRzIGZvciBzZXZlcmFsCj4gPiA+IHZhcmlh YmxlIGxpa2Ugc2xkY19lbiwgc2xkY19jYy4uLgo+ID4gPgo+ID4gPiBDb3VsZCB5b3UgcGxlYXNl IGltcHJvdmUgdGhlIG5hbWluZyBsaWtlIGYyZnMtdG9vbHMgc3R5bGU/Cj4gPiA+Cj4gPiA+IFRo YW5rcywKPiA+ID4KPiAKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwo+IExpbnV4LWYyZnMtZGV2ZWwgbWFpbGluZyBsaXN0Cj4gTGludXgtZjJmcy1k ZXZlbEBsaXN0cy5zb3VyY2Vmb3JnZS5uZXQKPiBodHRwczovL2xpc3RzLnNvdXJjZWZvcmdlLm5l dC9saXN0cy9saXN0aW5mby9saW51eC1mMmZzLWRldmVsCgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtZjJmcy1kZXZlbCBtYWlsaW5nIGxpc3QK TGludXgtZjJmcy1kZXZlbEBsaXN0cy5zb3VyY2Vmb3JnZS5uZXQKaHR0cHM6Ly9saXN0cy5zb3Vy Y2Vmb3JnZS5uZXQvbGlzdHMvbGlzdGluZm8vbGludXgtZjJmcy1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 297F8C4167B for ; Thu, 10 Dec 2020 16:37:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE97A23117 for ; Thu, 10 Dec 2020 16:37:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392183AbgLJQhK (ORCPT ); Thu, 10 Dec 2020 11:37:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:58116 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391184AbgLJQgy (ORCPT ); Thu, 10 Dec 2020 11:36:54 -0500 Date: Thu, 10 Dec 2020 08:36:11 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607618173; bh=fbQ4nuVsVzui/yLCe8bXeRIRjFWB90VPKZTYzTxSMsU=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=GzMO/8Sg2LxApIIozXGkp2kgxVaFJ1k8OEWW7WQ6vCJPb//80dlWjFqcTWjXH4dns ViCNL5ubiNQnJBtKE5Nsgh1+W2C2JhRMO+SgKG8pkk+6GzEHJzK6S/sfxTGurmeDG0 JSIDkOlpGvd/vNW9kC3YCi97QD/kDZkrkcHejfyLCbLVpNYX2kT9ootfZ3ieOEQ/9o bONisRZRZ12z20XKbP/wAFinLmN3nyEyOjwfgS9+jzeUOwjeHMwBSSawWflOOsJmwp V6WrYSeulHnXBzixunP4sLIDqLBKNVD0rwuaIIhrVJI7P9lUXMRmfQU8C3Ib5NrweJ Fgc/fHeQyrbRA== From: Jaegeuk Kim To: =?utf-8?B?5b6Q55Ge5paM?= Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH v3 2/3] f2fs-tools:sload.f2fs compression support Message-ID: References: <20201208081555.652932-1-robinh3123@gmail.com> <20201208081555.652932-3-robinh3123@gmail.com> <785e9f0a-c3d6-9cc5-f17a-a3cc58a43a0f@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Chao and Robin, I refactored the patch to modify the names and structures. Please take a look at this. https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-tools.git/commit/?h=dev&id=5cd8e5fcc79611c0692f18c7e7e13d6b4742d3c0 On 12/10, Jaegeuk Kim wrote: > On 12/10, 徐瑞斌 wrote: > > Hi, Jaegeuk, > > > > I comment here the patch your provided (3 parts, since the patch contains 3 > > fixes): > > 1. + dn->data_blkaddr = blkaddr; > > ret = reserve_new_block(sbi, &dn->data_blkaddr, &sum, type, 0); > > > > We cannot assign dn->data_blkaddr here. The old one is to be used in > > reserve_new_block() function. Also, reserve_new_block() function actually > > will set dn->data_blkaddr to blkaddr in the end. > > This tries to avoid deleting the block address used in the previous offset. > Otherwise, we'll see wrong i_blocks. > > > > > 2. Added condition "n < (1 << c.sldc_cc.log_cluster_size) * BLOCK_SZ" > > > > The semantic meaning of the whole if statement is to say: > > When the compression fail (ret != 0) or the original read size is > > smaller than the compressed size plus (the minimum block saved (specified > > by the user) x block size), we will not do compression but just write the > > data as is. > > This is missing the last block having < 4Kb. > > > > > The right hand side (RHS) of your added condition is exactly the read size, > > i.e. the cluster size. That means the condition is always false except the > > read of the last part of the file, when the file size is not exactly the > > multiple of the cluster size. That means we will never try to compress the > > last part of the file (when the last part is not a multiple of the cluster > > size) > > > > IMHO, the original implementation should be correct. > > > > 3. node_blk->i.i_blocks += cpu_to_le64(cblocks); > > > > I am not quite sure of the i_blocks count. Did you mean that when the file > > is mutable, meaning that the file reserves some blocks for future write, > > we will add count to i_blocks to mark the block as a used block by the > > file, right? I thought we only need to increment the allocated count... > > Should add it. > > > > > Regards, > > Robin Hsu 徐瑞斌 > > > > > > On Thu, Dec 10, 2020 at 4:42 PM Chao Yu wrote: > > > > > On 2020/12/8 16:15, Robin Hsu wrote: > > > > From: Robin Hsu > > > > > > > > Add F2FS compression support for sload > > > > * Support file extension filter, either default-accept or default-deny > > > > policy > > > > * Support choice of compression algorithm, LZO (version 2) or LZ4 > > > > (default) > > > > * Support custom log of cluster size > > > > * Support minimum number of compressed blocks per cluster (default 1). > > > > A cluster will not be compressed if the number can not be met. > > > > * suuport -r (read-only) option > > > > > > Could you please update manual as well? > > > > > > > + > > > > + /* sldc: sload compression support */ > > > > > > Personally, I don't like the naming method of adding "sldc_" prefix... :( > > > > > > > + bool sldc_en; > > > > + bool sldc_use_allow_list; /* default false to use the deny list */ > > > > + struct compress_ctx sldc_cc; > > > > + u8 sldc_ca; /* compress algorithm: 0 = LZO, 1 = LZ4 */ > > > > + compress_ops *sldc_compr; > > > > + enum filter_policy sldc_policy; > > > > + /* max_cppc can used to specify minimum compression rate */ > > > > + unsigned int sldc_min_cbpc; /* min compressed pages per cluster */ > > > > + bool sldc_got_opt; > > > > + bool sldc_immutable; > > > > + struct ext_tbl_op *sldc_ef; /* extension filter */ > > > > > > The variables name like sldc_en, sldc_ca, min_cbpc, sldc_ef makes > > > developers > > > hard to understand w/o comments, and also there is no comments for several > > > variable like sldc_en, sldc_cc... > > > > > > Could you please improve the naming like f2fs-tools style? > > > > > > Thanks, > > > > > > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel