From: Thierry Reding <thierry.reding@gmail.com>
To: "Uwe Kleine-König" <uwe@kleine-koenig.org>
Cc: Lee Jones <lee.jones@linaro.org>, linux-pwm@vger.kernel.org
Subject: Re: [PATCH] pwm: Remove unused function pwmchip_add_inversed()
Date: Thu, 10 Dec 2020 18:35:48 +0100 [thread overview]
Message-ID: <X9JcdNkS3s1cuTBU@ulmo> (raw)
In-Reply-To: <20201205161924.3864915-1-uwe@kleine-koenig.org>
[-- Attachment #1: Type: text/plain, Size: 765 bytes --]
On Sat, Dec 05, 2020 at 05:19:24PM +0100, Uwe Kleine-König wrote:
> This is only defined with CONFIG_PWM unset and was introduced together
> with pwmchip_add_with_polarity() (which is only defined with CONFIG_PWM
> enabled). I guess the series that introduced pwmchip_add_with_polarity()
> had a different concept in earlier revisions and the !CONFIG_PWM part
> was just not updated accordingly.
>
> Given that there is no implementation for pwmchip_add_with_polarity()
> without CONFIG_PWM, just drop pwmchip_add_inversed() instead of renaming
> it to pwmchip_add_with_polarity().
>
> Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
> ---
> include/linux/pwm.h | 5 -----
> 1 file changed, 5 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2020-12-10 17:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-05 16:19 [PATCH] pwm: Remove unused function pwmchip_add_inversed() Uwe Kleine-König
2020-12-07 9:22 ` Lee Jones
2020-12-10 17:35 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X9JcdNkS3s1cuTBU@ulmo \
--to=thierry.reding@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-pwm@vger.kernel.org \
--cc=uwe@kleine-koenig.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.