All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v1] openposix/fork/7-1.c: A bug fix
Date: Fri, 11 Dec 2020 11:53:43 +0100	[thread overview]
Message-ID: <X9NPty84RhoUmgSE@yuki.lan> (raw)
In-Reply-To: <750CB65B-8F87-484D-9373-5CE4E1003413@getmailspring.com>

Hi!
> By adding this comment I wanted to stress that the place of "errno =
> 0" is not randomly chosen, to prevent somebody from moving it back to
> the beginning of the file :) But if you find it not necessary, then
> please go ahead.

I think that this still falls under "do not comment the obvious" rule.
We do have more than hundred of testcases that do "errno = 0" and as far
as I can tell none of them includes a comment that says that we cannot
move the code around and I do not think that we should add hundred of
comments into these testcases either.

-- 
Cyril Hrubis
chrubis@suse.cz

  parent reply	other threads:[~2020-12-11 10:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-11  9:44 [LTP] [PATCH v1] openposix/fork/7-1.c: A bug fix Bogdan Lezhepekov
2020-12-11  9:54 ` Cyril Hrubis
2020-12-11 10:04   ` Bogdan Lezhepekov
2020-12-11 10:22     ` Bogdan Lezhepekov
2020-12-11 11:26       ` Cyril Hrubis
2020-12-11 10:53     ` Cyril Hrubis [this message]
2020-12-11 11:27     ` Cyril Hrubis
  -- strict thread matches above, loose matches on Subject: below --
2020-12-10 16:51 Bogdan Lezhepekov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X9NPty84RhoUmgSE@yuki.lan \
    --to=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.