From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Saravana Kannan <saravanak@google.com>,
Len Brown <lenb@kernel.org>, Rob Herring <robh@kernel.org>,
Qian Cai <qcai@redhat.com>, Robin Murphy <robin.murphy@arm.com>,
Marc Zyngier <maz@kernel.org>,
kernel-team@android.com, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ACPI: Use fwnode_init() to set up fwnode
Date: Sat, 12 Dec 2020 12:41:46 +0100 [thread overview]
Message-ID: <X9SsegnBlMN+RTb6@kroah.com> (raw)
In-Reply-To: <3491615.yqrABBVLMz@kreacher>
On Fri, Dec 11, 2020 at 09:53:09PM +0100, Rafael J. Wysocki wrote:
> On Friday, December 11, 2020 9:26:29 PM CET Saravana Kannan wrote:
> > Commit 01bb86b380a3 ("driver core: Add fwnode_init()") was supposed to
> > fix up all instances of fwnode creation to use fwnode_init(). But looks
> > like this instance was missed. This causes a NULL pointer dereference
> > during device_add() [1]. So, fix it.
> >
> > [ 60.792324][ T1] Call trace:
> > [ 60.795495][ T1] device_add+0xf60/0x16b0
> > __fw_devlink_link_to_consumers at drivers/base/core.c:1583
> > (inlined by) fw_devlink_link_device at drivers/base/core.c:1726
> > (inlined by) device_add at drivers/base/core.c:3088
> > [ 60.799813][ T1] platform_device_add+0x274/0x628
> > [ 60.804833][ T1] acpi_iort_init+0x9d8/0xc50
> > [ 60.809415][ T1] acpi_init+0x45c/0x4e8
> > [ 60.813556][ T1] do_one_initcall+0x170/0xb70
> > [ 60.818224][ T1] kernel_init_freeable+0x6a8/0x734
> > [ 60.823332][ T1] kernel_init+0x18/0x12c
> > [ 60.827566][ T1] ret_from_fork+0x10/0x1c
> > [ 60.838756][ T1] ---[ end trace fa5c8ce17a226d83 ]---
> >
> > [1] - https://lore.kernel.org/linux-arm-kernel/02e7047071f0b54b046ac472adeeb3fafabc643c.camel@redhat.com/
> > Fixes: 01bb86b380a3 ("driver core: Add fwnode_init()")
> > Reported-by: Qian Cai <qcai@redhat.com>
> > Suggested-by: Robin Murphy <robin.murphy@arm.com>
> > Tested-by: Marc Zyngier <maz@kernel.org>
> > Signed-off-by: Saravana Kannan <saravanak@google.com>
>
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2020-12-12 11:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 20:26 [PATCH] ACPI: Use fwnode_init() to set up fwnode Saravana Kannan
2020-12-11 20:53 ` Rafael J. Wysocki
2020-12-12 11:41 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X9SsegnBlMN+RTb6@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=kernel-team@android.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=qcai@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.