From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1ko9fe-0008U0-VE for mharc-grub-devel@gnu.org; Sat, 12 Dec 2020 13:31:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35094) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ko9fd-0008Qt-JW for grub-devel@gnu.org; Sat, 12 Dec 2020 13:31:05 -0500 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:38253) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ko9fY-0006Ki-13 for grub-devel@gnu.org; Sat, 12 Dec 2020 13:31:05 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id B7F935C2; Sat, 12 Dec 2020 12:36:12 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sat, 12 Dec 2020 12:36:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=U1o5hrTz7rbl1L5JyArdTGzvQwm WF7JlmYemV+5fMAE=; b=m0f+amJX6ZjsQvaq+LMVoplJeOAiePy8xDhO47En0Oh ebPL5zdUlZgkNIEtJTLdtjHUXYbr/b9EHwjHaLL3HX/RZZ3KFcW0CW67XdwaLbXH YZ3POzMQkw5MHAWcHnDByo68j9BB8APOCub2+HL/9WMf2LGONCHSkJbsxZXlrbWx E4TvYzp+PWENi/m5/Eh2pjVH3wXgvti2lO8fwO47lyQu4HJlDcfxMT70Qzlakqbd Q60rJ07hxEFsVo35LQ6HcffIAc/2gShOV+yzZAHSzBZOaowcYIdwFEh6Ej2aOw+E mQG3Vxou5Ls5XgEXN4/QyTnF5kG/QLrXPPhrBCzy3MA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=U1o5hr Tz7rbl1L5JyArdTGzvQwmWF7JlmYemV+5fMAE=; b=Gt8cJQSeenNPzftXNylqqo tE8S8FNTHJZK3+tUo11HZYOiPM49SftMVupypOxwl8L8kl3BUf47niogf+p6FtES 9pFQ1ecU6Gk/Tc6IQAOF0WaFsYyf3nl9ZBtEvdQcbazevj2A11kiX1rHnPs7PqgH nrPp/y4wHbgHKR8IiSW7cb8xi00OA2Zf6Rou9b/GP50N/rWqZRKSbdsabeWtOaC/ 3Re9QY3A4Gyz2UTEHXw/LfEPkhEXgHW4Nd+G9KAlvTMgR2xEN2dm+z/2CkzKk24u 7bDU7yt9d1VZ2Ln9DkCxE8403+5622VN5DfnAxZ1bby+N7uHiX5glzb1cv8pkuHA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudekgedguddtgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomheprfgrthhr ihgtkhcuufhtvghinhhhrghrughtuceophhssehpkhhsrdhimheqnecuggftrfgrthhtvg hrnhepheeghfdtfeeuffehkefgffduleffjedthfdvjeektdfhhedvlefgtefgvdettdfh necukfhppeejjedrudeluddrvdefjedrvdegvdenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehpshesphhkshdrihhm X-ME-Proxy: Received: from vm-mail.pks.im (x4dbfedf2.dyn.telefonica.de [77.191.237.242]) by mail.messagingengine.com (Postfix) with ESMTPA id 9C6FB108005B; Sat, 12 Dec 2020 12:36:10 -0500 (EST) Received: from localhost (tanuki [10.192.0.23]) by vm-mail.pks.im (OpenSMTPD) with ESMTPSA id 5fa21c75 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 12 Dec 2020 17:36:06 +0000 (UTC) Date: Sat, 12 Dec 2020 18:36:58 +0100 From: Patrick Steinhardt To: Daniel Kiper Cc: grub-devel@gnu.org, Glenn Washburn Subject: Re: [PATCH v8 00/18] Cryptodisk fixes for v2.06 redux Message-ID: References: <20201210162059.g67tnm2rv3wdj7gz@tomti.i.net-space.pl> <20201212144030.dmhq4qs3trtwqr73@tomti.i.net-space.pl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zwqtKSpEmch+zP+d" Content-Disposition: inline In-Reply-To: <20201212144030.dmhq4qs3trtwqr73@tomti.i.net-space.pl> Received-SPF: pass client-ip=64.147.123.19; envelope-from=ps@pks.im; helo=wout3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Dec 2020 18:31:06 -0000 --zwqtKSpEmch+zP+d Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Dec 12, 2020 at 03:40:30PM +0100, Daniel Kiper wrote: > On Sat, Dec 12, 2020 at 09:20:24AM +0100, Patrick Steinhardt wrote: > > On Thu, Dec 10, 2020 at 05:20:59PM +0100, Daniel Kiper wrote: > > > On Tue, Dec 08, 2020 at 04:45:31PM -0600, Glenn Washburn wrote: > > > > This patch series, fixes issues with v7 series. Some of those patch= es had > > > > changes applied to the wrong patch. The added structure member was = renamed > > > > again, this time to idx. And there is an added patch that renames s= ome json > > > > index variables to note that they are such. > > > > > > > > Glenn > > > > > > > > Glenn Washburn (18): > > > > disk: Rename grub_disk_get_size to grub_disk_native_sectors > > > > misc: Add parentheses around ALIGN_UP and ALIGN_DOWN arguments > > > > whitespace: convert 8 spaces to tabs > > > > luks2: Remove unused argument in grub_error > > > > luks2: Make sure all fields of output argument in luks2_parse_dig= est() > > > > are written to > > > > luks2: Add idx member to struct grub_luks2_keyslot/segment/digest > > > > luks2: Use more intuitive object name instead of json index in us= er > > > > messages > > > > luks2: Rename json index variables to names that they are obvious= ly > > > > json indexes > > > > luks2: Add string "index" to user strings using a json index. > > > > cryptodisk: Add macro GRUB_TYPE_BITS() to replace some literals > > > > cryptodisk: Add macros GRUB_TYPE_U_MAX/MIN(type) to replace liter= als > > > > luks2: grub_cryptodisk_t->total_sectors is the max number of devi= ce > > > > native sectors > > > > cryptodisk: Properly handle non-512 byte sized sectors > > > > luks2: Better error handling when setting up the cryptodisk > > > > luks2: Error check segment.sector_size > > > > mips: Enable __clzdi2() > > > > misc: Add grub_log2ull macro for calculating log base 2 of 64-bit > > > > integers > > > > luks2: Use grub_log2ull to calculate log_sector_size and improve > > > > readability > > > > > > I will get all the patches except #14 and maybe some changes after th= at > > > one which does not apply due to lack of it. >=20 > Thanks! However, I have pushed some of these patches before you did revie= w. >=20 > Daniel I thought as much, though I didn't check. I don't really mind, thought it might make sense to send them out in any case. Patrick --zwqtKSpEmch+zP+d Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF9hrgiFbCdvenl/rVbJhu7ckPpQFAl/U/7kACgkQVbJhu7ck PpRq2g//XRN1sCBZu7EOXc/7S2okSCWUCZJ36XYq03ZEIa2IMuIvdGgyz9Ira2bZ 30WWIFZgiZJAYWBJbQ0eLDonS8VOZpXxYzCqJ2GcKs+dXtdPcxQGcaD0oeVpihCQ d1XzMSnYriS4g1q/pfZQglcXYmBGQwIAjy7xCTnTbfvavW7YSlqrbnQnF0ZPrbzg onH0ZECij8e1Ib2AAGYB1MG5jpYfxVAocedlvv+8dwsDSQBj3Ch5TVtekau1if4s hICPwG/MCq6KxsiEgeGThuoAbjRzgKBABmrOyUR2eddgkVz2ScSqebvRxRvP9ahx XEQF8gCpkZghwQlCfYLfZGBGKB5+d38MZS1YbK1/KvGyzjNDbtZZBy/6iQoUKz8m RM2UwmqBSjJYh43ihbQUhSMiyIHPTfr+pE5C0ggjzwUT4ULAoQQt1np89AbItD8R vepCt1gJfjIV2vdHzgGNMrEZCca3ImmyeHbZBXk6Z6NTED6p2oMAY3UXQFJ4B12g FSzcL8qHwbIn9j5sa6eteUyVnKmxvcocjNirmfEoFtxLdzPjGk7zeiKwAmPpZ9mu hI24QkMjIOkgpzn8epkUa1mCyHApLCbeASYr0fWqpYKGD5WJx1fcnUZ2iHaD7edG j9JLaNLKfPTcGhpu8boUkgzQ/WrZfRN10BSm3vU0IBKp0vWsEno= =pBuu -----END PGP SIGNATURE----- --zwqtKSpEmch+zP+d--