Re: [oe-core][PATCH] connman: add PACKAGECONFIG to support iwd

[Markus Volk <f_l_k@t-online.de>]

[-- Attachment #1: Type: text/plain, Size: 1998 bytes --]

thats true. I'll add it as runtime dependency then

Am Mi, 24. Aug 2022 um 14:09:52 +0200 schrieb Quentin Schulz 
<quentin.schulz@theobroma-systems.com>:
> Hi all,
> 
> On 8/24/22 11:51, Luca Ceresoli via lists.openembedded.org wrote:
>> Hello Markus,
>> 
>> On Wed, 24 Aug 2022 10:56:54 +0200
>> "Markus Volk" <f_l_k@t-online.de <mailto:f_l_k@t-online.de>> wrote:
>> 
>>> Hello Luca,
>>> 
>>> Am Mi, 24. Aug 2022 um 10:54:40 +0200 schrieb Luca Ceresoli
>>> <luca.ceresoli@bootlin.com <mailto:luca.ceresoli@bootlin.com>>:
>>>> I would think iwd should be an rdepends, not an rrecommends. Any 
>>>> reson
>>>> for that? Or is it just an unintended extra ','?
>>> 
>>> Only reason for this was the fact, that iwd is not in oe-core so it
>>> felt wrong somehow to set it RDEPEND
>> 
>> I see, that's fine, but I wonder whether this should be clarified in 
>> a
>> comment. I'll be taking the patch for testing as is anyway.
>> 
> 
> IIRC the policy is to have a default configuration working. It is 
> fine to have PACKAGECONFIG options with dependencies on 
> recipes/packages not in the same layer.
> 
> Here, if someone builds with NO_RECOMMENDATIONS to have a minimal 
> setup but have iwd as WIRELESS_DAEMON, connman won't work because the 
> package won't be added to the image, it'll be a bit harder to debug 
> than a build failing because iwd recipe could not be found 
> (especially since I also didn't notice the additional comma).
> 
> Cheers,
> Quentin
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#169809): 
> <https://lists.openembedded.org/g/openembedded-core/message/169809>
> Mute This Topic: <https://lists.openembedded.org/mt/93208331/3618223>
> Group Owner: openembedded-core+owner@lists.openembedded.org 
> <mailto:openembedded-core+owner@lists.openembedded.org>
> Unsubscribe: 
> <https://lists.openembedded.org/g/openembedded-core/unsub> 
> [f_l_k@t-online.de <mailto:f_l_k@t-online.de>]
> -=-=-=-=-=-=-=-=-=-=-=-
> 


[-- Attachment #2: Type: text/html, Size: 2462 bytes --]