All of lore.kernel.org
 help / color / mirror / Atom feed
From: Giuliano Pochini <pochini@shiny.it>
To: alsa-devel@lists.sourceforge.net
Subject: [PATCH] AWACS driver, missing macro
Date: Tue, 24 Aug 2004 14:45:47 +0200 (CEST)	[thread overview]
Message-ID: <XFMail.20040824144547.pochini@shiny.it> (raw)


(Sorry if you already received this message, but all mail I
send to alsa-devel from my ISP's smtp server bounces. I'm
sending this through the server at work)



In the pmac AWACS driver of ALSA-1.0.6a there are two references to
num_controls():

[Giu@Jay ppc]$ grep num_controls *
awacs.c:                err = build_mixers(chip, num_controls(snd_pmac_screamer_mixers2),
awacs.c:                err = build_mixers(chip, num_controls(snd_pmac_awacs_mixers2),

But it is not defined anywhere. The following patch restores that macro that
I took from ALSA 1.0.5a. It looks fine here, too.  Tested ok (dual G4-MDD
with Snapper audio).



--- alsa-kernel/ppc/awacs.c_orig      Mon Aug  2 12:06:38 2004
+++ alsa-kernel/ppc/awacs.c     Tue Aug 17 15:46:24 2004
@@ -45,6 +45,8 @@
 
 #endif /* PMAC_AMP_AVAIL */
 
+#define num_controls(ary) (sizeof(ary) / sizeof(snd_kcontrol_new_t))
+
 
 static void snd_pmac_screamer_wait(pmac_t *chip)
 {




--
Giuliano.


-------------------------------------------------------
SF.Net email is sponsored by Shop4tech.com-Lowest price on Blank Media
100pk Sonic DVD-R 4x for only $29 -100pk Sonic DVD+R for only $33
Save 50% off Retail on Ink & Toner - Free Shipping and Free Gift.
http://www.shop4tech.com/z/Inkjet_Cartridges/9_108_r285

             reply	other threads:[~2004-08-24 12:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-24 12:45 Giuliano Pochini [this message]
2004-08-24 12:58 ` [PATCH] AWACS driver, missing macro Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=XFMail.20040824144547.pochini@shiny.it \
    --to=pochini@shiny.it \
    --cc=alsa-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.