Re: [PATCH] Improve SELinux performance when AVC misses.

[James Morris <jmorris@namei.org>]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1792 bytes --]

On Sat, 29 Sep 2007, KaiGai Kohei wrote:

> Stephen Smalley wrote:
> > On Fri, 2007-09-28 at 19:56 +0900, KaiGai Kohei wrote:
> >> James Morris wrote:
> >>>> ++			struct ebitmap_node *_n;
> >>>> ++			_n = kzalloc(sizeof(*_n), GFP_KERNEL);
> >>> Leading underscores are usually used to indicate that core code is not 
> >>> supposed to use the symbol.  Please change it to not have a leading 
> >>> underscore.  'tmp' or 'n2' is probably ok.
> >> OK, I replaced all of '_n' by 'tmp'.
> >> Rest of the part in the following patch is same as the previous one.
> > 
> > Seems to be damaged, or at least doesn't apply for me.  What is it
> > relative to?
> 
> I generated the patch against to the latest of James's git tree
> But it seems to me that all tab chatacters are translated into
> four white spaces, when I copied and pasted the patch.
> I'm sorry, it was my misoperation.
> 
> Can you receive it with tab kept in this time?

Yes, but there are compiler warnings on 64-bit.

Please test it on a 64-bit machine.

$ make -j3 SUBDIRS=security
  CC      security/selinux/ss/ebitmap.o
  CC      security/selinux/ss/sidtab.o
  CC      security/selinux/ss/avtab.o
security/selinux/ss/ebitmap.c: In function ‘ebitmap_netlbl_import’:
security/selinux/ss/ebitmap.c:196: warning: right shift count >= width of type
security/selinux/ss/ebitmap.c: In function ‘ebitmap_read’:
security/selinux/ss/ebitmap.c:393: warning: format ‘%Zd’ expects type ‘signed size_t’, but argument 3 has type ‘u32’
security/selinux/ss/ebitmap.c:399: warning: format ‘%Zd’ expects type ‘signed size_t’, but argument 3 has type ‘u32’
security/selinux/ss/ebitmap.c:437: warning: right shift count >= width of type


-- 
James Morris
<jmorris@namei.org>