From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0C6DC64ED6 for ; Mon, 27 Feb 2023 22:20:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229949AbjB0WUi (ORCPT ); Mon, 27 Feb 2023 17:20:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229491AbjB0WUh (ORCPT ); Mon, 27 Feb 2023 17:20:37 -0500 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C36C29E22; Mon, 27 Feb 2023 14:20:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677536432; x=1709072432; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=cWzJuDCIfMNelei3Vs40367kYpKfkSaH7kj9hcULpyU=; b=Uc7xo9k3u6Y2Kanm1j0OihtQOgFiGIFQtHEWFWYU6E/t9C7bNi8jLvhN W8yjoznpzQUm8ksxlTv/ZVXpdwIOR6fT06iL8FQTXDVa30JhRB8mvtAV+ LXxAapOBDiKYIg944FeuhjQJnoQnnJJ5RaCk58DMSC/kvy6/bZpZW33Dc ReO4AMFgG8CRF1ZpMTfIH7Exe2NVUqqLWXIQiardIUcyX9oFqmUTlUn0N YUvkIwIiKqUsGNqEQX/lH70gGr+XbrxGxhPRYD0+i5z40k9FU78M2Vvb0 T4RaIl35qTHhwjk62tneidVrCE7rwmDincw/JopIuEFfnI30YjfQ6yVBN w==; X-IronPort-AV: E=McAfee;i="6500,9779,10634"; a="317781596" X-IronPort-AV: E=Sophos;i="5.98,220,1673942400"; d="scan'208";a="317781596" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2023 14:20:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10634"; a="673898060" X-IronPort-AV: E=Sophos;i="5.98,220,1673942400"; d="scan'208";a="673898060" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga002.jf.intel.com with ESMTP; 27 Feb 2023 14:20:14 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pWlqv-00D1T5-01; Tue, 28 Feb 2023 00:20:13 +0200 Date: Tue, 28 Feb 2023 00:20:12 +0200 From: Andy Shevchenko To: Linus Walleij Cc: Claudiu.Beznea@microchip.com, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Ludovic.Desroches@microchip.com, Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com Subject: Re: [PATCH v3 5/5] pinctrl: at91: Utilise temporary variable for struct device Message-ID: References: <20230215134242.37618-1-andriy.shevchenko@linux.intel.com> <20230215134242.37618-6-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Feb 27, 2023 at 10:44:21PM +0100, Linus Walleij wrote: > On Fri, Feb 17, 2023 at 12:59 PM Andy Shevchenko > wrote: > > On Fri, Feb 17, 2023 at 11:54:02AM +0000, Claudiu.Beznea@microchip.com wrote: > > > On 15.02.2023 15:42, Andy Shevchenko wrote: ... > > > > girq->num_parents = 1; > > > > - girq->parents = devm_kcalloc(&pdev->dev, 1, > > > > + girq->parents = devm_kcalloc(dev, girq->num_parents, > > > > > > There is still the change of the 2nd argument of devm_kcalloc() from 1 -> > > > girq->num_parents (no functional change, though) which doesn't match the > > > purpose of the patch and is not specified anywhere. Other than this: > > > > > > Reviewed-by: Claudiu Beznea > > > > > > > sizeof(*girq->parents), > > > > GFP_KERNEL); > > n > > Thanks for review. I have no time to fix this. So if Linus is okay to take > > the first 4 patches, I'm fine. You or somebody else can submit an updated > > 5th patch later on. > > I applied all 5 patches. The num_parents is set to 1 on the line right > above and it's the right thing to do, and has a reviewed tag so I don't > see the problem with this patch, let's not overinvest in process. > > Thanks for the very nice cleanups! Thank you! > I applied it locally so it won't be in linux-next until after the merge > window closes. -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A7D5C64ED6 for ; Mon, 27 Feb 2023 22:21:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FTdJfbODO5KA05x0KyFwGKHjPzRutGxvT/4097FV35Q=; b=BYZ6d0gTYwCDWp n5WJ14BmHo0D0jnQIFS2C2vh5oigPmQK2LVZqK+IVSs7udxH8pX6tjpjTvZxjtWp0ZnD6NZZ8m4+F XNpCeKuuR77TnxBauo+pO+2JzLejhH1fklsqZrCI+J/4gPaalRleeIxiUSEorggyrouTsySo1716a /nIVfuEz/Wi/tmwJafoCPZ9LNDHH7ZF0pqMKpqKoiVh+snhCvy6CN+9jPixl7H9RKewOui2cmtJUR Qphhk3zdn0U5w192t1/6U2MUFX9LZfPAOe+fG+Ny/yqqeFX28HWUzEFtW4KPH4pW4fXzZ++asecIm Kx/mIryrZ30ChjmkSQeQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWlrI-00BQAx-Ss; Mon, 27 Feb 2023 22:20:36 +0000 Received: from mga18.intel.com ([134.134.136.126]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pWlrG-00BQ95-CE for linux-arm-kernel@lists.infradead.org; Mon, 27 Feb 2023 22:20:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677536434; x=1709072434; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=cWzJuDCIfMNelei3Vs40367kYpKfkSaH7kj9hcULpyU=; b=nCfAjFr6x6Alr5fhwXCyYJbtM34nkxAmnpgp7xrq5/76nbffLfDcSjMf hCPbRAnHL971JGA0lJNVCTvvi5oLObV2JA5cjbs0cAi2hdTfZ667TcFgG d9pYn9SiyhkWAH8YnvTQYMoulJDxr/aRg57AhGkpl3tuCha4v2bFQkxlW /ukZGeO5HmPQyIauwktyZppev7SNKtQnnyAex0w5sQT/Rs4PQw796wKLk 2pYWFyTBYMOyGK0tPK2br2IsW7xHEP4ybBj1m4yXM6QWbtH1oEKd+Hhqp LXhC23ESBu7RoGceco1oQPuZgkzeiivl+vFrXj94v+lPbeS9DitxEKai6 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10634"; a="317781597" X-IronPort-AV: E=Sophos;i="5.98,220,1673942400"; d="scan'208";a="317781597" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Feb 2023 14:20:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10634"; a="673898060" X-IronPort-AV: E=Sophos;i="5.98,220,1673942400"; d="scan'208";a="673898060" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga002.jf.intel.com with ESMTP; 27 Feb 2023 14:20:14 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1pWlqv-00D1T5-01; Tue, 28 Feb 2023 00:20:13 +0200 Date: Tue, 28 Feb 2023 00:20:12 +0200 From: Andy Shevchenko To: Linus Walleij Subject: Re: [PATCH v3 5/5] pinctrl: at91: Utilise temporary variable for struct device Message-ID: References: <20230215134242.37618-1-andriy.shevchenko@linux.intel.com> <20230215134242.37618-6-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230227_142034_511423_88AF5020 X-CRM114-Status: GOOD ( 25.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Ludovic.Desroches@microchip.com, Claudiu.Beznea@microchip.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 27, 2023 at 10:44:21PM +0100, Linus Walleij wrote: > On Fri, Feb 17, 2023 at 12:59 PM Andy Shevchenko > wrote: > > On Fri, Feb 17, 2023 at 11:54:02AM +0000, Claudiu.Beznea@microchip.com wrote: > > > On 15.02.2023 15:42, Andy Shevchenko wrote: ... > > > > girq->num_parents = 1; > > > > - girq->parents = devm_kcalloc(&pdev->dev, 1, > > > > + girq->parents = devm_kcalloc(dev, girq->num_parents, > > > > > > There is still the change of the 2nd argument of devm_kcalloc() from 1 -> > > > girq->num_parents (no functional change, though) which doesn't match the > > > purpose of the patch and is not specified anywhere. Other than this: > > > > > > Reviewed-by: Claudiu Beznea > > > > > > > sizeof(*girq->parents), > > > > GFP_KERNEL); > > n > > Thanks for review. I have no time to fix this. So if Linus is okay to take > > the first 4 patches, I'm fine. You or somebody else can submit an updated > > 5th patch later on. > > I applied all 5 patches. The num_parents is set to 1 on the line right > above and it's the right thing to do, and has a reviewed tag so I don't > see the problem with this patch, let's not overinvest in process. > > Thanks for the very nice cleanups! Thank you! > I applied it locally so it won't be in linux-next until after the merge > window closes. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel