From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mehdi Djait <mehdi.djait.k@gmail.com>
Cc: jic23@kernel.org, lars@metafoo.de, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] iio: Improve the kernel-doc of iio_trigger_poll
Date: Tue, 28 Feb 2023 00:50:06 +0200 [thread overview]
Message-ID: <Y/0znth++tPsptKs@smile.fi.intel.com> (raw)
In-Reply-To: <219496d4d21755937a40c2c7dfbeca64660c9258.1677520155.git.mehdi.djait.k@gmail.com>
On Mon, Feb 27, 2023 at 07:00:38PM +0100, Mehdi Djait wrote:
> Move the kernel-doc of the function to industrialio-trigger.c
> Add a note on the context where the function is expected to be called.
...
> + * This function needs to be called from an interrupt context.
> - * Typically called in relevant hardware interrupt handler.
These are not equivalent. Can you explain in the commit message why we move
from hardware to any interrupt context?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-02-27 22:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 18:00 [PATCH 0/2] iio: Add kernel-doc and rename Mehdi Djait
2023-02-27 18:00 ` [PATCH 1/2] iio: Improve the kernel-doc of iio_trigger_poll Mehdi Djait
2023-02-27 22:50 ` Andy Shevchenko [this message]
2023-02-28 19:16 ` Mehdi Djait
2023-02-27 18:00 ` [PATCH 2/2] iio: Rename iio_trigger_poll_chained and add kernel-doc Mehdi Djait
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/0znth++tPsptKs@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mehdi.djait.k@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.