From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Erico Nunes <ernunes@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH] ui/sdl2: remove workaround forcing x11
Date: Wed, 1 Mar 2023 14:41:54 +0000 [thread overview]
Message-ID: <Y/9kMobasTih1xe7@redhat.com> (raw)
In-Reply-To: <20230301141205.514338-1-ernunes@redhat.com>
On Wed, Mar 01, 2023 at 03:12:05PM +0100, Erico Nunes wrote:
> This workaround was put in place in the original implementation almost
> 10 years ago, considering a very old SDL2 version. Currently it prevents
> users to run in a wayland-only environment without manually forcing the
> backend.
> The SDL2 wayland backend has been supported by distributions for a very
> long time (e.g. in Fedora, first available 8 years ago), and is now
> considered stable and becoming the default for new SDL2 releases.
> Instead of requiring the x11 backend to exist by default, let new qemu
> releases run with the default chosen by the installed SDL2 version.
As the comment says, it is better fixed elsewhere anyway rather
than hardcoding in QEMU
>
> Signed-off-by: Erico Nunes <ernunes@redhat.com>
> ---
> ui/sdl2.c | 16 ----------------
> 1 file changed, 16 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2023-03-01 14:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 14:12 [PATCH] ui/sdl2: remove workaround forcing x11 Erico Nunes
2023-03-01 14:41 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/9kMobasTih1xe7@redhat.com \
--to=berrange@redhat.com \
--cc=ernunes@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.