From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B560C7EE32 for ; Wed, 1 Mar 2023 15:33:19 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 61BEC85B42; Wed, 1 Mar 2023 16:33:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="PYHpmiA1"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7F11585B46; Wed, 1 Mar 2023 16:33:14 +0100 (CET) Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8C25785B39 for ; Wed, 1 Mar 2023 16:33:11 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x829.google.com with SMTP id w23so14639330qtn.6 for ; Wed, 01 Mar 2023 07:33:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1677684790; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ar9s3dz2X28Z9kFUxw5/4W8niYr50Zggfp5FIPrVydM=; b=PYHpmiA1g6rpuJEC41DnIIag3PE1E/J/Zf/7BivRBUIG2q2sXzdddIjBIrVxADAdpC ltFjUH7Dg17eL5Q85CtS52crHHNMSGrqQjDfeXJcJgDeQyN7w6Jz2beHymav1cUlFId6 35HKjwIh65HOQn7e/0g3E8l3J1WzD/SogDp24= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677684790; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ar9s3dz2X28Z9kFUxw5/4W8niYr50Zggfp5FIPrVydM=; b=kFU4wS/BijkEU407PZNaF2hRCwXvTYF6FxhbbEaEXPJXrpKKprXvSPWLUHCte8Q8Ai tdsSMBE7hPLBYCQazm1as4zLh/mPRIX6Inu7O04hh/Nm5qATILG66s3f/eeOgZ0J/pET xGLliMwpgQkf2TRf70wKGiXpcIDDmxst7hH6St5b1pvFDKQuQSqhjd4/SxOv7JwVWXSW rnGNHW8kZ22pM9WvAZinmcwXiqJmHFFI4uMTPQY4cEgqbQLdZohsV+HgHZHW46hL0JR5 iuel0PwkJFtAG7eZoEYXt1cXtmnR3MMu2GcZh7hVcqzNepMg7eG+t6Ai5xdKPtp6KwXr 3dCw== X-Gm-Message-State: AO0yUKWNBhTsZIICB5BTfIlWVw+h1DzsUJRxzPzeNh49M0Tv40PEfarE DgVZkGN46hr7uGfjy32OZCzpVA== X-Google-Smtp-Source: AK7set9GoAoet4gHEcZxhKjZq2BBjV+OvfhdXXkM+OoiJ98q1Bx8i5I+6l0roTUZmbDoLYi51b1VUQ== X-Received: by 2002:a05:622a:1485:b0:3bf:bc48:b0bd with SMTP id t5-20020a05622a148500b003bfbc48b0bdmr11592029qtx.63.1677684790158; Wed, 01 Mar 2023 07:33:10 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-0000-0000-0000-036b.res6.spectrum.com. [2603:6081:7b00:6400::36b]) by smtp.gmail.com with ESMTPSA id g3-20020ac84803000000b003be56bdd3b1sm8374962qtq.92.2023.03.01.07.33.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Mar 2023 07:33:09 -0800 (PST) Date: Wed, 1 Mar 2023 10:33:07 -0500 From: Tom Rini To: Troy Kisky Cc: sjg@chromium.org, u-boot@lists.denx.de, gary.bisson@lairdconnect.com, Marek =?iso-8859-1?Q?Beh=FAn?= , Samuel Dionne-Riel Subject: Re: [PATCH v2 02/26] cmd: nvedit: check for ENV_SUPPORT Message-ID: References: <20230224181047.2775829-1-troykiskyboundary@gmail.com> <20230224181047.2775829-3-troykiskyboundary@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="TLoKJoR1ggzdrvR+" Content-Disposition: inline In-Reply-To: <20230224181047.2775829-3-troykiskyboundary@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --TLoKJoR1ggzdrvR+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 24, 2023 at 10:10:23AM -0800, Troy Kisky wrote: > Avoid error messages when SPL,TPL,VPL build don't > have the environment options of the main build. > This is needed when defined(CONFIG_ENV_IS_IN_xxx) is changed > to CONFIG_IS_ENABLED(ENV_IS_IN_xxx). >=20 > Signed-off-by: Troy Kisky > Reviewed-by: Simon Glass > --- >=20 > (no changes since v1) >=20 > cmd/nvedit.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/cmd/nvedit.c b/cmd/nvedit.c > index 7cbc3fd573a..ef0fe55431c 100644 > --- a/cmd/nvedit.c > +++ b/cmd/nvedit.c > @@ -43,6 +43,7 @@ > =20 > DECLARE_GLOBAL_DATA_PTR; > =20 > +#if CONFIG_IS_ENABLED(ENV_SUPPORT) > #if defined(CONFIG_ENV_IS_IN_EEPROM) || \ > defined(CONFIG_ENV_IS_IN_FLASH) || \ > defined(CONFIG_ENV_IS_IN_MMC) || \ > @@ -60,10 +61,12 @@ DECLARE_GLOBAL_DATA_PTR; > #endif > =20 > #if !defined(ENV_IS_IN_DEVICE) && \ > - !defined(CONFIG_ENV_IS_NOWHERE) > + !defined(CONFIG_ENV_IS_NOWHERE) && \ > + !defined(CONFIG_VPL_BUILD) > # error Define one of CONFIG_ENV_IS_IN_{EEPROM|FLASH|MMC|FAT|EXT4|\ > NAND|NVRAM|ONENAND|SATA|SPI_FLASH|REMOTE|UBI} or CONFIG_ENV_IS_NOWHERE > #endif > +#endif This is one of the #error messes that we no longer need with Kconfig, where we can ensure things happen. Maybe we can use def_bool y if .. instead of default y if ..., in the ENV_IS_NOWHERE choice ? --=20 Tom --TLoKJoR1ggzdrvR+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmP/cC0ACgkQFHw5/5Y0 tywoZQv/cN53B1iRIUpKmtU97amOnFY7NhcHqqKEmz830Xr1iCWuZzOfHLTZ0/B5 NlDg9Ad9jWIEp4xxzE852kS2TW+IVJ+MT9MrCj8BJ2RihU8kMqvrqTjVnE4dW+a8 Mv5yQxrNE8wmYfHcldndifN0miLTe3e65ggjXCxuL/npvx6K9NFpxYhRXaJKIoxD 75s92EGj4w0EvrvaX1+AlCwL46m582EvoxTfAlU/XKndsyC94FVde3+NeuJQD/Od ozhfMMflxC17GyI7K1iieKfY5rEtN6u+e5KUvL0e8Y09+0T91qoad7b5YUbCF5cj Z8ap1gYmuVT3b5afSh1rkmPBC8LrVLHY09YXfDkM6jkEaHeWmAIf5DM6SoG5Mhf8 s9osCQc2wizGxKGLLA05sbwYYf8Nm+qnwyuf6DyjuG0eYi3HLYx+uPVH4+2lmL6L ZrWGQQ/pkMS0kZ+c1z4OU2hNnKYqCinwN5+zioAwsjrDYyY5Sf30li7wqkRxEs3Q oKhD6qUp =dQdi -----END PGP SIGNATURE----- --TLoKJoR1ggzdrvR+--