From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C463BC6FA9D for ; Wed, 1 Mar 2023 15:33:37 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8AC7F85C26; Wed, 1 Mar 2023 16:33:25 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="f6ruwqJw"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 49C2685B3D; Wed, 1 Mar 2023 16:33:21 +0100 (CET) Received: from mail-yw1-x112e.google.com (mail-yw1-x112e.google.com [IPv6:2607:f8b0:4864:20::112e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8F16485B46 for ; Wed, 1 Mar 2023 16:33:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x112e.google.com with SMTP id 00721157ae682-536be69eadfso371486007b3.1 for ; Wed, 01 Mar 2023 07:33:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1677684795; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=J0l8jMpcJsccAOfIhckoriSIc7fwmPdgb0hURgM14l8=; b=f6ruwqJwevh4gxlsGOgQ+tQcmU63H2pI5pSKk85z0R5mVrV2e0BlzTzRrQAv2BxcVJ RInZC+vUixELqIvkYmrGyY0VQsoiLTKMsQsxt+di+K+vET2WmmIkAIrJP6NAlf80IMrB wZtwAJCif+UvS69t6esTiXHR6hsl6HZAvnBCk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677684795; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=J0l8jMpcJsccAOfIhckoriSIc7fwmPdgb0hURgM14l8=; b=nlwUzNdGsrXxPJwAVyMcYuwmR5bfhituNUyG9Qlrv2t8B8wxsyvzw0fNamiwvHoV6i 8kCrvMn79b1NNuUQz6uc57tA8/+05+NSEYMN8Kp6s9GSOkX95rocrAv6GEby/dFMV054 IU1o+J0ZMXH1NfYCyoE/Zc3cPI1b1qGaYC2ntUsS0beWN7RPl0EHTl1UDm6fuhQjDymd JNwe5Jic4eDkchxNvXVw7D7bGxpTJfPTpIeyNMNwpRrtYNMbXmOZYpiSIc4OmAX+MMS2 3PKBvuEWti8malR7zCCqiT2wYzaiZt91kAxpyKoJPwisYxCW0huQbrNc8Tqv/CzoZGbF I4pA== X-Gm-Message-State: AO0yUKULf6KffGmw7n5mBvEuE2yaUMIW78LBS8wirlpMmQ5vprjU+aeh /2Zl/D6Xi/VpKBHmsePwIb3rsg== X-Google-Smtp-Source: AK7set/sMxwGTbmTBql/asfcDi8hfnqWX4Epn/Wcc2BnfRiK4f8Jz2xMyOtK4a3OOpX49qXwaorIGw== X-Received: by 2002:a81:4f81:0:b0:53c:8a40:24d1 with SMTP id d123-20020a814f81000000b0053c8a4024d1mr561964ywb.0.1677684795318; Wed, 01 Mar 2023 07:33:15 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-0000-0000-0000-036b.res6.spectrum.com. [2603:6081:7b00:6400::36b]) by smtp.gmail.com with ESMTPSA id m184-20020a3758c1000000b0073ba44fd6a2sm8230069qkb.1.2023.03.01.07.33.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Mar 2023 07:33:14 -0800 (PST) Date: Wed, 1 Mar 2023 10:33:12 -0500 From: Tom Rini To: Troy Kisky Cc: sjg@chromium.org, u-boot@lists.denx.de, gary.bisson@lairdconnect.com, Marek Vasut , Stefan Roese Subject: Re: [PATCH v2 03/26] lib: crc32: prepare for CONFIG_IS_ENABLED changes Message-ID: References: <20230224181047.2775829-1-troykiskyboundary@gmail.com> <20230224181047.2775829-4-troykiskyboundary@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="EHzS2bb3Jiek2lnV" Content-Disposition: inline In-Reply-To: <20230224181047.2775829-4-troykiskyboundary@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --EHzS2bb3Jiek2lnV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 24, 2023 at 10:10:24AM -0800, Troy Kisky wrote: > We need to include in order to include > files that use CONFIG_IS_ENABLED. TO prepare for that > be more direct with using defined(USE_HOSTCC). >=20 > Signed-off-by: Troy Kisky > Reviewed-by: Simon Glass > --- >=20 > Changes in v2: > - delay include of linux/kconfig.h to do from Makefile > - as suggested by Simon >=20 > lib/crc32.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) >=20 > diff --git a/lib/crc32.c b/lib/crc32.c > index aa94d70ef3e..12c104c62a4 100644 > --- a/lib/crc32.c > +++ b/lib/crc32.c > @@ -14,11 +14,14 @@ > #else > #include > #include > +#if defined(CONFIG_HW_WATCHDOG) || defined(CONFIG_WATCHDOG) > +#define PET_WDG > +#endif Lets introduce a Kconfig symbol like HAS_WATCHDOG_RUNNING and then update all of the places we have this convention (there's a few this series doesn't touch). --=20 Tom --EHzS2bb3Jiek2lnV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmP/cDgACgkQFHw5/5Y0 tyyZNAwAqMPtfn9+oybztg4ekXcndkwdAVz73DpK2/i3Kno1rW8MCRceC1+buhDQ CXN6rR3X9aU3GZF6M1emGnBkxSMOuUa3ZhvjT5Jq+12dcgzIIc3l5p06+KWJ16rE wsfl70LdAYddnWs3WTTAJZlmn/DE4gtfikFwkW/WatOvTEFD3gsNsNG7UUQkMqKq JPt8bysQPQpuIeTP8VmKjjZ4ElR9VlmhAsBNVUtmyVzr9R1GWdGsxNFWswz0HfmZ kCdLR9ym8dWY7SABAjpi5f2YcGypxclv4QpMJo0dTXN3lXMlQ49dAqlrdan+zUcd GTymVDDmgU6WkZyoGBMVVn7SPVKgab2PUVM9lqNSqc8z1iL6kXKneb1QvInMVhww kQ3+okbsvXsfWrUfj22NgpmAT9STDrzv2A7+HwcUDVm5ZosIiQNu1Ne1y/1aDQdb vyoesFtiNKzl7w5DisNyWLWFXFYBiQGOl2ARvmcp3dfuiYm+h/YDz7AMyH7YaZY1 C49kXwf+ =OTM3 -----END PGP SIGNATURE----- --EHzS2bb3Jiek2lnV--