From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47341C64ED6 for ; Wed, 1 Mar 2023 15:34:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 77BD085C50; Wed, 1 Mar 2023 16:34:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="HntdcNir"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AA85785C10; Wed, 1 Mar 2023 16:33:46 +0100 (CET) Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3EAC685B93 for ; Wed, 1 Mar 2023 16:33:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf2e.google.com with SMTP id ne1so9485799qvb.9 for ; Wed, 01 Mar 2023 07:33:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1677684818; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BFEBgW0UpgPjasiwFYq8/ybgs1ovpbDM7n+/siu4dhc=; b=HntdcNirG8Tux6bofPf3jCed/nscQrw5p2GnrLmNjOYm6D7+e36gGuIbPyKjZqjzlm zoN7J8HGnEbayzwSEHr+tHsiPWBGkp2LLfsGLQ/NqStymgymoO2xRD4LmDWdF3njmP1Y R7LxSA0dEGWkHEKPWuG/znuXg/yfkrVXUPlh8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677684818; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BFEBgW0UpgPjasiwFYq8/ybgs1ovpbDM7n+/siu4dhc=; b=SPrqnVqO51l4zsmd9F7qFrHrEXShvJXPa4eQLSTxfRA/ef052r6XW9vbemyX6krqUo u/HT4Kac5rlJjv53f7dorUVpmZK0k+CQQ2dFF3o4mk4kekcQzY0VRDPqplLxd/MhJyCj stkLu6yJm5M9c3Fgr6SsNn5733CLNpaI7OUhIkYOBwqE8xNn43v6i+fIw1cITLuIQlTD w+p62SY1sgYx6l7VDD2itpKHOqesON+ECVGuI7pKypJBZqnxZHSUFgNmrX/JnxFqy/Sg 9VupBKQUarZD+zCZGjXGcxtgdAhBQMRRyw5Gw/8m1IRD0LaZaq2o2QewHSbLLI1BV2Fw QFcw== X-Gm-Message-State: AO0yUKUk/zNWrRD4qGz6unSwuEHc5YUilpoqT037rks9unoJgOoIS7yd nMz5HpASPmROltn80j2VTvkoPA== X-Google-Smtp-Source: AK7set9oRf5CsoOA2MXzO3+Eyds4yjdL2+to6OwbWzw2eFJs2BYyisd5gsSDsXKeO8okPnEzpXRs6g== X-Received: by 2002:a05:6214:2589:b0:56b:7cb:bdcd with SMTP id fq9-20020a056214258900b0056b07cbbdcdmr14812958qvb.39.1677684818251; Wed, 01 Mar 2023 07:33:38 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-0000-0000-0000-036b.res6.spectrum.com. [2603:6081:7b00:6400::36b]) by smtp.gmail.com with ESMTPSA id c75-20020ae9ed4e000000b00738e8e81dc9sm8964863qkg.75.2023.03.01.07.33.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Mar 2023 07:33:37 -0800 (PST) Date: Wed, 1 Mar 2023 10:33:36 -0500 From: Tom Rini To: Troy Kisky Cc: sjg@chromium.org, u-boot@lists.denx.de, gary.bisson@lairdconnect.com, Klaus Goger , Quentin Schulz Subject: Re: [PATCH v2 14/26] puma-rk3399: use IS_ENABLED_NOCHECK to avoid CI test failure for ENV_IS_NOWHERE Message-ID: References: <20230224181047.2775829-1-troykiskyboundary@gmail.com> <20230224181047.2775829-15-troykiskyboundary@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fBafDcdM8W5UpfF9" Content-Disposition: inline In-Reply-To: <20230224181047.2775829-15-troykiskyboundary@gmail.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --fBafDcdM8W5UpfF9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 24, 2023 at 10:10:35AM -0800, Troy Kisky wrote: > When usage_of_is_enabled_check.sh is added, this will show a false > positive for IS_ENABLED(CONFIG_ENV_IS_NOWHERE). > Use IS_ENABLED_NOCHECK to avoid check and error on SPL builds. >=20 > Signed-off-by: Troy Kisky > --- >=20 > Changes in v2: > - keep #error, but change condition to use IS_ENABLED_NOCHECK >=20 > board/theobroma-systems/puma_rk3399/puma-rk3399.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) As I said against v1, the platform needs to select ENV_IS_NOWHERE. --=20 Tom --fBafDcdM8W5UpfF9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmP/cE8ACgkQFHw5/5Y0 tyyVkgv+Nsl3fk4Ss9smXg21AkLZN4O3BqF2s1F9iUCoWNVrCkFOnHDO/mZ/tIzB m2iAdK09YMtVFmlXjGgc1e5Xtgc1GobivT/CiCPxFJaqLJkm1TLxCWC0gIeDPHnO wJ1DVRGgujxWOkCH3Ud2bGKCJm6MbqnRY/VZ/iYSUnnDQTGDmFo2XoVz9vYWBkjC EMZ7U2ulTqoaBDJRH2mt+vAEyID+arXtDVhANo29W0F1DHZvhe5vhWCG+1nNPtAN rsidy/CfkOS1JwwyHAC9zUfFk5hMBuwbOIgfk3DIvL6H2n6ddduPaJb++xSpJjl0 jHF9ip4sk5v5aTW222ZvTTzu3e98pEBOwTOEUEVur3JgLx8i58aqx2Sb/I3zaPr6 TBIAZOzKnV+yo9HwF8e3R5D/fGLIfv5BKVXm5nZQsh+dq1Zt7YbS+a8Gfudwxkuf dW75mUFk15fMXU7Xlc2GVmMuOUDgvuGWiqzDLqt7mOohnhnnas5Y7HK5iPBdVpEZ XqwpLEIY =Oe/l -----END PGP SIGNATURE----- --fBafDcdM8W5UpfF9--