From: Leon Romanovsky <leon@kernel.org>
To: Shannon Nelson <shannon.nelson@amd.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
drivers@pensando.io, brett.creeley@amd.com
Subject: Re: [PATCH v3 net-next 00/14] pds_core driver
Date: Sun, 19 Feb 2023 12:11:44 +0200 [thread overview]
Message-ID: <Y/H14ByDBPTA+yqg@unreal> (raw)
In-Reply-To: <20230217225558.19837-1-shannon.nelson@amd.com>
On Fri, Feb 17, 2023 at 02:55:44PM -0800, Shannon Nelson wrote:
> Summary:
> --------
> This patchset implements new driver for use with the AMD/Pensando
> Distributed Services Card (DSC), intended to provide core configuration
> services through the auxiliary_bus for VFio and vDPA feature specific
> drivers.
Hi,
I didn't look very deeply to this series, but three things caught my
attention and IMHO they need to be changed/redesinged before someone
can consider to merge it.
1. Use of bus_register_notifier to communicate between auxiliary devices.
This whole concept makes aux logic in this driver looks horrid. The idea
of auxiliary bus is separate existing device to sub-devices, while every
such sub-device is controlled through relevant subsystem. Current
implementation challenges this assumption by inventing own logic.
2. devm_* interfaces. It is bad. Please don't use them in such a complex
driver.
3. Listen to PCI BOUND_DRIVER event can't be correct either.
Thanks
next prev parent reply other threads:[~2023-02-19 10:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 22:55 [PATCH v3 net-next 00/14] pds_core driver Shannon Nelson
2023-02-17 22:55 ` [PATCH v3 net-next 01/14] devlink: add enable_migration parameter Shannon Nelson
2023-02-20 8:22 ` Jiri Pirko
2023-02-20 23:54 ` Shannon Nelson
2023-02-21 12:33 ` Jiri Pirko
2023-02-21 21:55 ` Shannon Nelson
2023-02-20 8:23 ` Jiri Pirko
2023-02-17 22:55 ` [PATCH v3 net-next 02/14] pds_core: initial framework for pds_core driver Shannon Nelson
2023-02-17 22:55 ` [PATCH v3 net-next 03/14] pds_core: add devcmd device interfaces Shannon Nelson
2023-02-17 22:55 ` [PATCH v3 net-next 04/14] pds_core: health timer and workqueue Shannon Nelson
2023-02-17 22:55 ` [PATCH v3 net-next 05/14] pds_core: set up device and adminq Shannon Nelson
2023-02-17 22:55 ` [PATCH v3 net-next 06/14] pds_core: Add adminq processing and commands Shannon Nelson
2023-02-17 22:55 ` [PATCH v3 net-next 07/14] pds_core: add FW update feature to devlink Shannon Nelson
2023-02-17 22:55 ` [PATCH v3 net-next 08/14] pds_core: set up the VIF definitions and defaults Shannon Nelson
2023-02-17 22:55 ` [PATCH v3 net-next 09/14] pds_core: initial VF configuration Shannon Nelson
2023-02-17 22:55 ` [PATCH v3 net-next 10/14] pds_core: add auxiliary_bus devices Shannon Nelson
2023-02-17 22:55 ` [PATCH v3 net-next 11/14] pds_core: devlink params for enabling VIF support Shannon Nelson
2023-02-17 22:55 ` [PATCH v3 net-next 12/14] pds_core: add the aux client API Shannon Nelson
2023-02-17 22:55 ` [PATCH v3 net-next 13/14] pds_core: publish events to the clients Shannon Nelson
2023-02-17 22:55 ` [PATCH v3 net-next 14/14] pds_core: Kconfig and pds_core.rst Shannon Nelson
2023-02-18 2:48 ` kernel test robot
2023-02-19 10:11 ` Leon Romanovsky [this message]
2023-02-20 23:53 ` [PATCH v3 net-next 00/14] pds_core driver Shannon Nelson
2023-02-21 6:53 ` Leon Romanovsky
2023-02-21 22:03 ` Shannon Nelson
2023-02-22 7:59 ` Leon Romanovsky
2023-02-25 22:57 ` Shannon Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/H14ByDBPTA+yqg@unreal \
--to=leon@kernel.org \
--cc=brett.creeley@amd.com \
--cc=davem@davemloft.net \
--cc=drivers@pensando.io \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.