From: Andrew Lunn <andrew@lunn.ch>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "Russell King (Oracle)" <linux@armlinux.org.uk>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v1 3/4] net: phy: do not force EEE support
Date: Mon, 20 Feb 2023 16:48:26 +0100 [thread overview]
Message-ID: <Y/OWSjQ0m65fF5dk@lunn.ch> (raw)
In-Reply-To: <20230220150720.GA19238@pengutronix.de>
> Hm.. ethtool do not provide enough information about expected behavior.
> Here is my expectation:
> - "ethtool --set-eee lan1 eee on" should enable EEE if it is disabled.
> - "ethtool --set-eee lan1 advertise 0x10" should change set of
> advertised modes.
> - a sequence of "..advertise 0x10", "..eee on", "eee off" should restore
> preconfigured advertise modes. advertising_eee instead of
> supported_eee.
I agree ethtool is not very well documented. However, i would follow
what -s does. You can pass link modes you want to advertise, and you
can turn auto-neg on and off. Does turning auto-neg off and on again
reset the links modes which are advertised? I don't actually know, but
i think the behaviour should be consistent for link modes and EEE
modes.
Andrew
next prev parent reply other threads:[~2023-02-20 15:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 13:56 [PATCH net-next v1 0/4] net: phy: EEE fixes Oleksij Rempel
2023-02-20 13:56 ` [PATCH net-next v1 1/4] net: phy: c45: use "supported_eee" instead of supported for access validation Oleksij Rempel
2023-02-20 14:09 ` Russell King (Oracle)
2023-02-20 13:56 ` [PATCH net-next v1 2/4] net: phy: c45: add genphy_c45_an_config_eee_aneg() function Oleksij Rempel
2023-02-20 14:10 ` Russell King (Oracle)
2023-02-20 13:56 ` [PATCH net-next v1 3/4] net: phy: do not force EEE support Oleksij Rempel
2023-02-20 14:18 ` Russell King (Oracle)
2023-02-20 15:08 ` Oleksij Rempel
2023-02-20 15:32 ` Andrew Lunn
2023-02-20 14:21 ` Russell King (Oracle)
2023-02-20 15:07 ` Oleksij Rempel
2023-02-20 15:48 ` Andrew Lunn [this message]
2023-02-20 16:13 ` Oleksij Rempel
2023-02-20 17:24 ` Russell King (Oracle)
2023-02-20 17:27 ` Russell King (Oracle)
2023-02-20 15:43 ` Andrew Lunn
2023-02-20 13:56 ` [PATCH net-next v1 4/4] net: phy: c45: genphy_c45_ethtool_set_eee: validate EEE link modes Oleksij Rempel
2023-02-20 15:34 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/OWSjQ0m65fF5dk@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.