From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Marc Zyngier <maz@kernel.org>
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
stable@vger.kernel.org
Subject: Re: [PATCH] genirq/msi: Take the per-device MSI lock before validating the control structure
Date: Mon, 20 Feb 2023 19:05:13 +0000 [thread overview]
Message-ID: <Y/PEac0U1uwRT3XG@shell.armlinux.org.uk> (raw)
In-Reply-To: <20230220190101.314446-1-maz@kernel.org>
On Mon, Feb 20, 2023 at 07:01:01PM +0000, Marc Zyngier wrote:
> Calling msi_ctrl_valid() ultimately results in calling
> msi_get_device_domain(), which requires holding the device MSI lock.
>
> However, we take that lock right after having called msi_ctrl_valid(),
> which is just a tad too late. Taking the lock earlier solves the issue.
>
> Fixes: 40742716f294 ("genirq/msi: Make msi_add_simple_msi_descs() device domain aware")
> Reported-by: "Russell King (Oracle)" <linux@armlinux.org.uk>
Tested-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
prev parent reply other threads:[~2023-02-20 19:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 19:01 [PATCH] genirq/msi: Take the per-device MSI lock before validating the control structure Marc Zyngier
2023-02-20 19:05 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/PEac0U1uwRT3XG@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.