From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Henning Schild <henning.schild@siemens.com>
Cc: Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Mark Gross <markgross@kernel.org>,
linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 1/3] leds: simatic-ipc-leds-gpio: move two extra gpio pins into another table
Date: Tue, 21 Feb 2023 15:45:06 +0200 [thread overview]
Message-ID: <Y/TK4tJZ5kmgsRNJ@smile.fi.intel.com> (raw)
In-Reply-To: <20230221122414.24874-2-henning.schild@siemens.com>
On Tue, Feb 21, 2023 at 01:24:12PM +0100, Henning Schild wrote:
> There are two special pins needed to init the LEDs. We used to have them
> at the end of the gpiod_lookup table to give to "leds-gpio". A cleaner
> way is to have a dedicated table for the special pins.
...
> +static struct gpiod_lookup_table simatic_ipc_led_gpio_table_127e_extra = {
> + .dev_id = NULL,
No need.
...
> +static struct gpiod_lookup_table simatic_ipc_led_gpio_table_227g_extra = {
> + .dev_id = NULL,
Ditto.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-02-21 13:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 12:24 [PATCH 0/3] leds: simatic-ipc-leds-gpio: split up Henning Schild
2023-02-21 12:24 ` [PATCH 1/3] leds: simatic-ipc-leds-gpio: move two extra gpio pins into another table Henning Schild
2023-02-21 13:45 ` Andy Shevchenko [this message]
2023-02-21 12:24 ` [PATCH 2/3] leds: simatic-ipc-leds-gpio: split up into multiple drivers Henning Schild
2023-02-21 13:51 ` Andy Shevchenko
2023-02-21 14:43 ` Henning Schild
2023-02-21 14:51 ` Andy Shevchenko
2023-03-01 14:53 ` Hans de Goede
2023-03-01 16:06 ` Lee Jones
2023-03-01 16:45 ` Andy Shevchenko
2023-03-01 16:53 ` Henning Schild
2023-02-21 12:24 ` [PATCH 3/3] leds: simatic-ipc-leds-gpio: introduce more Kconfig switches Henning Schild
2023-02-21 13:52 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/TK4tJZ5kmgsRNJ@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=henning.schild@siemens.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=pavel@ucw.cz \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.