From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netfilter-devel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 9CBECC61DA4
	for <netfilter-devel@archiver.kernel.org>; Wed, 22 Feb 2023 10:04:51 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231127AbjBVKEt (ORCPT
        <rfc822;netfilter-devel@archiver.kernel.org>);
        Wed, 22 Feb 2023 05:04:49 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43552 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S231464AbjBVKEt (ORCPT
        <rfc822;netfilter-devel@vger.kernel.org>);
        Wed, 22 Feb 2023 05:04:49 -0500
Received: from mail.netfilter.org (mail.netfilter.org [217.70.188.207])
        by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3A6F44C07
        for <netfilter-devel@vger.kernel.org>; Wed, 22 Feb 2023 02:04:47 -0800 (PST)
Date:   Wed, 22 Feb 2023 11:04:41 +0100
From:   Pablo Neira Ayuso <pablo@netfilter.org>
To:     Thomas Devoogdt <thomas@devoogdt.com>
Cc:     netfilter-devel@vger.kernel.org,
        Thomas Devoogdt <thomas.devoogdt@barco.com>
Subject: Re: [PATCH] [iptables] extensions: libxt_LOG.c: fix
 linux/netfilter/xt_LOG.h include on Linux < 3.4
Message-ID: <Y/XouZlrtw/SN/C2@salvia>
References: <20230222072349.509917-1-thomas.devoogdt@barco.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20230222072349.509917-1-thomas.devoogdt@barco.com>
Precedence: bulk
List-ID: <netfilter-devel.vger.kernel.org>
X-Mailing-List: netfilter-devel@vger.kernel.org

On Wed, Feb 22, 2023 at 08:23:49AM +0100, Thomas Devoogdt wrote:
> libxt_LOG.c:6:10: fatal error: linux/netfilter/xt_LOG.h: No such file or directory
> . #include <linux/netfilter/xt_LOG.h>
>           ^~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Linux < 3.4 defines are in include/linux/netfilter_ipv{4,6}/ipt_LOG.h,
> but the naming is slightly different, so just define it here as the values are the same.
> 
> https://github.com/torvalds/linux/commit/6939c33a757bd006c5e0b8b5fd429fc587a4d0f4

Probably you could add xt_LOG.h to iptables/include/linux/netfilter/ ?

There are plenty of headers that are cached there to make sure
userspace compile with minimal external dependencies.

xt_LOG.h is missing for some reason in that folder, but there are many
of xt_*.h files there.