From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7ECA5C61DA4 for ; Wed, 22 Feb 2023 15:03:34 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4411685A63; Wed, 22 Feb 2023 16:03:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="NH3gsm2C"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9E89285AD0; Wed, 22 Feb 2023 16:03:26 +0100 (CET) Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [IPv6:2607:f8b0:4864:20::f33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D1796856B7 for ; Wed, 22 Feb 2023 16:03:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf33.google.com with SMTP id ff4so8595283qvb.2 for ; Wed, 22 Feb 2023 07:03:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=3/uSxejCm05gDIq9zX4rIs6KdLCVBv/BDNvPXrQFfJQ=; b=NH3gsm2C801aoVGrbQrwtdU58zoxW21oFx8GHNth9ic502H43XB3umRsXxvPkzBymH nGAsQ3R3Sz84sRnWDHkrbIsfrYLNGGDo7Wn29RKlTMKpHl2AakH/4kPz++PdiNi8I7lN tr3adDLGdH2oWGPR6r7ed82r3Om5Hn4lL+B1A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3/uSxejCm05gDIq9zX4rIs6KdLCVBv/BDNvPXrQFfJQ=; b=kv8P/N1YWwnpNKWUyz9PqfxMsCVnCdGGrfb2b2oGENInKDXwKokeu5GKMafiEwyx6R eY9Kwhuyh6PHNV+03pTlCsbizTERi7DMxzlCc2K5phHK7i6iWKeioPdA3Gpe9u+nb+xs kroMsBxp07kWtz5Db8vDvsxR+7aOCQNDjW45Qzo4RfvrbBrph0cqIdi+rOowwkzPzcrV CV9cyKVYdSz/vjL/k3cDoByJs3JNXi8RSUROZSRyez+ROlTr5KNeF9U+2LePLveUYRm5 RxmUGIpyGxecGJ9P0iePd9XsMjVBzL+GNvjqhyU0ethfa1RWf+EouLT956cJhOTUo/Yg YUgg== X-Gm-Message-State: AO0yUKX251yrA/LNrsjMTTueAf/W5rEZ1Rp1fSittt0JqsC8Kq+r6VLQ CRFfc0d15q1qhw5WP1aWR0A8Yw== X-Google-Smtp-Source: AK7set8hwdzacw6DB1FHQEZzPCSRNUWvYSYSRmzLv6XpZAbnt/d8uVZ8TmRndwm3miyDPBl95fLIhg== X-Received: by 2002:a05:6214:1c49:b0:56e:abb8:b656 with SMTP id if9-20020a0562141c4900b0056eabb8b656mr17638008qvb.7.1677078202473; Wed, 22 Feb 2023 07:03:22 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-0ab3-6707-0dcf-7989.res6.spectrum.com. [2603:6081:7b00:6400:ab3:6707:dcf:7989]) by smtp.gmail.com with ESMTPSA id oq21-20020a05620a611500b0074235fc7a69sm1352708qkn.68.2023.02.22.07.03.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 07:03:22 -0800 (PST) Date: Wed, 22 Feb 2023 10:03:20 -0500 From: Tom Rini To: Quentin Schulz Cc: Troy Kisky , sjg@chromium.org, u-boot@lists.denx.de, gary.bisson@lairdconnect.com, Klaus Goger Subject: Re: [PATCH v1 12/24] ringneck-px30: remove check for ENV_IS_NOWHERE, it is an SPL config Message-ID: References: <20230222013821.1144691-1-troykiskyboundary@gmail.com> <20230222013821.1144691-13-troykiskyboundary@gmail.com> <24f5ac1c-2ffd-7b20-6a5d-6c74406c8a00@theobroma-systems.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="awrlDVXdH9GUxTro" Content-Disposition: inline In-Reply-To: <24f5ac1c-2ffd-7b20-6a5d-6c74406c8a00@theobroma-systems.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --awrlDVXdH9GUxTro Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 22, 2023 at 03:45:17PM +0100, Quentin Schulz wrote: > Hi Troy, >=20 > On 2/22/23 02:38, Troy Kisky wrote: > > When IS_ENABLED(CONFIG_ENV_IS_NOWHERE) is converted to > > CONFIG_IS_ENABLED(ENV_IS_NOWHERE) this will give unwanted errors > > on spl builds. > >=20 > > Signed-off-by: Troy Kisky > > --- > >=20 > > board/theobroma-systems/ringneck_px30/ringneck-px30.c | 4 ---- > > 1 file changed, 4 deletions(-) > >=20 > > diff --git a/board/theobroma-systems/ringneck_px30/ringneck-px30.c b/bo= ard/theobroma-systems/ringneck_px30/ringneck-px30.c > > index 47d1a40ef7c..bb1bb4acf5c 100644 > > --- a/board/theobroma-systems/ringneck_px30/ringneck-px30.c > > +++ b/board/theobroma-systems/ringneck_px30/ringneck-px30.c > > @@ -118,10 +118,6 @@ int mmc_get_env_dev(void) > > return CONFIG_SYS_MMC_ENV_DEV; > > } > > -#if !IS_ENABLED(CONFIG_ENV_IS_NOWHERE) > > -#error Please enable CONFIG_ENV_IS_NOWHERE > > -#endif > > - >=20 > NACK. We absolutely require CONFIG_ENV_IS_NOWHERE for our SoMs in U-Boot OK, so please select it in the config TARGET_... stanza, and make sure doc/board/... explains what's going on. --=20 Tom --awrlDVXdH9GUxTro Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmP2Lq4ACgkQFHw5/5Y0 tyyqDAv/R/vMFxgx0WdbLGnjsHNRJM7GRNbzjVrqT4STQcaPGr9fhNUJR7PtdM8t 1oZdN0dIyF0Nl0V+lppkU3XV52FaX2YLuH8LULC4AoHHmLBFHQOXJ+lIFJUh24yA oNEDLaWBzsirXK8HFi49+n0OK9JRrKJ/aiXtmhTVLn/eMixkHNUMa61J4gCIbpan Uf28fIvWz8vhvJs8FHtg/5ty1FCylnvjalAJBrZqx7upUwbnogdVEOnxyYg7EpVl QsA+MoKydnpYHfBpf9SSGlVlKBuY9UPryYvhKd5VUCgz0NuSULmoskrliLhhiSvF f8OtPEPwN8G/9F84U6dKMq6wctGTRq7/SmHt7EZxEfBrZCmPikKqqZHTZmjasB45 X19C3o6lFG/6tQWq8WPZ5asa/KBxO/lNJDunZoi8gScwmXu9Qfqhf4lKiBw+MBTK ZKKvI+Dl3HCxac4A7A1ijwh0JgzvlGB7Tq9wAd+k4cLw2f+6E9Np3rjNCaeqlD+A 5qUFQ8nW =shZ/ -----END PGP SIGNATURE----- --awrlDVXdH9GUxTro--