From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 030E8C61DA4 for ; Wed, 22 Feb 2023 19:01:36 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9425585B05; Wed, 22 Feb 2023 20:01:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Q0TjLdcI"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1782185B03; Wed, 22 Feb 2023 20:01:25 +0100 (CET) Received: from mail-oa1-x2b.google.com (mail-oa1-x2b.google.com [IPv6:2001:4860:4864:20::2b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 254B785903 for ; Wed, 22 Feb 2023 20:01:16 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-172334d5c8aso7413712fac.8 for ; Wed, 22 Feb 2023 11:01:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+rkba/TU/C4fvw/2+2m/Uv5F2+gyqLoWbLDL91RYADI=; b=Q0TjLdcI1fEicRZPIDUMcLBIRpPi5DEA8+8SUX8X2x+B32j+pI8R1n87Fp3z2yCdMv r5kqtMGvyK5h/qBPX11blZOQzi4m3JOfaNMI/v1ybFWZPHMXNoRvFyl6k1YWEKOx5KtA ZMOg2q1r7Scg+bVrNtBP9j9JGtKaO0BUY8IT8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+rkba/TU/C4fvw/2+2m/Uv5F2+gyqLoWbLDL91RYADI=; b=6gzlbRkpdldjdYVY7DVWkaSws0dU2eYb2pxe3uGuGiF4W7KMYht47T3Zsh1LUkxPjE bnGqzt4F8M7NL+8UTT48F8Oso7QzpO8T3Xx0trpmMJRGfVaUgenwtSpkYRC5a7en+RIZ IV7L8OnvCzORhrgpzahVdqP9qlCa1sWAkScyJFtYcookL7vNKQ/ckMYaGGtS6YNJCSQn 8B87eMMFB2srxcYevQwZK4o8fOSL+PTSGuIzorem6h7ANFCD2JmVyA/9SNdP7BlwEANO Axpr5ok7kDKe20DC9gdO1c/+Rywwfz8siewl1gYGmc+i8sVF09+g+UZuKMNE11mFYbsQ FfWQ== X-Gm-Message-State: AO0yUKV3j59MqZ9nI/iY/sVSKugwGXzGswUetgu1fYlYBOSCj2wlOLTC a5kH+u/WsFJWtuEQ4JViv/u5T23Ab47Yos/+1VQ= X-Google-Smtp-Source: AK7set9OuzfzHB9djXaKpp2ZGTJzIyuB5ORTnVoU+YD4zeNjjhfTi+I0A84nVyiArW5XO5aCtJasqg== X-Received: by 2002:a05:6870:958e:b0:172:45ff:6293 with SMTP id k14-20020a056870958e00b0017245ff6293mr2343517oao.26.1677092474321; Wed, 22 Feb 2023 11:01:14 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-b87e-a945-7631-50d9.res6.spectrum.com. [2603:6081:7b00:6400:b87e:a945:7631:50d9]) by smtp.gmail.com with ESMTPSA id a184-20020a3798c1000000b007423caef02fsm832529qke.122.2023.02.22.11.01.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 11:01:13 -0800 (PST) Date: Wed, 22 Feb 2023 14:01:11 -0500 From: Tom Rini To: Simon Glass Cc: Jonas Karlman , Vagrant Cascadian , U-Boot Mailing List , huang lin , Jeffy Chen , Kever Yang , Akash Gajjar , Jagan Teki Subject: Re: [PATCH 2/3] rockchip: Disable DISTRO_DEFAULTS for rockpro64 Message-ID: References: <20230221193920.3546499-1-sjg@chromium.org> <20230221193920.3546499-2-sjg@chromium.org> <875ybur3zm.fsf@contorta> <877cw9y354.fsf@contorta> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="wNVSScyLMpfkkojn" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --wNVSScyLMpfkkojn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 22, 2023 at 11:58:37AM -0700, Simon Glass wrote: > Hi, >=20 > On Wed, 22 Feb 2023 at 11:56, Jonas Karlman wrote: > > > > On 2023-02-22 19:24, Tom Rini wrote: > > > On Wed, Feb 22, 2023 at 10:19:03AM -0800, Vagrant Cascadian wrote: > > >> On 2023-02-21, Vagrant Cascadian wrote: > > >>> On 2023-02-21, Simon Glass wrote: > > >>>> This board has moved to standard boot but the old 'distro_bootcmd' > > >>>> command is still active. Disable DISTRO_DEFAULTS to fix this. > > >>> > > >>> Works for booting rockpro64-rk3399, thanks! > > >> > > >> I can also confirm that applying a very similar patch for > > >> pinebook-pro-rk3399 works booting with bootstd. > > >> > > >> Seems worth adding if there is a v2 of the patch series. > > >> > > >> Alternately, rather than doing this on a board-by-board basis, is th= ere > > >> some way to disable CONFIG_DISTRO_DEFAULTS when a board is using > > >> BOOTSTD? > > > > > > I think that's possibly a bit dangerous? DISTRO_DEFAULTS and > > > BOOTSTD_DEFAULTS need to be reconciled to a single new symbol, and the > > > DISTRO_DEFAULTS method of select not imply for most things is also I > > > suspect the right path. > > > > > > > Another option would be to set BOOTSTD_BOOTCOMMAND=3Dy, this is the main > > issue with rk3399 at the moment, distro_bootcmd got removed from env, > > yet bootcmd is still "run distro_bootcmd" due to DISTRO_DEFAULTS=3Dy. > > > > > > config BOOTCOMMAND > > default "bootflow scan -lb" if BOOTSTD_BOOTCOMMAND && CMD_BOOTF= LOW_FULL > > default "bootflow scan" if BOOTSTD_BOOTCOMMAND && !CMD_BOOTFLOW= _FULL > > default "run distro_bootcmd" if !BOOTSTD_BOOTCOMMAND && DISTRO_= DEFAULTS > > > > config BOOTSTD_BOOTCOMMAND > > default y if !DISTRO_DEFAULTS >=20 > That seems reasonable to me, along with a 'depends on BOOTSTD' >=20 > At present DISTRO_DEFAULTS is both enabled in defconfig files (about > 350) and Kconfig (another 300). For rockchip it is the latter. >=20 > It doesn't really make sense to use DISTRO_DEFAULTS when using > BOOTSTD_DEFAULTS. One is 'run distro_bootcmd' and the other is > 'bootflow scan', possibly with -lb flags. But we really don't want > people flipping back and forward. It doesn't make linguistic sense to have "distro defaults" and "bootstd defaults" enabled. It makes compute sense to have these two symbols combined as they're nearly identical and have a similar conceptual need (make sure we have things like bootz/booti/ext4/etc support). --=20 Tom --wNVSScyLMpfkkojn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmP2ZnQACgkQFHw5/5Y0 tyw0fQv/cZ4bSwfiOD4FwR06QiBAwgILj0myyXusRYBa6FgAAQvuOT7sd80FVjSl pCbb7ihhZgF5aLxJnXSl+hDRNo6YcVpLhzg4kFNqZmTmdqtUwk7SrJvUtS/1em38 QTaqYIcdfQG2JYN/BJhX531aUSmUNUJ33cZhy+wIPzvWDKNbB99nTrGuyjt42bGW nnSyOnxDsBu/3Jyy+auihgtG3+91Dv5QgcVPyCgVX28JnJJ8b4AMBFdE/9Ov6XlL PMsS8t9yGYKB8ZjnUkgtn+zCsfHiPHJO9dx8ZVu2fjlNi4p9hs2MYYF5KmyYHMPH JYwkS/8iaEi8Bm7+CxYFiT897byBgQwX4iP9AW2vQSgutdEub1LM/iaKMpZ6WukV kCJ6Qe2A0o5T/KepS7CxXBMl4g2Zp+WZnEVZ0bH8kDz1kbaOai4KXjme0gB5irg0 sYQ8VsX9hNOe4ON4N0oeUEmuFfXVfdeCC68yj2Az6UXEo4q6SLYcw5TrHOU83fB8 WttVHcZU =V8Qz -----END PGP SIGNATURE----- --wNVSScyLMpfkkojn--