From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B7F7C636D6 for ; Wed, 22 Feb 2023 19:17:02 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5DA4D85B88; Wed, 22 Feb 2023 20:15:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="YUBxeN+R"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 48B0285B52; Wed, 22 Feb 2023 20:15:31 +0100 (CET) Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9543385B6B for ; Wed, 22 Feb 2023 20:15:26 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf34.google.com with SMTP id op8so9910020qvb.11 for ; Wed, 22 Feb 2023 11:15:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JEZbPJplAGdK2hfwSQL6KlRgrG/rZHE93AGRt5yUxE4=; b=YUBxeN+Rt6dD4MXNxHPA3ukey8DIgqn4lsDrl11pIRnc6ZgezryFMqvoQe8P8ofmPK VBtYsbcmnvdyVo0XGeYE4JKD8PV3sXEsm2Z4qi++eFxajg1YhOa7A55zFfxa/hjUlfnp eXhWKP1PPYQ6/1xP5FhXYN+1ObJKPsQ54JhfM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=JEZbPJplAGdK2hfwSQL6KlRgrG/rZHE93AGRt5yUxE4=; b=NcPr7ttG/eRx7i6jk0uOpH4cKnyQYmwXXfseeKPzQoJUq4hQpRzML88n9I52r/8ndC 2Wv8yHGpOOoc/vEMa45NlQ9VzSRTk0lPoHj8mGjYACdVOQCRfrHp8XHGgDWESTDfeKsT qmuQnFElJBB8e57yjh1J3jzLeuoFuf8Q3K5A+jcDCFafuf1O/yM+w57T3Bbg5cihulRd iQZ5A1nDtvd8jZAf/08AlbXPmimQqn2VCelgQKTfvFKZjIR8m6h1KtF5Stp8gyET0sn1 X7OCxlG5tt3dbW2G1cp2gK7dTECmn+gI/yuXxcbfFOdzwsfKcXY0fmp4sYdB3tefXlQw y/4g== X-Gm-Message-State: AO0yUKWDcObri8SvUs7nvgfpPb/EeSZV5Yx1ZvckF33JB2pM/hsVbEzj zhWhZCDfaOrTnxzx+/rJuMB2Rw== X-Google-Smtp-Source: AK7set8W9vPEmcUrb8bi7SlGx1D03D4Si4AfLkxSz1knUehD+pIai+6S/VYPuJgnqPYzK4lcNuYrbQ== X-Received: by 2002:ad4:596b:0:b0:56e:aa8b:9103 with SMTP id eq11-20020ad4596b000000b0056eaa8b9103mr16328446qvb.52.1677093325346; Wed, 22 Feb 2023 11:15:25 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-b87e-a945-7631-50d9.res6.spectrum.com. [2603:6081:7b00:6400:b87e:a945:7631:50d9]) by smtp.gmail.com with ESMTPSA id n205-20020a3740d6000000b0073b7f2a0bcbsm1356447qka.36.2023.02.22.11.15.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Feb 2023 11:15:25 -0800 (PST) Date: Wed, 22 Feb 2023 14:15:23 -0500 From: Tom Rini To: Simon Glass Cc: Jonas Karlman , Vagrant Cascadian , U-Boot Mailing List , huang lin , Jeffy Chen , Kever Yang , Akash Gajjar , Jagan Teki Subject: Re: [PATCH 2/3] rockchip: Disable DISTRO_DEFAULTS for rockpro64 Message-ID: References: <20230221193920.3546499-1-sjg@chromium.org> <20230221193920.3546499-2-sjg@chromium.org> <875ybur3zm.fsf@contorta> <877cw9y354.fsf@contorta> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zw1xAsGYj3Y8a/1c" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --zw1xAsGYj3Y8a/1c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 22, 2023 at 12:03:58PM -0700, Simon Glass wrote: > Hi Tom, >=20 > On Wed, 22 Feb 2023 at 12:01, Tom Rini wrote: > > > > On Wed, Feb 22, 2023 at 11:58:37AM -0700, Simon Glass wrote: > > > Hi, > > > > > > On Wed, 22 Feb 2023 at 11:56, Jonas Karlman wrote: > > > > > > > > On 2023-02-22 19:24, Tom Rini wrote: > > > > > On Wed, Feb 22, 2023 at 10:19:03AM -0800, Vagrant Cascadian wrote: > > > > >> On 2023-02-21, Vagrant Cascadian wrote: > > > > >>> On 2023-02-21, Simon Glass wrote: > > > > >>>> This board has moved to standard boot but the old 'distro_boot= cmd' > > > > >>>> command is still active. Disable DISTRO_DEFAULTS to fix this. > > > > >>> > > > > >>> Works for booting rockpro64-rk3399, thanks! > > > > >> > > > > >> I can also confirm that applying a very similar patch for > > > > >> pinebook-pro-rk3399 works booting with bootstd. > > > > >> > > > > >> Seems worth adding if there is a v2 of the patch series. > > > > >> > > > > >> Alternately, rather than doing this on a board-by-board basis, i= s there > > > > >> some way to disable CONFIG_DISTRO_DEFAULTS when a board is using > > > > >> BOOTSTD? > > > > > > > > > > I think that's possibly a bit dangerous? DISTRO_DEFAULTS and > > > > > BOOTSTD_DEFAULTS need to be reconciled to a single new symbol, an= d the > > > > > DISTRO_DEFAULTS method of select not imply for most things is als= o I > > > > > suspect the right path. > > > > > > > > > > > > > Another option would be to set BOOTSTD_BOOTCOMMAND=3Dy, this is the= main > > > > issue with rk3399 at the moment, distro_bootcmd got removed from en= v, > > > > yet bootcmd is still "run distro_bootcmd" due to DISTRO_DEFAULTS=3D= y. > > > > > > > > > > > > config BOOTCOMMAND > > > > default "bootflow scan -lb" if BOOTSTD_BOOTCOMMAND && CMD_B= OOTFLOW_FULL > > > > default "bootflow scan" if BOOTSTD_BOOTCOMMAND && !CMD_BOOT= FLOW_FULL > > > > default "run distro_bootcmd" if !BOOTSTD_BOOTCOMMAND && DIS= TRO_DEFAULTS > > > > > > > > config BOOTSTD_BOOTCOMMAND > > > > default y if !DISTRO_DEFAULTS > > > > > > That seems reasonable to me, along with a 'depends on BOOTSTD' > > > > > > At present DISTRO_DEFAULTS is both enabled in defconfig files (about > > > 350) and Kconfig (another 300). For rockchip it is the latter. > > > > > > It doesn't really make sense to use DISTRO_DEFAULTS when using > > > BOOTSTD_DEFAULTS. One is 'run distro_bootcmd' and the other is > > > 'bootflow scan', possibly with -lb flags. But we really don't want > > > people flipping back and forward. > > > > It doesn't make linguistic sense to have "distro defaults" and "bootstd > > defaults" enabled. It makes compute sense to have these two symbols > > combined as they're nearly identical and have a similar conceptual need > > (make sure we have things like bootz/booti/ext4/etc support). >=20 > Oh, so you are talking about DISTRO_DEFAULTS, not the actual command? > In that case I can do a patch to make them both use a common symbol to > bring in most stuff, although bootstd does not need hush and a few > other things that are needed by distro_bootcmd. >=20 > Let me know if that makes sense. Yeah, the Kconfig symbols DISTRO_DEFAULTS and BOOTSTD_DEFAULTS need to be reconciled and combined. This is separate from setting bootcmd to "run distro_bootcmd", which should be separate, and yes, not be the chosen symbol when we have bootstd enabled. --=20 Tom --zw1xAsGYj3Y8a/1c Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmP2acAACgkQFHw5/5Y0 tyxq0Av8Cr9ZweeDSIqiLBXuyb+N1bUda1prcdEgWoBO7DPprrD8/Q7MQyj4CpCs Ybp06K9Rze+3+JHfU4XFoL/p+OJu08iH9cGAxrXLi9o7OMzT4FQEaphpFPXqtLCk +OWDmqt7se/xCth4bbcpkYmnCExv0vWirUdTbKK7FXxmK8MwwrWO1TfN2sjto4Vz ymLnFBaaYBi0cT5oEtlTwqoLqpAgYfEfKvsZBLijCiJ5r2LPD9M2JdwimkRBM26k A2e4E8mx/nqsQmTBW8SiuBbLvo5nDdq0+VdPVyQZIwGX37d9sf9rQ4XgDGjQ4wNT 3PPkyUEJtiVVj3GsNaB6yvaQqoTgzzCJMFtx8hY2ikUybWe6wXeahG4C41is9zga /aVtF4X3/uDdDDtrI6v48PtLjtsj4nesZ+gZZ+h5Z17HrQVSUE3tFW3e9hzerUEq gAyTabxe+8XEpqMC3waBiJpZhCsevRJHUKMhrbC2Tjiv5BZVN+bITGDjJ7Dz99Qg 2cA3YnC3 =eZSy -----END PGP SIGNATURE----- --zw1xAsGYj3Y8a/1c--