From: Huang Rui <ray.huang@amd.com>
To: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: "Limonciello, Mario" <Mario.Limonciello@amd.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cpufreq: amd-pstate: Let user know amd-pstate is disabled
Date: Thu, 23 Feb 2023 12:33:04 +0800 [thread overview]
Message-ID: <Y/bsgIipfVLXXvhw@amd.com> (raw)
In-Reply-To: <20230223013032.2011601-1-kai.heng.feng@canonical.com>
On Thu, Feb 23, 2023 at 09:30:32AM +0800, Kai-Heng Feng wrote:
> Commit 202e683df37c ("cpufreq: amd-pstate: add amd-pstate driver
> parameter for mode selection") changed the driver to be disabled by
> default, and this can suprise users.
>
> Let users know what happened so they can decide what to do next.
>
> BugLink: https://bugs.launchpad.net/bugs/2006942
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Acked-by: Huang Rui <ray.huang@amd.com>
> ---
> drivers/cpufreq/amd-pstate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index 45c88894fd8e..305f73f657ed 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -1263,7 +1263,7 @@ static int __init amd_pstate_init(void)
> * with amd_pstate=passive or other modes in kernel command line
> */
> if (cppc_state == AMD_PSTATE_DISABLE) {
> - pr_debug("driver load is disabled, boot with specific mode to enable this\n");
> + pr_info("amd_pstate is disabled, boot with specific mode to enable this\n");
> return -ENODEV;
> }
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-02-23 4:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 1:30 [PATCH] cpufreq: amd-pstate: Let user know amd-pstate is disabled Kai-Heng Feng
2023-02-23 4:33 ` Huang Rui [this message]
2023-02-23 5:02 ` Mario Limonciello
2023-02-23 6:49 ` Kai-Heng Feng
2023-02-23 19:26 ` Limonciello, Mario
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/bsgIipfVLXXvhw@amd.com \
--to=ray.huang@amd.com \
--cc=Mario.Limonciello@amd.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.