From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD05DC64ED6 for ; Thu, 23 Feb 2023 14:07:40 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pVCFq-0007A7-5P; Thu, 23 Feb 2023 09:07:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVCFn-000791-Kk for qemu-devel@nongnu.org; Thu, 23 Feb 2023 09:07:23 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVCFl-0006y1-Qf for qemu-devel@nongnu.org; Thu, 23 Feb 2023 09:07:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1677161239; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hYnhTGmlMRKyUHcKm2UjJvlsgra3XUwr9QyxnX+m8o8=; b=YWEyzixc9y13jG9IMp/fxTRqTBC9jS9K6btiR5tpN5gyiB2eekMdMwDMTDHqKKNfAmhe7D iMMxU3J/nO4a+YRO98sgdHd4D9TJ2S6SPiBkd0OPefZGY3Nz0RaJVMqQunyPodiuOUKSpK HdLFFuEroSPBKIQM0xJzaTJwTz00NBA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-211-yxn29BV0OT68oBr44Djcbg-1; Thu, 23 Feb 2023 09:07:16 -0500 X-MC-Unique: yxn29BV0OT68oBr44Djcbg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1492C196EFA2; Thu, 23 Feb 2023 14:02:14 +0000 (UTC) Received: from redhat.com (unknown [10.33.36.113]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A0ECB410B317; Thu, 23 Feb 2023 14:02:12 +0000 (UTC) Date: Thu, 23 Feb 2023 14:02:09 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Cc: qemu-devel@nongnu.org, Alex =?utf-8?Q?Benn=C3=A9e?= , Peter Maydell , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Stefan Hajnoczi , Richard Henderson , Fabiano Rosas Subject: Re: [PATCH v2 5/5] gitlab-ci.d: Build with --enable-fdt=system by default Message-ID: References: <20230207201447.566661-1-thuth@redhat.com> <20230207201447.566661-6-thuth@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230207201447.566661-6-thuth@redhat.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Feb 07, 2023 at 09:14:47PM +0100, Thomas Huth wrote: > By using --enable-fdt=system we can make sure that the configure > script does not try to check out the "dtc" submodule. This should > help to safe some precious CI minutes in the long run. If our containers have the system dtc installed, I'm pretty surprised that configure is choosing to use dtc submodule. I thought we won't touch the submodule at all if system dtc was sufficiently new. IOW, do we have a logic bug in configure making it incorrectly use dtc submodules ? > While we're at it, also drop some now-redundant --enable-slirp > and --enable-capstone statements. These used to have the "=system" > suffix in the past, too, which has been dropped when the their > corresponding submodules had been removed. Since these features > are auto-enabled anyway now (since the containers have the right > libraries installed), we do not need the explicit --enable-... > statements anymore. > > Signed-off-by: Thomas Huth > --- > .gitlab-ci.d/buildtest-template.yml | 2 +- > .gitlab-ci.d/buildtest.yml | 9 +++------ > .gitlab-ci.d/crossbuild-template.yml | 5 +++-- > .gitlab-ci.d/crossbuilds.yml | 2 ++ > .gitlab-ci.d/windows.yml | 7 +++++-- > 5 files changed, 14 insertions(+), 11 deletions(-) Reviewed-by: Daniel P. Berrangé since it at least does what it claims, even if it the configure logic is questionable. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|